line endings

View: New views
5 Messages — Rating Filter:   Alert me  

line endings

by tom fogal-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

Our patch series for loading OGL dynamically is looking pretty good,
and we're hoping to submit it for review here soon.

One issue we're having as we work cross platform is line endings;
mismatches cause patches to be (much) larger than they should be.  It
looks like the subversion eol-style is not set correctly in GLEW svn.
Could someone with commit access recursively set eol-style to native,
please?

Further background on why this is relevant is in the svn redbook:

  http://svnbook.red-bean.com/en/1.5/svn.advanced.props.file-portability.html#svn.advanced.props.special.eol-style

This basically amounts to:

  find . \( -iname \*.c -or \
            -iname \*.h -or \
            -iname \*.pl -or \
            -iname \*.pm -or \
            -iname \*.txt -or \
            -iname \*.html -or \
            -iname Makefile\* \
         \) \
    -exec svn propset svn:eol-style native {} +
  svn commit -m 'fix line endings.'

Thanks,

-tom

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
glew-coders mailing list
glew-coders@...
https://lists.sourceforge.net/lists/listinfo/glew-coders

Re: line endings

by Nigel Stewart-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Tom,

Is this the list you get, or have I messed something up?

- Nigel

-----------------------------

$ svn diff

Property changes on: LICENSE.txt
___________________________________________________________________
Name: svn:eol-style
    + native


Property changes on: config/Makefile.cygming
___________________________________________________________________
Name: svn:eol-style
    + native


Property changes on: doc/khronos.txt
___________________________________________________________________
Name: svn:eol-style
    + native


Property changes on: doc/mesa.txt
___________________________________________________________________
Name: svn:eol-style
    + native


Property changes on: doc/glew.txt
___________________________________________________________________
Name: svn:eol-style
    + native


Property changes on: auto/src/khronos_license.h
___________________________________________________________________
Name: svn:eol-style
    + native


Property changes on: auto/src/mesa_license.h
___________________________________________________________________
Name: svn:eol-style
    + native




-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
glew-coders mailing list
glew-coders@...
https://lists.sourceforge.net/lists/listinfo/glew-coders

Re: line endings

by tom fogal-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Nigel Stewart <nstewart@...> writes:
> Tom,
>
> Is this the list you get, or have I messed something up?

Hrm; yes, now that I test on a client from an svn repo.  As I look at
it though, these files should not be an issue because I don't think
they've been touched in our branch.

Not that I don't think updating the eol-style on these files is a Good
Thing, but this might be noise (sorry).  CC'ing Jianrong so he can
clarify -- Jianrong, if you drop the line endings patch can you apply
everything else cleanly on top of current GLEW svn [1]?

-tom

[1] uri: https://glew.svn.sourceforge.net/svnroot/glew, e.g. `svn co
    https://...'

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
glew-coders mailing list
glew-coders@...
https://lists.sourceforge.net/lists/listinfo/glew-coders

Re: line endings

by Jianrong Shu :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

I did a rebase on Mac (previously I did it on Windows), and was able to drop
out the line endings patch. So now all the patches are clean.

Jianrong

-----Original Message-----
From: tom fogal [mailto:tfogal@...]
Sent: Monday, October 05, 2009 8:31 PM
To: Nigel Stewart
Cc: glew-coders@...; jshu@...
Subject: Re: [glew-coders] line endings

Nigel Stewart <nstewart@...> writes:
> Tom,
>
> Is this the list you get, or have I messed something up?

Hrm; yes, now that I test on a client from an svn repo.  As I look at
it though, these files should not be an issue because I don't think
they've been touched in our branch.

Not that I don't think updating the eol-style on these files is a Good
Thing, but this might be noise (sorry).  CC'ing Jianrong so he can
clarify -- Jianrong, if you drop the line endings patch can you apply
everything else cleanly on top of current GLEW svn [1]?

-tom

[1] uri: https://glew.svn.sourceforge.net/svnroot/glew, e.g. `svn co
    https://...'

----------------------------------------------------------------------------
--
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
glew-coders mailing list
glew-coders@...
https://lists.sourceforge.net/lists/listinfo/glew-coders


------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
glew-coders mailing list
glew-coders@...
https://lists.sourceforge.net/lists/listinfo/glew-coders

Re: line endings

by Nigel Stewart-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


> I did a rebase on Mac (previously I did it on Windows), and was able to drop
> out the line endings patch. So now all the patches are clean.

Oh good.  Well, glad to have the issue apparently resolved.

I'll go ahead and submit my change anyway - since I do tend
to like things in "native" text format anyway. :-)

- Nigel

-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information.  Any unauthorized review, use, disclosure or distribution
is prohibited.  If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
glew-coders mailing list
glew-coders@...
https://lists.sourceforge.net/lists/listinfo/glew-coders