log4cxx and gcc 4.3.4

View: New views
2 Messages — Rating Filter:   Alert me  

log4cxx and gcc 4.3.4

by Marian Aldenhövel-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

The version 0.9.7 of log4cxx that is in T2 apparently does not build
with GCC 4.3.4. It is complaining about memcpy, strtok, strlen etc not
being definied.

I managed to find out that there was a header-cleanup at some stage so
that the offending source files now need to #include <cstring> to fix
those problems.

I tried my (very unexperienced) hand at creating a patch for that
problem and have attached it.

There is a version 0.10.x of log4cxx out, but it adds a dependency on
the apache portable runtime which I did not want to put into my build
just yet. So patching 0.9.7 is valid for me, and maybe for others as well.

Ciao, MM

--- log4cxx-0.9.7/src/socketoutputstream.cpp.vanilla 2009-10-22 09:45:32.000000000 +0200
+++ log4cxx-0.9.7/src/socketoutputstream.cpp 2009-10-22 09:45:54.000000000 +0200
@@ -13,6 +13,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+#include <cstring>
 
 #include <log4cxx/helpers/socketoutputstream.h>
 #include <log4cxx/helpers/socket.h>
--- log4cxx-0.9.7/src/stringtokenizer.cpp.vanilla 2009-10-22 10:03:12.000000000 +0200
+++ log4cxx-0.9.7/src/stringtokenizer.cpp 2009-10-22 10:03:45.000000000 +0200
@@ -13,6 +13,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+#include <cstring>
 
 #include <log4cxx/helpers/stringtokenizer.h>
 
--- log4cxx-0.9.7/src/socketinputstream.cpp.vanilla 2009-10-22 10:04:37.000000000 +0200
+++ log4cxx-0.9.7/src/socketinputstream.cpp 2009-10-22 10:04:46.000000000 +0200
@@ -13,6 +13,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+#include <cstring>
 
 #include <log4cxx/helpers/socketinputstream.h>
 #include <log4cxx/helpers/socket.h>
--- log4cxx-0.9.7/src/xmlsocketappender.cpp.vanilla 2009-10-22 10:12:43.000000000 +0200
+++ log4cxx-0.9.7/src/xmlsocketappender.cpp 2009-10-22 10:12:50.000000000 +0200
@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+#include <cstring>
+
 #include <log4cxx/net/xmlsocketappender.h>
 #include <log4cxx/helpers/loglog.h>
 #include <log4cxx/helpers/socketoutputstream.h>
--- log4cxx-0.9.7/src/timezone.cpp.vanilla 2009-10-22 10:12:12.000000000 +0200
+++ log4cxx-0.9.7/src/timezone.cpp 2009-10-22 10:12:19.000000000 +0200
@@ -13,6 +13,8 @@
  * See the License for the specific language governing permissions and
  * limitations under the License.
  */
+
+#include <cstring>
 
 #include <log4cxx/helpers/timezone.h>
 #include <locale>
--- log4cxx-0.9.7/tests/src/drfatestcase.cpp.vanilla 2009-10-22 10:13:07.000000000 +0200
+++ log4cxx-0.9.7/tests/src/drfatestcase.cpp 2009-10-22 10:13:13.000000000 +0200
@@ -14,6 +14,8 @@
  * limitations under the License.
  */
 
+#include <cstring>
+
 #include <cppunit/TestFixture.h>
 #include <cppunit/extensions/HelperMacros.h>
 

-----------------------------------------------------------
If you wish to unsubscribe from this mailing, send mail to
lists@... with a subject of: unsubscribe t2

Re: log4cxx and gcc 4.3.4

by Aldas Nabazas-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Marian,

Your patch worked but it wasn't enough , had to make another very small fix, please test and let me know if it's fine.

r34741 and r34742

Cheers,
Aldas

On Thu, Oct 22, 2009 at 8:30 AM, Marian Aldenhövel <marian.aldenhoevel@...> wrote:
Hi,

The version 0.9.7 of log4cxx that is in T2 apparently does not build with GCC 4.3.4. It is complaining about memcpy, strtok, strlen etc not being definied.

I managed to find out that there was a header-cleanup at some stage so that the offending source files now need to #include <cstring> to fix those problems.

I tried my (very unexperienced) hand at creating a patch for that problem and have attached it.

There is a version 0.10.x of log4cxx out, but it adds a dependency on the apache portable runtime which I did not want to put into my build just yet. So patching 0.9.7 is valid for me, and maybe for others as well.

Ciao, MM

--- log4cxx-0.9.7/src/socketoutputstream.cpp.vanilla    2009-10-22 09:45:32.000000000 +0200
+++ log4cxx-0.9.7/src/socketoutputstream.cpp    2009-10-22 09:45:54.000000000 +0200
@@ -13,6 +13,8 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
+#include <cstring>

 #include <log4cxx/helpers/socketoutputstream.h>
 #include <log4cxx/helpers/socket.h>
--- log4cxx-0.9.7/src/stringtokenizer.cpp.vanilla       2009-10-22 10:03:12.000000000 +0200
+++ log4cxx-0.9.7/src/stringtokenizer.cpp       2009-10-22 10:03:45.000000000 +0200
@@ -13,6 +13,8 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
+#include <cstring>

 #include <log4cxx/helpers/stringtokenizer.h>

--- log4cxx-0.9.7/src/socketinputstream.cpp.vanilla     2009-10-22 10:04:37.000000000 +0200
+++ log4cxx-0.9.7/src/socketinputstream.cpp     2009-10-22 10:04:46.000000000 +0200
@@ -13,6 +13,8 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
+#include <cstring>

 #include <log4cxx/helpers/socketinputstream.h>
 #include <log4cxx/helpers/socket.h>
--- log4cxx-0.9.7/src/xmlsocketappender.cpp.vanilla     2009-10-22 10:12:43.000000000 +0200
+++ log4cxx-0.9.7/src/xmlsocketappender.cpp     2009-10-22 10:12:50.000000000 +0200
@@ -14,6 +14,8 @@
 * limitations under the License.
 */

+#include <cstring>
+
 #include <log4cxx/net/xmlsocketappender.h>
 #include <log4cxx/helpers/loglog.h>
 #include <log4cxx/helpers/socketoutputstream.h>
--- log4cxx-0.9.7/src/timezone.cpp.vanilla      2009-10-22 10:12:12.000000000 +0200
+++ log4cxx-0.9.7/src/timezone.cpp      2009-10-22 10:12:19.000000000 +0200
@@ -13,6 +13,8 @@
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
+
+#include <cstring>

 #include <log4cxx/helpers/timezone.h>
 #include <locale>
--- log4cxx-0.9.7/tests/src/drfatestcase.cpp.vanilla    2009-10-22 10:13:07.000000000 +0200
+++ log4cxx-0.9.7/tests/src/drfatestcase.cpp    2009-10-22 10:13:13.000000000 +0200
@@ -14,6 +14,8 @@
 * limitations under the License.
 */

+#include <cstring>
+
 #include <cppunit/TestFixture.h>
 #include <cppunit/extensions/HelperMacros.h>


-----------------------------------------------------------
If you wish to unsubscribe from this mailing, send mail to
lists@... with a subject of: unsubscribe t2



-----------------------------------------------------------
If you wish to unsubscribe from this mailing, send mail to
lists@... with a subject of: unsubscribe t2