nautilus not_getting_color_updates.patch

[Виталий Верпаховский]

Hi
Emit the APPEARANCE_CHANGED signal when we're setting the color,
as we're ignoring the pending changes after the backgorund ornament is realized
new tabs, and thus we're not getting color updates

Example (for nautilus 2.26.0 ... 2.28.1):

first tab:
http://forum.lafox.net/index.php?act=attach&type=post&id=6342
second tab:
http://forum.lafox.net/index.php?act=attach&type=post&id=6343

patch:
Emit the APPEARANCE_CHANGED signal when we're setting the color,
as we're ignoring the pending changes after the backgorund ornament is realized
new tabs, and thus we're not getting color updates .
elipse <comp_art@...>
Index: nautilus-2.28.1/nautilus-2.28.1/eel/eel-background.c
===================================================================
--- nautilus-2.28.1.orig/eel/eel-background.c 2009-09-25 15:43:18.000000000 +0300
+++ nautilus-2.28.1/eel/eel-background.c 2009-10-30 04:32:20.000000000 +0200
@@ -589,7 +589,7 @@
  }
 
  set_image_properties (background);
-
+ g_signal_emit (background, signals[APPEARANCE_CHANGED], 0);
  g_free (filename);
 
  return TRUE;




      ________________________________________________________
Вы уже с Yahoo!?
Испытайте обновленную и улучшенную. Yahoo! Почту! http://ru.mail.yahoo.com

--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list

[Alexander Larsson]

On Thu, 2009-10-29 at 21:02 -0700, Виталий Верпаховский wrote:

> Hi
> Emit the APPEARANCE_CHANGED signal when we're setting the color,
> as we're ignoring the pending changes after the backgorund ornament is
> realized
> new tabs, and thus we're not getting color updates
>
> Example (for nautilus 2.26.0 ... 2.28.1):
>
> first tab:
> http://forum.lafox.net/index.php?act=attach&type=post&id=6342
> second tab:
> http://forum.lafox.net/index.php?act=attach&type=post&id=6343

I don't understand exactly what the problem is, can you explain in more
detail?

--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc
       alexl@...            alexander.larsson@...
He's a bookish flyboy rock star who must take medication to keep him sane.
She's a disco-crazy hypochondriac college professor in the wrong place at the
wrong time. They fight crime!

--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list

[bogdanb]

2009/11/27 Alexander Larsson <alexl@...>

> first tab:
> http://forum.lafox.net/index.php?act=attach&type=post&id=6342
> second tab:
> http://forum.lafox.net/index.php?act=attach&type=post&id=6343

I don't understand exactly what the problem is, can you explain in more
detail?

The icon labels have different colors in the two screenshots, I assume that's what he meant

-- Bogdan Butnaru
--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list

[Alexander Larsson]

On Thu, 2009-10-29 at 21:02 -0700, Виталий Верпаховский wrote:
> Hi
> Emit the APPEARANCE_CHANGED signal when we're setting the color,
> as we're ignoring the pending changes after the backgorund ornament is
> realized
> new tabs, and thus we're not getting color updates

This patch is not right (and in fact, the similar patch commited in bug
578136 was wrong too). The real problem is a bit deeper, but is fixed
with:

http://git.gnome.org/cgit/nautilus/commit/?id=002bea81792cdfe6f4e45da95a59708040566171

--
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 Alexander Larsson                                            Red Hat, Inc
       alexl@...            alexander.larsson@...
He's an otherworldly small-town firefighter who hangs with the wrong crowd.
She's a psychotic African-American mermaid on the trail of a serial killer.
They fight crime!

--
nautilus-list mailing list
nautilus-list@...
http://mail.gnome.org/mailman/listinfo/nautilus-list