new version of pcsc-lite 1.5.5

[Ludovic Rousseau]

Hello,

A new version of pcsc-lite 1.5.5 is available at [1].
This version fixes bugs. No new feature added.

Changelog:
pcsc-lite-1.5.5: Ludovic Rousseau
28 July 2009
- add the reader interface name if provided by the device
- SCardTransmit(): return SCARD_E_UNSUPPORTED_FEATURE if
  SCARD_PROTOCOL_RAW is requested by unsupported
- SCardConnect() and SCardReconnect(): set dwActiveProtocol to
  SCARD_PROTOCOL_UNDEFINED if SCARD_SHARE_DIRECT is used (conform to
  MSDN). Contrary to Windows winscard behavior, the reader is accessed in
  shared mode and not exclusive mode if SCARD_SHARE_DIRECT is used.
- SCardControl(): correctly check for buffer overflow (bug introduced in
  pcsc-lite 1.5.4)
- some other minor improvements and bug corrections

[1] https://alioth.debian.org/frs/?group_id=30105&release_id=1378

--
 Dr. Ludovic Rousseau
_______________________________________________
Muscle mailing list
Muscle@...
http://lists.drizzle.com/mailman/listinfo/muscle

[Douglas E. Engert]

pcscdeamon.c sets up a signal handler for SIGUSR1 to call signal_reload.
But on Solaris (at least and it looks like HP too) the man pages say:

      If signal()is used,  disp  is  the address of a signal handler, and sig is
      not  SIGILL, SIGTRAP, or  SIGPWR, the system first sets  the
      signal's disposition to  SIG_DFL before executing the signal
      handler.

Thus the first use of pcscd -H works, but the second time causes the deamon
to not cache the signal and end.

This looks like this has been in previous versions as well.
The patch has the signal handler reenable the signal.
Use of sigaction  might be a better solution.


Ludovic Rousseau wrote:

> Hello,
>
> A new version of pcsc-lite 1.5.5 is available at [1].
> This version fixes bugs. No new feature added.
>
> Changelog:
> pcsc-lite-1.5.5: Ludovic Rousseau
> 28 July 2009
> - add the reader interface name if provided by the device
> - SCardTransmit(): return SCARD_E_UNSUPPORTED_FEATURE if
>   SCARD_PROTOCOL_RAW is requested by unsupported
> - SCardConnect() and SCardReconnect(): set dwActiveProtocol to
>   SCARD_PROTOCOL_UNDEFINED if SCARD_SHARE_DIRECT is used (conform to
>   MSDN). Contrary to Windows winscard behavior, the reader is accessed in
>   shared mode and not exclusive mode if SCARD_SHARE_DIRECT is used.
> - SCardControl(): correctly check for buffer overflow (bug introduced in
>   pcsc-lite 1.5.4)
> - some other minor improvements and bug corrections
>
> [1] https://alioth.debian.org/frs/?group_id=30105&release_id=1378
>

--

  Douglas E. Engert  <DEEngert@...>
  Argonne National Laboratory
  9700 South Cass Avenue
  Argonne, Illinois  60439
  [phone]

--- ./src/,pcscdaemon.c Sat Jul  4 03:10:31 2009
+++ ./src/pcscdaemon.c Mon Aug 31 16:18:18 2009
@@ -576,6 +576,8 @@
  return;
 
  HPReCheckSerialReaders();
+
+ (void)signal(SIGUSR1, signal_reload);
 } /* signal_reload */
 
 static void signal_trap(/*@unused@*/ int sig)

_______________________________________________
Muscle mailing list
Muscle@...
http://lists.drizzle.com/mailman/listinfo/muscle

[Ludovic Rousseau]

2009/8/31 Douglas E. Engert <deengert@...>:

> pcscdeamon.c sets up a signal handler for SIGUSR1 to call signal_reload.
> But on Solaris (at least and it looks like HP too) the man pages say:
>
>     If signal()is used,  disp  is  the address of a signal handler, and sig
> is
>     not  SIGILL, SIGTRAP, or  SIGPWR, the system first sets  the
>     signal's disposition to  SIG_DFL before executing the signal
>     handler.
>
> Thus the first use of pcscd -H works, but the second time causes the deamon
> to not cache the signal and end.
>
> This looks like this has been in previous versions as well.
> The patch has the signal handler reenable the signal.

Patch applied in revision 4375.
http://lists.alioth.debian.org/pipermail/pcsclite-cvs-commit/2009-September/003893.html

Thanks.

> Use of sigaction  might be a better solution.

I am no sure how to use sigaction(2) for this problem. So unless you
find a problem with signal(2) I will not change the code.

Regards,

--
 Dr. Ludovic Rousseau

_______________________________________________
Muscle mailing list
Muscle@...
http://lists.drizzle.com/mailman/listinfo/muscle

[Martin Paljak-2]

Hi,

2009/7/29 Ludovic Rousseau <ludovic.rousseau@...>:
> pcsc-lite-1.5.5: Ludovic Rousseau
> - add the reader interface name if provided by the device
I can't access my Linux computer currently to copy the exact line, but
when trying out the latest components on Linux a week ago, I remember
seeing something like "SCM SPR 532 (Vendor Interface) 0xDEADBEEF 00
00" or similar in the reader name with opensc-tool -l. Is this the
change? Why is it useful and/or what does it mean? From where the
string comes from?

For me it seemed like a long string that had no real meaning and which
was there in the middle of a more meaningful reader name. Maybe it
could be made shorter or ...


Martin
_______________________________________________
Muscle mailing list
Muscle@...
http://lists.drizzle.com/mailman/listinfo/muscle

[Ludovic Rousseau]

2009/9/1 Martin Paljak <martin@...>:

> 2009/7/29 Ludovic Rousseau <ludovic.rousseau@...>:
>> pcsc-lite-1.5.5: Ludovic Rousseau
>> - add the reader interface name if provided by the device
> I can't access my Linux computer currently to copy the exact line, but
> when trying out the latest components on Linux a week ago, I remember
> seeing something like "SCM SPR 532 (Vendor Interface) 0xDEADBEEF 00
> 00" or similar in the reader name with opensc-tool -l. Is this the
> change? Why is it useful and/or what does it mean? From where the
> string comes from?
>
> For me it seemed like a long string that had no real meaning and which
> was there in the middle of a more meaningful reader name. Maybe it
> could be made shorter or ...

I added the interface name for a new reader I worked on.
The reader has 2 CCID interfaces: one contact interface and one
contact less. The only way (I found) to differentiate both interfaces
was to add the interface name in the PC/SC reader name.

SCM has readers with an interface name and a serial number. So the
PC/SC name is long (and maybe disturbing).
I will try to add the interface name _only_ for devices with more than
one CCID interface. But thay may not be possible (in a clean way)

Thanks

--
 Dr. Ludovic Rousseau
_______________________________________________
Muscle mailing list
Muscle@...
http://lists.drizzle.com/mailman/listinfo/muscle