obsolete file in default publication?

View: New views
8 Messages — Rating Filter:   Alert me  

obsolete file in default publication?

by Jörn Nettingsmeier-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

hi *!


i'm busy re-syncing a lenya deployment to trunk. it contains a number of
publications based on a slimmed down "abstract" template pub i created,
which i'm now comparing file by file to the latest changes in the
default pub.

it seems that the whole subtree src/pub/default/lenya/content is
obsolete. the only file it contains is publishing/publish-screen.xsp,
and a quick grep seems to indicate that this file isn't referenced
anywhere in the source. due to my prolonged lenya absence i don't feel
qualified to remove the subtree from svn at this point - perhaps a more
active (and up-to-date) fellow committer could comment on this?

thanks,

jörn



--
Jörn Nettingsmeier

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: obsolete file in default publication?

by Jörn Nettingsmeier-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

here's another:
   src/pubs/default/lenya/usecases/tab/meta.jx
seems to be older and less sophisticated than
   src/modules-core/sitemanagement/usecases/tab/meta.jx
andreas, since you made the last commit to the latter file, can you comment?


--
Jörn Nettingsmeier

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: obsolete file in default publication?

by Jörn Nettingsmeier-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


src/pubs/default/lenya/usecases/workflow/ and
src/pubs/default/lenya/resources/schemas

are empty. any objections to removing them?



--
Jörn Nettingsmeier

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: obsolete file in default publication?

by Andreas Hartmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Jörn Nettingsmeier schrieb:
> src/pubs/default/lenya/usecases/workflow/ and
> src/pubs/default/lenya/resources/schemas
>
> are empty. any objections to removing them?

It should be fine to remove them.

-- Andreas


--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
Tel.: +41 (0) 43 818 57 01


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: obsolete file in default publication?

by Andreas Hartmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Jörn Nettingsmeier schrieb:

> hi *!
>
>
> i'm busy re-syncing a lenya deployment to trunk. it contains a number of
> publications based on a slimmed down "abstract" template pub i created,
> which i'm now comparing file by file to the latest changes in the
> default pub.
>
> it seems that the whole subtree src/pub/default/lenya/content is
> obsolete. the only file it contains is publishing/publish-screen.xsp,
> and a quick grep seems to indicate that this file isn't referenced
> anywhere in the source.

That file looks ancient, it even contains a reference to a task ID :)

> due to my prolonged lenya absence i don't feel
> qualified to remove the subtree from svn at this point - perhaps a more
> active (and up-to-date) fellow committer could comment on this?

I can't image that the file is still used.

Thanks for cleaning up!

-- Andreas

--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
Tel.: +41 (0) 43 818 57 01


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: obsolete file in default publication?

by Andreas Hartmann :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Jörn Nettingsmeier schrieb:
> here's another:
>    src/pubs/default/lenya/usecases/tab/meta.jx
> seems to be older and less sophisticated than
>    src/modules-core/sitemanagement/usecases/tab/meta.jx
> andreas, since you made the last commit to the latter file, can you comment?

Actually the JX template in the publication will never be loaded since
it is located in lenya/usecases instead of
lenya/modules/sitemanagement/usecases.

+1 to remove it.

-- Andreas


--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
Tel.: +41 (0) 43 818 57 01


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: obsolete file in default publication?

by Jörn Nettingsmeier-5 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Andreas Hartmann wrote:
> Jörn Nettingsmeier schrieb:
>> src/pubs/default/lenya/usecases/workflow/ and
>> src/pubs/default/lenya/resources/schemas
>>
>> are empty. any objections to removing them?
>
> It should be fine to remove them.

done.



--
Jörn Nettingsmeier

Meister für Veranstaltungstechnik

Audio and event engineer
Ambisonic surround recordings

http://stackingdwarves.net
+49 177 7937487


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...


Re: obsolete file in default publication?

by Jörn Nettingsmeier-3 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Andreas Hartmann wrote:

> Jörn Nettingsmeier schrieb:
>> hi *!
>>
>>
>> i'm busy re-syncing a lenya deployment to trunk. it contains a number of
>> publications based on a slimmed down "abstract" template pub i created,
>> which i'm now comparing file by file to the latest changes in the
>> default pub.
>>
>> it seems that the whole subtree src/pub/default/lenya/content is
>> obsolete. the only file it contains is publishing/publish-screen.xsp,
>> and a quick grep seems to indicate that this file isn't referenced
>> anywhere in the source.
>
> That file looks ancient, it even contains a reference to a task ID :)
> I can't image that the file is still used.

gone now.

--
Jörn Nettingsmeier

"One of my most productive days was throwing away 1000 lines of code."
  - Ken Thompson.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@...
For additional commands, e-mail: dev-help@...