org.freedesktop.Notifications GetServerInformation

[Leibowitz, Michael]

Hi,

I've noticed an inconsistency in the prototype for GetServerInformation
and what the spec reports.  The 0.9 version of the spec reports
introspection XML as follows:
    <method name="GetServerInformation">
      <arg type="s" name="return_name" direction="out"/>
      <arg type="s" name="return_vendor" direction="out"/>
      <arg type="s" name="return_version" direction="out"/>
    </method>

However, the 0.3.xx versions of notification daemon has introspection
XML as follows:
    <method name="GetServerInformation">
      <arg type="s" name="return_name" direction="out"/>
      <arg type="s" name="return_vendor" direction="out"/>
      <arg type="s" name="return_version" direction="out"/>
      <arg type="s" name="return_spec_version" direction="out"/>
    </method>

Additionally, 0.3.xx versions report the spec version as 0.9.  This is
not what is specified in the 0.9 specification, as seen above.

The 0.4.0 version reports the specification version as 1.0, which
doesn't appear at http://www.galago-project.org/specs/notification/

I have to say that changing the prototype of GetServerInformation seems
prone to problems.  If the client is adherent to the 0.9 or 0.7 version
of the spec, then they are broken out of the box or they have to parse
introspection information to figure which prototype of
GetServerInformation to call.  This is, surely, not the desired effect.

Perhaps somebody would like to make an amended 0.9 spec with the
de-facto prototype?  Would it be possible to release the 1.0 spec?  

Thanks





--
Michael Leibowitz <michael.leibowitz@...>


_______________________________________________
galago-devel mailing list
galago-devel@...
http://lists.freedesktop.org/mailman/listinfo/galago-devel

[A. Walton-2]

On Tue, Sep 1, 2009 at 8:45 PM, Michael
Leibowitz<michael.leibowitz@...> wrote:

> Hi,
>
> I've noticed an inconsistency in the prototype for GetServerInformation
> and what the spec reports.  The 0.9 version of the spec reports
> introspection XML as follows:
>    <method name="GetServerInformation">
>      <arg type="s" name="return_name" direction="out"/>
>      <arg type="s" name="return_vendor" direction="out"/>
>      <arg type="s" name="return_version" direction="out"/>
>    </method>
>
> However, the 0.3.xx versions of notification daemon has introspection
> XML as follows:
>    <method name="GetServerInformation">
>      <arg type="s" name="return_name" direction="out"/>
>      <arg type="s" name="return_vendor" direction="out"/>
>      <arg type="s" name="return_version" direction="out"/>
>      <arg type="s" name="return_spec_version" direction="out"/>
>    </method>

This is the correct version of the prototype. The above must be a typo
of some kind in that document. I don't know of any implementations
that support the former.

> Additionally, 0.3.xx versions report the spec version as 0.9.  This is
> not what is specified in the 0.9 specification, as seen above.
>
> The 0.4.0 version reports the specification version as 1.0, which
> doesn't appear at http://www.galago-project.org/specs/notification/
>
> I have to say that changing the prototype of GetServerInformation seems
> prone to problems.  If the client is adherent to the 0.9 or 0.7 version
> of the spec, then they are broken out of the box or they have to parse
> introspection information to figure which prototype of
> GetServerInformation to call.  This is, surely, not the desired effect.
>
> Perhaps somebody would like to make an amended 0.9 spec with the
> de-facto prototype?  Would it be possible to release the 1.0 spec?

There's a 0.10 version of the spec, which really needs to be moved to
FD.O but can't because the admins there are not willing to co-operate,
which contains the same 4-arg version as above.

-A. Walton

> Thanks
>
> --
> Michael Leibowitz <michael.leibowitz@...>
>
> _______________________________________________
> galago-devel mailing list
> galago-devel@...
> http://lists.freedesktop.org/mailman/listinfo/galago-devel
_______________________________________________
galago-devel mailing list
galago-devel@...
http://lists.freedesktop.org/mailman/listinfo/galago-devel

[A. Walton-2]

On Tue, Sep 1, 2009 at 9:01 PM, A. Walton<awalton@...> wrote:

> On Tue, Sep 1, 2009 at 8:45 PM, Michael
> Leibowitz<michael.leibowitz@...> wrote:
>> Hi,
>>
>> I've noticed an inconsistency in the prototype for GetServerInformation
>> and what the spec reports.  The 0.9 version of the spec reports
>> introspection XML as follows:
>>    <method name="GetServerInformation">
>>      <arg type="s" name="return_name" direction="out"/>
>>      <arg type="s" name="return_vendor" direction="out"/>
>>      <arg type="s" name="return_version" direction="out"/>
>>    </method>
>>
>> However, the 0.3.xx versions of notification daemon has introspection
>> XML as follows:
>>    <method name="GetServerInformation">
>>      <arg type="s" name="return_name" direction="out"/>
>>      <arg type="s" name="return_vendor" direction="out"/>
>>      <arg type="s" name="return_version" direction="out"/>
>>      <arg type="s" name="return_spec_version" direction="out"/>
>>    </method>
>
> This is the correct version of the prototype. The above must be a typo
> of some kind in that document. I don't know of any implementations
> that support the former.
>
>> Additionally, 0.3.xx versions report the spec version as 0.9.  This is
>> not what is specified in the 0.9 specification, as seen above.
>>
>> The 0.4.0 version reports the specification version as 1.0, which
>> doesn't appear at http://www.galago-project.org/specs/notification/
>>
>> I have to say that changing the prototype of GetServerInformation seems
>> prone to problems.  If the client is adherent to the 0.9 or 0.7 version
>> of the spec, then they are broken out of the box or they have to parse
>> introspection information to figure which prototype of
>> GetServerInformation to call.  This is, surely, not the desired effect.
>>
>> Perhaps somebody would like to make an amended 0.9 spec with the
>> de-facto prototype?  Would it be possible to release the 1.0 spec?
>
> There's a 0.10 version of the spec, which really needs to be moved to
> FD.O but can't because the admins there are not willing to co-operate,
> which contains the same 4-arg version as above.
>

Actually, looks like I was wrong on this, the newer version of the
spec carried forward this error. Will get that patched up ASAP. Thanks
for alerting us.

> -A. Walton
>
>> Thanks
>>
>> --
>> Michael Leibowitz <michael.leibowitz@...>
>>
>> _______________________________________________
>> galago-devel mailing list
>> galago-devel@...
>> http://lists.freedesktop.org/mailman/listinfo/galago-devel

_______________________________________________
galago-devel mailing list
galago-devel@...
http://lists.freedesktop.org/mailman/listinfo/galago-devel

[Leibowitz, Michael]

On Tue, 2009-09-01 at 18:01 -0700, A. Walton wrote:
[snip...snip]

> There's a 0.10 version of the spec, which really needs to be moved to
> FD.O but can't because the admins there are not willing to co-operate,
> which contains the same 4-arg version as above.

Since the 0.4.0 version of the notification daemon reports the spec
version as "1.0" (daemon.c:1395), I would hope that the spec version is
1.0 instead of 0.10

Cheers

--
Michael Leibowitz <michael.leibowitz@...>


_______________________________________________
galago-devel mailing list
galago-devel@...
http://lists.freedesktop.org/mailman/listinfo/galago-devel

[Leibowitz, Michael]

On Tue, 2009-09-01 at 18:01 -0700, A. Walton wrote:

> On Tue, Sep 1, 2009 at 8:45 PM, Michael
> Leibowitz<michael.leibowitz@...> wrote:
> > Hi,
> >
> > I've noticed an inconsistency in the prototype for GetServerInformation
> > and what the spec reports.  The 0.9 version of the spec reports
> > introspection XML as follows:
> >    <method name="GetServerInformation">
> >      <arg type="s" name="return_name" direction="out"/>
> >      <arg type="s" name="return_vendor" direction="out"/>
> >      <arg type="s" name="return_version" direction="out"/>
> >    </method>
> >
> > However, the 0.3.xx versions of notification daemon has introspection
> > XML as follows:
> >    <method name="GetServerInformation">
> >      <arg type="s" name="return_name" direction="out"/>
> >      <arg type="s" name="return_vendor" direction="out"/>
> >      <arg type="s" name="return_version" direction="out"/>
> >      <arg type="s" name="return_spec_version" direction="out"/>
> >    </method>
>
> This is the correct version of the prototype. The above must be a typo
> of some kind in that document. I don't know of any implementations
> that support the former.

The Moblin notification implementation uses the 3 arg prototype, just
like the spec says.  See:
http://git.moblin.org/cgit.cgi/mutter-moblin/tree/src/notification-manager.xml

Cheers

--
Michael Leibowitz <michael.leibowitz@...>


_______________________________________________
galago-devel mailing list
galago-devel@...
http://lists.freedesktop.org/mailman/listinfo/galago-devel