Author: murdos
Date: 2009-06-28 23:10:29 +0000 (Sun, 28 Jun 2009)
New Revision: 11787
Modified:
search_server/branches/lucene-java/servlet/src/main/java/org/musicbrainz/search/SearchServerServlet.java
Log:
Use constants for HTTP status codes, and change status code to BAD_REQUEST for invalid resource type
Modified: search_server/branches/lucene-java/servlet/src/main/java/org/musicbrainz/search/SearchServerServlet.java
===================================================================
--- search_server/branches/lucene-java/servlet/src/main/java/org/musicbrainz/search/SearchServerServlet.java 2009-06-28 21:18:24 UTC (rev 11786)
+++ search_server/branches/lucene-java/servlet/src/main/java/org/musicbrainz/search/SearchServerServlet.java 2009-06-28 23:10:29 UTC (rev 11787)
@@ -78,7 +78,7 @@
protected void doGet(HttpServletRequest request, HttpServletResponse response)
throws ServletException, IOException {
if (searchServer == null) {
- response.sendError(500, "searchServer == null");
+ response.sendError(HttpServletResponse.SC_INTERNAL_SERVER_ERROR, "searchServer == null");
return;
}
@@ -86,19 +86,19 @@
String query = request.getParameter("query");
if (query == null || query.isEmpty()) {
- response.sendError(400, "No query.");
+ response.sendError(HttpServletResponse.SC_BAD_REQUEST, "No query.");
return;
}
String type = request.getParameter("type");
if (query == null || query.isEmpty()) {
- response.sendError(400, "No type.");
+ response.sendError(HttpServletResponse.SC_BAD_REQUEST, "No type.");
return;
}
ResourceType resourceType = ResourceType.getValue(type);
if (resourceType == null) {
- response.sendError(500, "Unknown resource type");
+ response.sendError(HttpServletResponse.SC_BAD_REQUEST, "Unknown resource type");
return;
}
_______________________________________________
MusicBrainz-commits mailing list
MusicBrainz-commits@...
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-commits
