rebased opensuse 2.6.31 xen patches

[Andrew Lyon]

I have rebased the latest opensuse 2.6.31 xen dom0 patches so that
they apply to the vanilla kernel cleanly, you can get the patches and
a gentoo ebuild from
http://code.google.com/p/gentoo-xen-kernel/downloads/list , non gentoo
users simply apply them in numeric order.

Note that the ebuild also uses genpatches-2.6.31-4 to patch the kernel
to 2.6.31.4 so you should update to that revision before applying
them.

I believe opensuse will be using 2.6.31 as a release kernel so they
will be supporting it for some time, I will update the patches
whenever they release a new kernel source rpm.

This is NOT pv_ops, these are "classic" Xen patches.

Andy

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[bedge]

On Wed, Oct 14, 2009 at 8:36 AM, Andrew Lyon <andrew.lyon@...> wrote:

> I have rebased the latest opensuse 2.6.31 xen dom0 patches so that
> they apply to the vanilla kernel cleanly, you can get the patches and
> a gentoo ebuild from
> http://code.google.com/p/gentoo-xen-kernel/downloads/list , non gentoo
> users simply apply them in numeric order.
>
> Note that the ebuild also uses genpatches-2.6.31-4 to patch the kernel
> to 2.6.31.4 so you should update to that revision before applying
> them.
>
> I believe opensuse will be using 2.6.31 as a release kernel so they
> will be supporting it for some time, I will update the patches
> whenever they release a new kernel source rpm.
>
> This is NOT pv_ops, these are "classic" Xen patches.
>
> Andy
>

It might be .config dependent, but I needed this patch before it would build:

diff -Naur arch/x86/kernel/microcode_core-xen.c.orig
arch/x86/kernel/microcode_core-xen.c

--- arch/x86/kernel/microcode_core-xen.c.orig   2009-10-14
10:45:42.000000000 -0700
+++ arch/x86/kernel/microcode_core-xen.c        2009-10-14
10:44:30.000000000 -0700
@@ -34,7 +34,7 @@
 #include <linux/firmware.h>
 #include <linux/uaccess.h>
 #include <linux/vmalloc.h>
-
+#include <linux/swap.h>
 #include <asm/microcode.h>
 #include <asm/processor.h>

The error was:

make -l12 deb-pkg

make KBUILD_SRC=
  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  SYMLINK include/asm -> include/asm-x86
  CALL    scripts/checksyscalls.sh
  CHK     include/linux/compile.h
  CC [M]  arch/x86/kernel/microcode_core.o
arch/x86/kernel/microcode_core-xen.c: In function ‘microcode_write’:
arch/x86/kernel/microcode_core-xen.c:100: error: ‘totalram_pages’
undeclared (first use in this function)
arch/x86/kernel/microcode_core-xen.c:100: error: (Each undeclared
identifier is reported only once
arch/x86/kernel/microcode_core-xen.c:100: error: for each function it
appears in.)
make[4]: *** [arch/x86/kernel/microcode_core.o] Error 1
make[3]: *** [arch/x86/kernel] Error 2
make[2]: *** [arch/x86] Error 2
make[1]: *** [deb-pkg] Error 2
make: *** [deb-pkg] Error 2



-Bruce

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Andrew Lyon]

On Wed, Oct 14, 2009 at 7:15 PM, Bruce Edge <bruce.edge@...> wrote:

> On Wed, Oct 14, 2009 at 8:36 AM, Andrew Lyon <andrew.lyon@...> wrote:
>> I have rebased the latest opensuse 2.6.31 xen dom0 patches so that
>> they apply to the vanilla kernel cleanly, you can get the patches and
>> a gentoo ebuild from
>> http://code.google.com/p/gentoo-xen-kernel/downloads/list , non gentoo
>> users simply apply them in numeric order.
>>
>> Note that the ebuild also uses genpatches-2.6.31-4 to patch the kernel
>> to 2.6.31.4 so you should update to that revision before applying
>> them.
>>
>> I believe opensuse will be using 2.6.31 as a release kernel so they
>> will be supporting it for some time, I will update the patches
>> whenever they release a new kernel source rpm.
>>
>> This is NOT pv_ops, these are "classic" Xen patches.
>>
>> Andy
>>
>
> It might be .config dependent, but I needed this patch before it would build:
>
> diff -Naur arch/x86/kernel/microcode_core-xen.c.orig
> arch/x86/kernel/microcode_core-xen.c
>
> --- arch/x86/kernel/microcode_core-xen.c.orig   2009-10-14
> 10:45:42.000000000 -0700
> +++ arch/x86/kernel/microcode_core-xen.c        2009-10-14
> 10:44:30.000000000 -0700
> @@ -34,7 +34,7 @@
>  #include <linux/firmware.h>
>  #include <linux/uaccess.h>
>  #include <linux/vmalloc.h>
> -
> +#include <linux/swap.h>
>  #include <asm/microcode.h>
>  #include <asm/processor.h>
>
> The error was:
>
> make -l12 deb-pkg
>
> make KBUILD_SRC=
>  CHK     include/linux/version.h
>  CHK     include/linux/utsrelease.h
>  SYMLINK include/asm -> include/asm-x86
>  CALL    scripts/checksyscalls.sh
>  CHK     include/linux/compile.h
>  CC [M]  arch/x86/kernel/microcode_core.o
> arch/x86/kernel/microcode_core-xen.c: In function ‘microcode_write’:
> arch/x86/kernel/microcode_core-xen.c:100: error: ‘totalram_pages’
> undeclared (first use in this function)
> arch/x86/kernel/microcode_core-xen.c:100: error: (Each undeclared
> identifier is reported only once
> arch/x86/kernel/microcode_core-xen.c:100: error: for each function it
> appears in.)
> make[4]: *** [arch/x86/kernel/microcode_core.o] Error 1
> make[3]: *** [arch/x86/kernel] Error 2
> make[2]: *** [arch/x86] Error 2
> make[1]: *** [deb-pkg] Error 2
> make: *** [deb-pkg] Error 2
>
>
>
> -Bruce
>

Thanks Bruce, I've CC'ed Jan in case he wants to merge this fix into his tree.

Andy

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Jan Beulich]

>>> Andrew Lyon <andrew.lyon@...> 15.10.09 10:22 >>>
>Thanks Bruce, I've CC'ed Jan in case he wants to merge this fix into his tree.

No, I won't - this is due to you dropping all our other patches (in the given
case, the reason why this works for us is patches.fixes/use-totalram_pages.

If you drop all our non-Xen patches, you generally will want to also drop
all of patches.xen/xen3-* except for the ones stating "Automatically
created from "patches.kernel.org/*" by xen-port-patches.py", otherwise
you will always have the risk of those depending on something the
respective native patch introduced.

Jan


_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Andrew Lyon]

On Thu, Oct 15, 2009 at 9:32 AM, Jan Beulich <JBeulich@...> wrote:

>>>> Andrew Lyon <andrew.lyon@...> 15.10.09 10:22 >>>
>>Thanks Bruce, I've CC'ed Jan in case he wants to merge this fix into his tree.
>
> No, I won't - this is due to you dropping all our other patches (in the given
> case, the reason why this works for us is patches.fixes/use-totalram_pages.
>
> If you drop all our non-Xen patches, you generally will want to also drop
> all of patches.xen/xen3-* except for the ones stating "Automatically
> created from "patches.kernel.org/*" by xen-port-patches.py", otherwise
> you will always have the risk of those depending on something the
> respective native patch introduced.
>
> Jan
>
>

Sorry Jan, I have a script that filters the xen patches exactly as you
describe but I had made a small mistake which allowed
xen3-use-totalram_pages.patch to slip through.

Will be more careful in future.

Andy

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[bedge]

On Thu, Oct 15, 2009 at 2:56 AM, Andrew Lyon <andrew.lyon@...> wrote:

> On Thu, Oct 15, 2009 at 9:32 AM, Jan Beulich <JBeulich@...> wrote:
>>>>> Andrew Lyon <andrew.lyon@...> 15.10.09 10:22 >>>
>>>Thanks Bruce, I've CC'ed Jan in case he wants to merge this fix into his tree.
>>
>> No, I won't - this is due to you dropping all our other patches (in the given
>> case, the reason why this works for us is patches.fixes/use-totalram_pages.
>>
>> If you drop all our non-Xen patches, you generally will want to also drop
>> all of patches.xen/xen3-* except for the ones stating "Automatically
>> created from "patches.kernel.org/*" by xen-port-patches.py", otherwise
>> you will always have the risk of those depending on something the
>> respective native patch introduced.
>>
>> Jan
>>
>>
>
> Sorry Jan, I have a script that filters the xen patches exactly as you
> describe but I had made a small mistake which allowed
> xen3-use-totalram_pages.patch to slip through.
>
> Will be more careful in future.
>
> Andy
>

Andy,

Apologies, I'm not up on OpenSuse kernel patch mechanisms.

Any chance you could post your filter script so we can see what
patches should actually be applied?
Or just a list or what needs to skipped.

What's the purpose of including these additional patches?

Thanks

-Bruce

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Andrew Lyon]

On Thu, Oct 15, 2009 at 11:01 PM, Bruce Edge <bruce.edge@...> wrote:

> On Thu, Oct 15, 2009 at 2:56 AM, Andrew Lyon <andrew.lyon@...> wrote:
>> On Thu, Oct 15, 2009 at 9:32 AM, Jan Beulich <JBeulich@...> wrote:
>>>>>> Andrew Lyon <andrew.lyon@...> 15.10.09 10:22 >>>
>>>>Thanks Bruce, I've CC'ed Jan in case he wants to merge this fix into his tree.
>>>
>>> No, I won't - this is due to you dropping all our other patches (in the given
>>> case, the reason why this works for us is patches.fixes/use-totalram_pages.
>>>
>>> If you drop all our non-Xen patches, you generally will want to also drop
>>> all of patches.xen/xen3-* except for the ones stating "Automatically
>>> created from "patches.kernel.org/*" by xen-port-patches.py", otherwise
>>> you will always have the risk of those depending on something the
>>> respective native patch introduced.
>>>
>>> Jan
>>>
>>>
>>
>> Sorry Jan, I have a script that filters the xen patches exactly as you
>> describe but I had made a small mistake which allowed
>> xen3-use-totalram_pages.patch to slip through.
>>
>> Will be more careful in future.
>>
>> Andy
>>
>
> Andy,
>
> Apologies, I'm not up on OpenSuse kernel patch mechanisms.
>
> Any chance you could post your filter script so we can see what
> patches should actually be applied?
> Or just a list or what needs to skipped.
>

Its very simple, many of the patches that are named xen3* e.g.
xen3-x86_64-unwind-annotations have a comment in them that explains
they were created by a script:

xen3-x86_64-unwind-annotations:Automatically created from
"patches.arch/x86_64-unwind-annotations" by xen-port-patches.py

So unless I include the corresponding patches.arch patch as well we
need to exclude this patch.

Those that are created from a kernel.org patch are ok, for example:

xen3-patch-2.6.18:Automatically created from
"patches.kernel.org/patch-2.6.18" by xen-port-patches.py

I also exclude some other patches that are OpenSuse specific or for
experimental features that most users do not need:

patches.xen/tmem
patches.xen/xen-modular-blktap
patches.xen/xen-blkback-bimodal-suse
patches.xen/xen-blkif-protocol-fallback-hack
patches.xen/xen-swiotlb-heuristics

So far 2.6.31 seems to be extremely stable and performs very well on
my test system, all credit must go to Jan Beulich as he does all the
hard work forward porting the patches, the changes required to make
them apply to vanilla kernel.org are extremely minor and the total
diff is under 6k.

Andy

> What's the purpose of including these additional patches?
>
> Thanks
>
> -Bruce
>
> _______________________________________________
> Xen-users mailing list
> Xen-users@...
> http://lists.xensource.com/xen-users
>

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Stefan Kuhne]

Andrew Lyon schrieb:
Hi,

> I have rebased the latest opensuse 2.6.31 xen dom0 patches so that
> they apply to the vanilla kernel cleanly, you can get the patches and
> a gentoo ebuild from
> http://code.google.com/p/gentoo-xen-kernel/downloads/list , non gentoo
> users simply apply them in numeric order.
>
i've Problems with booting this Kernel.
So i try a clean .config and only enable Dom0 support.
Then i get:
LD      vmlinux.o
  MODPOST vmlinux.o
WARNING: vmlinux.o (__xen_guest): unexpected non-allocatable section.
Did you forget to use "ax"/"aw" in a .S file?
Note that for example <linux/init.h> contains
section definitions for use in .S files.

WARNING: modpost: Found 2 section mismatch(es).
To see full details build your kernel with:
'make CONFIG_DEBUG_SECTION_MISMATCH=y'
  GEN     .version
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
ld: kernel image bigger than KERNEL_IMAGE_SIZE
ld: kernel image bigger than KERNEL_IMAGE_SIZE
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [sub-make] Error 2

I've got this error with many Xen Kernels.

Regards,
Stefan Kuhne





_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Andrew Lyon]

On Tue, Oct 20, 2009 at 9:23 AM, Stefan Kuhne <stefan.kuhne@...> wrote:

> Andrew Lyon schrieb:
> Hi,
>
>> I have rebased the latest opensuse 2.6.31 xen dom0 patches so that
>> they apply to the vanilla kernel cleanly, you can get the patches and
>> a gentoo ebuild from
>> http://code.google.com/p/gentoo-xen-kernel/downloads/list , non gentoo
>> users simply apply them in numeric order.
>>
> i've Problems with booting this Kernel.
> So i try a clean .config and only enable Dom0 support.
> Then i get:
> LD      vmlinux.o
>  MODPOST vmlinux.o
> WARNING: vmlinux.o (__xen_guest): unexpected non-allocatable section.
> Did you forget to use "ax"/"aw" in a .S file?
> Note that for example <linux/init.h> contains
> section definitions for use in .S files.
>
> WARNING: modpost: Found 2 section mismatch(es).
> To see full details build your kernel with:
> 'make CONFIG_DEBUG_SECTION_MISMATCH=y'
>  GEN     .version
>  CHK     include/linux/compile.h
>  UPD     include/linux/compile.h
>  CC      init/version.o
>  LD      init/built-in.o
>  LD      .tmp_vmlinux1
> ld: kernel image bigger than KERNEL_IMAGE_SIZE
> ld: kernel image bigger than KERNEL_IMAGE_SIZE
> make[1]: *** [.tmp_vmlinux1] Error 1
> make: *** [sub-make] Error 2
>
> I've got this error with many Xen Kernels.
>
> Regards,
> Stefan Kuhne
>
>

I just successfully compiled a 32 bit dom0 kernel, did you use "make
vmlinuz" Also can you post the output of grep "CONFIG_KERNEL_GZIP"
.config , I wonder if you have ended up with no compression enabled
for the kernel image.

In fact, send me your full .config and I will try to figure out what is wrong.

Andy

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Andrew Lyon]

On Wed, Oct 21, 2009 at 6:49 PM, Stefan Kuhne <stefan.kuhne@...> wrote:

> Andrew Lyon schrieb:
>
>> I just successfully compiled a 32 bit dom0 kernel, did you use "make
>> vmlinuz" Also can you post the output of grep "CONFIG_KERNEL_GZIP"
>> .config , I wonder if you have ended up with no compression enabled
>> for the kernel image.
>>
> I've try make vmlinuz -> same.
> CONFIG_KERNEL_GZIP=y
>
>> In fact, send me your full .config and I will try to figure out what is wrong.
>>
> http://skweb.buetow.org/Linux/2.6.31.4-xen.config
>
> I only want a simply Kernel to try where is the "Bug".
> With full configured and compiling Kernel i get a trace every time.
>
> Thanks,
> Stefan Kuhne
>
>

Did you do a "make clean" before "make vmlinuz" ? I tried to compile
using your config and got the same error but after running make clean
it compiled ok.

Andy

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Stefan Kuhne]

Andrew Lyon schrieb:

> Did you do a "make clean" before "make vmlinuz" ? I tried to compile
> using your config and got the same error but after running make clean
> it compiled ok.
>
So,
i've try it.
I've got the same.
My make options:
-C /root/kernel/kernel-2.6.31.4-xen/linux-2.6.31.4-xen
O=/root/kernel/kernel-2.6.31.4-xen/build-2.6.31.4-xen
INSTALL_MOD_PATH=/root/kernel/kernel-2.6.31.4-xen/package
INSTALL_PATH=/root/kernel/kernel-2.6.31.4-xen/package/boot
DEPMOD=/root/kernel/kernel-2.6.31.4-xen/../common/sbin/depmod
EXTRAVERSION=.4-xen

Regards,
Stefan Kuhne



_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Marco Nenciarini]

On Wed, Oct 14, 2009 at 04:36:02PM +0100, Andrew Lyon wrote:
> I have rebased the latest opensuse 2.6.31 xen dom0 patches so that
> they apply to the vanilla kernel cleanly, you can get the patches and
> a gentoo ebuild from
> http://code.google.com/p/gentoo-xen-kernel/downloads/list , non gentoo
> users simply apply them in numeric order.
>

I've found a typo (a missing backslash) in your latest patchset
(2.6.31-5)

Patch attached

Marco

--
--
---------------------------------------------------------------------
|    Marco Nenciarini    | Debian/GNU Linux Developer - Plug Member |
| mnencia@... | http://www.prato.linux.it/~mnencia       |
---------------------------------------------------------------------
Key fingerprint = FED9 69C7 9E67 21F5 7D95  5270 6864 730D F095 E5E4

---

--- a/60031_xen3-patch-2.6.25.patch1 2009-10-16 10:57:31.000000000 +0200
+++ b/60031_xen3-patch-2.6.25.patch1 2009-10-22 18:51:39.000000000 +0200
@@ -26944,7 +26944,7 @@
 + asm(LOCK_PREFIX "xaddl %0, %2\n\t" \
 +    "shldl $16, %0, %3\n\t" \
 +    "cmpw %w3, %w0\n\t" \
-+    "sete %1"
++    "sete %1" \
 +    : "=&r" (token), "=qm" (free), "+m" (lock->slock), \
 +      "=&g" (tmp) \
 +    : "0" (0x00010000) \

---

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Andrew Lyon]

On Fri, Oct 23, 2009 at 11:27 AM, Marco Nenciarini
<mnencia@...> wrote:

> On Wed, Oct 14, 2009 at 04:36:02PM +0100, Andrew Lyon wrote:
>> I have rebased the latest opensuse 2.6.31 xen dom0 patches so that
>> they apply to the vanilla kernel cleanly, you can get the patches and
>> a gentoo ebuild from
>> http://code.google.com/p/gentoo-xen-kernel/downloads/list , non gentoo
>> users simply apply them in numeric order.
>>
>
> I've found a typo (a missing backslash) in your latest patchset
> (2.6.31-5)
>
> Patch attached
>
> Marco
>
> --
> --
> ---------------------------------------------------------------------
> |    Marco Nenciarini    | Debian/GNU Linux Developer - Plug Member |
> | mnencia@... | http://www.prato.linux.it/~mnencia       |
> ---------------------------------------------------------------------
> Key fingerprint = FED9 69C7 9E67 21F5 7D95  5270 6864 730D F095 E5E4
>
>

Thanks, does this fix a problem you have encountered? If so I would
like to see an example of the oops or warning you receive due to this
error.

Andy

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Marco Nenciarini]

Andrew Lyon ha scritto:
> On Fri, Oct 23, 2009 at 11:27 AM, Marco Nenciarini
>
> Thanks, does this fix a problem you have encountered? If so I would
> like to see an example of the oops or warning you receive due to this
> error.
>
> Andy

Without that patch it does not compile at all.


scripts/kconfig/conf -s arch/x86/Kconfig
   Using
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen
as source for kernel
   GEN
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/Makefile
   CHK     include/linux/version.h
   UPD     include/linux/version.h
   CHK     include/linux/utsrelease.h
   UPD     include/linux/utsrelease.h
   SYMLINK include/asm -> include/asm-x86
   Updating
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/scripts/Makefile.xen
   CC      kernel/bounds.s
   GEN     include/linux/bounds.h
   CC      arch/x86/kernel/asm-offsets.s
In file included from
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/spinlock.h:88,
                  from
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/seqlock.h:29,
                  from
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/time.h:8,
                  from
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/stat.h:60,
                  from
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/module.h:10,
                  from
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/crypto.h:21,
                  from
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets_64.c:7,
                  from
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:4:
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:134:
error: expected identifier or ‘(’ before ‘:’ token
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
error: expected identifier or ‘(’ before ‘}’ token
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
error: expected identifier or ‘(’ before ‘while’
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:
In function ‘__ticket_spin_lock’:
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
error: expected ‘:’ or ‘)’ before ‘;’ token
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
warning: unused variable ‘tmp’
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:227:
error: expected ‘while’ before ‘static’
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:5:
error: expected declaration or statement at end of input
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:215:
warning: unused variable ‘free’
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
warning: unused variable ‘count’
/home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
warning: unused variable ‘token’
make[5]: *** [arch/x86/kernel/asm-offsets.s] Error 1
make[4]: *** [prepare0] Error 2

Marco

--
---------------------------------------------------------------------
|    Marco Nenciarini    | Debian/GNU Linux Developer - Plug Member |
| mnencia@... | http://www.prato.linux.it/~mnencia       |
---------------------------------------------------------------------
Key fingerprint = FED9 69C7 9E67 21F5 7D95  5270 6864 730D F095 E5E4


_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Andrew Lyon]

On Fri, Oct 23, 2009 at 12:03 PM, Marco Nenciarini
<mnencia@...> wrote:

> Andrew Lyon ha scritto:
>>
>> On Fri, Oct 23, 2009 at 11:27 AM, Marco Nenciarini
>>
>> Thanks, does this fix a problem you have encountered? If so I would
>> like to see an example of the oops or warning you receive due to this
>> error.
>>
>> Andy
>
> Without that patch it does not compile at all.
>
>
> scripts/kconfig/conf -s arch/x86/Kconfig
>  Using
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen
> as source for kernel
>  GEN
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/Makefile
>  CHK     include/linux/version.h
>  UPD     include/linux/version.h
>  CHK     include/linux/utsrelease.h
>  UPD     include/linux/utsrelease.h
>  SYMLINK include/asm -> include/asm-x86
>  Updating
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/scripts/Makefile.xen
>  CC      kernel/bounds.s
>  GEN     include/linux/bounds.h
>  CC      arch/x86/kernel/asm-offsets.s
> In file included from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/spinlock.h:88,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/seqlock.h:29,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/time.h:8,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/stat.h:60,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/module.h:10,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/crypto.h:21,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets_64.c:7,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:4:
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:134:
> error: expected identifier or ‘(’ before ‘:’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
> error: expected identifier or ‘(’ before ‘}’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
> error: expected identifier or ‘(’ before ‘while’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:
> In function ‘__ticket_spin_lock’:
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
> error: expected ‘:’ or ‘)’ before ‘;’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
> warning: unused variable ‘tmp’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:227:
> error: expected ‘while’ before ‘static’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:5:
> error: expected declaration or statement at end of input
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:215:
> warning: unused variable ‘free’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
> warning: unused variable ‘count’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
> warning: unused variable ‘token’
> make[5]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> make[4]: *** [prepare0] Error 2
>
> Marco
>
> --
> ---------------------------------------------------------------------
> |    Marco Nenciarini    | Debian/GNU Linux Developer - Plug Member |
> | mnencia@... | http://www.prato.linux.it/~mnencia       |
> ---------------------------------------------------------------------
> Key fingerprint = FED9 69C7 9E67 21F5 7D95  5270 6864 730D F095 E5E4
>
>

Weird, I can compile both 32 and 64 bit domU and dom0 without any
errors like that, looking at the code I'd expect to hit that error
straight away.

I've CC'ed Jan and attached your patch to this message, he may want to
merge this upstream (or point out that I'm wrong again).

Andy


_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Andrew Lyon]

On Thu, Oct 22, 2009 at 4:57 PM, Stefan Kuhne <stefan.kuhne@...> wrote:

> Andrew Lyon schrieb:
>
>> Did you do a "make clean" before "make vmlinuz" ? I tried to compile
>> using your config and got the same error but after running make clean
>> it compiled ok.
>>
> So,
> i've try it.
> I've got the same.
> My make options:
> -C /root/kernel/kernel-2.6.31.4-xen/linux-2.6.31.4-xen
> O=/root/kernel/kernel-2.6.31.4-xen/build-2.6.31.4-xen
> INSTALL_MOD_PATH=/root/kernel/kernel-2.6.31.4-xen/package
> INSTALL_PATH=/root/kernel/kernel-2.6.31.4-xen/package/boot
> DEPMOD=/root/kernel/kernel-2.6.31.4-xen/../common/sbin/depmod
> EXTRAVERSION=.4-xen
>
> Regards,
> Stefan Kuhne
>
>
> _______________________________________________
> Xen-users mailing list
> Xen-users@...
> http://lists.xensource.com/xen-users
>

Sorry for the confusion, I'm not sure what happened yesterday but
something was wrong in my test process and your config appeared to
compile without error, I've now tested again and have reproduced the
error that you got.

I do not fully understand the cause of the problem yet but if you set
the "Xen version compatibility" to 3.0.4 or greater you should find
that it compiles properly.

Here is a diff between your broken config and a working one with that
setting changed:

-CONFIG_XEN_COMPAT_030002_AND_LATER=y
-# CONFIG_XEN_COMPAT_030004_AND_LATER is not set
+# CONFIG_XEN_COMPAT_030002_AND_LATER is not set
+CONFIG_XEN_COMPAT_030004_AND_LATER=y
 # CONFIG_XEN_COMPAT_030100_AND_LATER is not set
 # CONFIG_XEN_COMPAT_030200_AND_LATER is not set
 # CONFIG_XEN_COMPAT_030300_AND_LATER is not set
 # CONFIG_XEN_COMPAT_LATEST_ONLY is not set
-CONFIG_XEN_COMPAT=0x030002
+CONFIG_XEN_COMPAT=0x030004

Perhaps OpenSuse only support 3.0.4 or later... I will look into it.

Andy

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Andrew Lyon]

On Fri, Oct 23, 2009 at 12:28 PM, Andrew Lyon <andrew.lyon@...> wrote:

> On Fri, Oct 23, 2009 at 12:03 PM, Marco Nenciarini
> <mnencia@...> wrote:
>> Andrew Lyon ha scritto:
>>>
>>> On Fri, Oct 23, 2009 at 11:27 AM, Marco Nenciarini
>>>
>>> Thanks, does this fix a problem you have encountered? If so I would
>>> like to see an example of the oops or warning you receive due to this
>>> error.
>>>
>>> Andy
>>
>> Without that patch it does not compile at all.
>>
>>
>> scripts/kconfig/conf -s arch/x86/Kconfig
>>  Using
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen
>> as source for kernel
>>  GEN
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/Makefile
>>  CHK     include/linux/version.h
>>  UPD     include/linux/version.h
>>  CHK     include/linux/utsrelease.h
>>  UPD     include/linux/utsrelease.h
>>  SYMLINK include/asm -> include/asm-x86
>>  Updating
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/scripts/Makefile.xen
>>  CC      kernel/bounds.s
>>  GEN     include/linux/bounds.h
>>  CC      arch/x86/kernel/asm-offsets.s
>> In file included from
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/spinlock.h:88,
>>                 from
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/seqlock.h:29,
>>                 from
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/time.h:8,
>>                 from
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/stat.h:60,
>>                 from
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/module.h:10,
>>                 from
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/crypto.h:21,
>>                 from
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets_64.c:7,
>>                 from
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:4:
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:134:
>> error: expected identifier or ‘(’ before ‘:’ token
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
>> error: expected identifier or ‘(’ before ‘}’ token
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
>> error: expected identifier or ‘(’ before ‘while’
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:
>> In function ‘__ticket_spin_lock’:
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
>> error: expected ‘:’ or ‘)’ before ‘;’ token
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
>> warning: unused variable ‘tmp’
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:227:
>> error: expected ‘while’ before ‘static’
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:5:
>> error: expected declaration or statement at end of input
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:215:
>> warning: unused variable ‘free’
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
>> warning: unused variable ‘count’
>> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
>> warning: unused variable ‘token’
>> make[5]: *** [arch/x86/kernel/asm-offsets.s] Error 1
>> make[4]: *** [prepare0] Error 2
>>
>> Marco
>>
>> --
>> ---------------------------------------------------------------------
>> |    Marco Nenciarini    | Debian/GNU Linux Developer - Plug Member |
>> | mnencia@... | http://www.prato.linux.it/~mnencia       |
>> ---------------------------------------------------------------------
>> Key fingerprint = FED9 69C7 9E67 21F5 7D95  5270 6864 730D F095 E5E4
>>
>>
>
> Weird, I can compile both 32 and 64 bit domU and dom0 without any
> errors like that, looking at the code I'd expect to hit that error
> straight away.

Ah ha, you have NR_CPUS set to greater than 256, yes?

>
> I've CC'ed Jan and attached your patch to this message, he may want to
> merge this upstream (or point out that I'm wrong again).

Jan: I've checked the opensuse patches that I exclude and none of them
would fix this error, so it does appear that you should merge this fix
otherwise compile will fail with NR_CPUS > 256

>
> Andy
>

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[dbaxps]

> Weird, I can compile both 32 and 64 bit domU and dom0 without any
> errors like that, looking at the code I'd expect to hit that error
>straight away.

Applied V5 get same error building xenified 2.6.31.4
Spinlock-fix.patch allows compilation to start.


Boris.

--- On Fri, 10/23/09, Andrew Lyon <andrew.lyon@...> wrote:

From: Andrew Lyon <andrew.lyon@...>
Subject: Re: [Xen-users] rebased opensuse 2.6.31 xen patches
To: "Marco Nenciarini" <mnencia@...>, "Jan Beulich" <jbeulich@...>, "xen-users List" <xen-users@...>
Date: Friday, October 23, 2009, 7:28 AM

On Fri, Oct 23, 2009 at 12:03 PM, Marco Nenciarini
<mnencia@...> wrote:

> Andrew Lyon ha scritto:
>>
>> On Fri, Oct 23, 2009 at 11:27 AM, Marco Nenciarini
>>
>> Thanks, does this fix a problem you have encountered? If so I would
>> like to see an example of the oops or warning you receive due to this
>> error.
>>
>> Andy
>
> Without that patch it does not compile at all.
>
>
> scripts/kconfig/conf -s arch/x86/Kconfig
>  Using
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen
> as source for kernel
>  GEN
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/Makefile
>  CHK     include/linux/version.h
>  UPD     include/linux/version.h
>  CHK     include/linux/utsrelease.h
>  UPD     include/linux/utsrelease.h
>  SYMLINK include/asm -> include/asm-x86
>  Updating
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/scripts/Makefile.xen
>  CC      kernel/bounds.s
>  GEN     include/linux/bounds.h
>  CC      arch/x86/kernel/asm-offsets.s
> In file included from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/spinlock.h:88,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/seqlock.h:29,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/time.h:8,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/stat.h:60,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/module.h:10,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/crypto.h:21,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets_64.c:7,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:4:
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:134:
> error: expected identifier or ‘(’ before ‘:’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
> error: expected identifier or ‘(’ before ‘}’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
> error: expected identifier or ‘(’ before ‘while’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:
> In function ‘__ticket_spin_lock’:
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
> error: expected ‘:’ or ‘)’ before ‘;’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
> warning: unused variable ‘tmp’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:227:
> error: expected ‘while’ before ‘static’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:5:
> error: expected declaration or statement at end of input
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:215:
> warning: unused variable ‘free’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
> warning: unused variable ‘count’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
> warning: unused variable ‘token’
> make[5]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> make[4]: *** [prepare0] Error 2
>
> Marco
>
> --
> ---------------------------------------------------------------------
> |    Marco Nenciarini    | Debian/GNU Linux Developer - Plug Member |
> | mnencia@... | http://www.prato.linux.it/~mnencia       |
> ---------------------------------------------------------------------
> Key fingerprint = FED9 69C7 9E67 21F5 7D95  5270 6864 730D F095 E5E4
>
>

Weird, I can compile both 32 and 64 bit domU and dom0 without any
errors like that, looking at the code I'd expect to hit that error
straight away.

I've CC'ed Jan and attached your patch to this message, he may want to
merge this upstream (or point out that I'm wrong again).

Andy

-----Inline Attachment Follows-----

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[dbaxps]

Dmesg log attached

=============================================
[ INFO: possible recursive locking detected ]
2.6.31.4 #1
---------------------------------------------
init/1 is trying to acquire lock:
 (__pte_lockptr(page)){+.+...}, at: [<ffffffff81025090>] _pin_lock+0xb0/0x124

but task is already holding lock:
 (__pte_lockptr(page)){+.+...}, at: [<ffffffff81025090>] _pin_lock+0xb0/0x124

other info that might help us debug this:
4 locks held by init/1:
 #0:  (&mm->mmap_sem){++++++}, at: [<ffffffff8104193f>] dup_mm+0xc7/0x3a2
 #1:  (&mm->mmap_sem/1){+.+.+.}, at: [<ffffffff81041954>] dup_mm+0xdc/0x3a2
 #2:  (&mm->page_table_lock){+.+...}, at: [<ffffffff8102501b>] _pin_lock+0x3b/0x124
 #3:  (__pte_lockptr(page)){+.+...}, at: [<ffffffff81025090>] _pin_lock+0xb0/0x124

stack backtrace:
Pid: 1, comm: init Not tainted 2.6.31.4 #1
Call Trace:
 [<ffffffff81072a6d>] __lock_acquire+0xb70/0xbfa
 [<ffffffff81072beb>] lock_acquire+0xf4/0x152
 [<ffffffff81025090>] ? _pin_lock+0xb0/0x124
 [<ffffffff81025090>] ? _pin_lock+0xb0/0x124
 [<ffffffff814bc8bb>] _spin_lock+0x45/0x8e
 [<ffffffff81025090>] ? _pin_lock+0xb0/0x124
 [<ffffffff81025090>] _pin_lock+0xb0/0x124
 [<ffffffff81025928>] mm_pin+0x33/0x61
 [<ffffffff810259a3>] arch_dup_mmap+0x4d/0x6a
 [<ffffffff81041b5d>] dup_mm+0x2e5/0x3a2
 [<ffffffff81042823>] copy_process+0xba2/0x13c5
 [<ffffffff810431b9>] do_fork+0x173/0x335
 [<ffffffff8110b3a9>] ? do_vfs_ioctl+0x4aa/0x506
 [<ffffffff8100a353>] ? sysret_check+0x41/0xc0
 [<ffffffff81008358>] sys_clone+0x3b/0x51
 [<ffffffff814bbebb>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff8100a7b3>] stub_clone+0x13/0x20
 [<ffffffff8100a308>] ? system_call_fastpath+0x16/0x1b

Boris

--- On Fri, 10/23/09, Andrew Lyon <andrew.lyon@...> wrote:

From: Andrew Lyon <andrew.lyon@...>
Subject: Re: [Xen-users] rebased opensuse 2.6.31 xen patches
To: "Marco Nenciarini" <mnencia@...>, "Jan Beulich" <jbeulich@...>, "xen-users List" <xen-users@...>
Date: Friday, October 23, 2009, 7:28 AM

On Fri, Oct 23, 2009 at 12:03 PM, Marco Nenciarini
<mnencia@...> wrote:

> Andrew Lyon ha scritto:
>>
>> On Fri, Oct 23, 2009 at 11:27 AM, Marco Nenciarini
>>
>> Thanks, does this fix a problem you have encountered? If so I would
>> like to see an example of the oops or warning you receive due to this
>> error.
>>
>> Andy
>
> Without that patch it does not compile at all.
>
>
> scripts/kconfig/conf -s arch/x86/Kconfig
>  Using
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen
> as source for kernel
>  GEN
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/Makefile
>  CHK     include/linux/version.h
>  UPD     include/linux/version.h
>  CHK     include/linux/utsrelease.h
>  UPD     include/linux/utsrelease.h
>  SYMLINK include/asm -> include/asm-x86
>  Updating
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/scripts/Makefile.xen
>  CC      kernel/bounds.s
>  GEN     include/linux/bounds.h
>  CC      arch/x86/kernel/asm-offsets.s
> In file included from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/spinlock.h:88,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/seqlock.h:29,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/time.h:8,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/stat.h:60,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/module.h:10,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/crypto.h:21,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets_64.c:7,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:4:
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:134:
> error: expected identifier or ‘(’ before ‘:’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
> error: expected identifier or ‘(’ before ‘}’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
> error: expected identifier or ‘(’ before ‘while’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:
> In function ‘__ticket_spin_lock’:
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
> error: expected ‘:’ or ‘)’ before ‘;’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
> warning: unused variable ‘tmp’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:227:
> error: expected ‘while’ before ‘static’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:5:
> error: expected declaration or statement at end of input
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:215:
> warning: unused variable ‘free’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
> warning: unused variable ‘count’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
> warning: unused variable ‘token’
> make[5]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> make[4]: *** [prepare0] Error 2
>
> Marco
>
> --
> ---------------------------------------------------------------------
> |    Marco Nenciarini    | Debian/GNU Linux Developer - Plug Member |
> | mnencia@... | http://www.prato.linux.it/~mnencia       |
> ---------------------------------------------------------------------
> Key fingerprint = FED9 69C7 9E67 21F5 7D95  5270 6864 730D F095 E5E4
>
>

Weird, I can compile both 32 and 64 bit domU and dom0 without any
errors like that, looking at the code I'd expect to hit that error
straight away.

I've CC'ed Jan and attached your patch to this message, he may want to
merge this upstream (or point out that I'm wrong again).

Andy

-----Inline Attachment Follows-----

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

[Andrew Lyon]

On Fri, Oct 23, 2009 at 5:05 PM, Boris Derzhavets <bderzhavets@...> wrote:

Dmesg log attached

=============================================
[ INFO: possible recursive locking detected ]
2.6.31.4 #1
---------------------------------------------
init/1 is trying to acquire lock:
 (__pte_lockptr(page)){+.+...}, at: [<ffffffff81025090>] _pin_lock+0xb0/0x124

but task is already holding lock:
 (__pte_lockptr(page)){+.+...}, at: [<ffffffff81025090>] _pin_lock+0xb0/0x124

other info that might help us debug this:
4 locks held by init/1:
 #0:  (&mm->mmap_sem){++++++}, at: [<ffffffff8104193f>] dup_mm+0xc7/0x3a2
 #1:  (&mm->mmap_sem/1){+.+.+.}, at: [<ffffffff81041954>] dup_mm+0xdc/0x3a2
 #2:  (&mm->page_table_lock){+.+...}, at: [<ffffffff8102501b>] _pin_lock+0x3b/0x124
 #3:  (__pte_lockptr(page)){+.+...}, at: [<ffffffff81025090>] _pin_lock+0xb0/0x124

stack backtrace:
Pid: 1, comm: init Not tainted 2.6.31.4 #1
Call Trace:
 [<ffffffff81072a6d>] __lock_acquire+0xb70/0xbfa
 [<ffffffff81072beb>] lock_acquire+0xf4/0x152
 [<ffffffff81025090>] ? _pin_lock+0xb0/0x124
 [<ffffffff81025090>] ? _pin_lock+0xb0/0x124
 [<ffffffff814bc8bb>] _spin_lock+0x45/0x8e
 [<ffffffff81025090>] ? _pin_lock+0xb0/0x124
 [<ffffffff81025090>] _pin_lock+0xb0/0x124
 [<ffffffff81025928>] mm_pin+0x33/0x61
 [<ffffffff810259a3>] arch_dup_mmap+0x4d/0x6a
 [<ffffffff81041b5d>] dup_mm+0x2e5/0x3a2
 [<ffffffff81042823>] copy_process+0xba2/0x13c5
 [<ffffffff810431b9>] do_fork+0x173/0x335
 [<ffffffff8110b3a9>] ? do_vfs_ioctl+0x4aa/0x506
 [<ffffffff8100a353>] ? sysret_check+0x41/0xc0
 [<ffffffff81008358>] sys_clone+0x3b/0x51
 [<ffffffff814bbebb>] ? trace_hardirqs_on_thunk+0x3a/0x3f
 [<ffffffff8100a7b3>] stub_clone+0x13/0x20
 [<ffffffff8100a308>] ? system_call_fastpath+0x16/0x1b

Boris

--- On Fri, 10/23/09, Andrew Lyon <andrew.lyon@...> wrote:

From: Andrew Lyon <andrew.lyon@...>
Subject: Re: [Xen-users] rebased opensuse 2.6.31 xen patches
To: "Marco Nenciarini" <mnencia@...>, "Jan Beulich" <jbeulich@...>, "xen-users List" <xen-users@...>
Date: Friday, October 23, 2009, 7:28 AM

On Fri, Oct 23, 2009 at 12:03 PM, Marco Nenciarini
<mnencia@...> wrote:
> Andrew Lyon ha scritto:
>>
>> On Fri, Oct 23, 2009 at 11:27 AM, Marco Nenciarini
>>
>> Thanks, does this fix a problem you have encountered? If so I would
>> like to see an example of the oops or warning you receive due to this
>> error.
>>
>> Andy
>
> Without that patch it does not compile at all.
>
>
> scripts/kconfig/conf -s arch/x86/Kconfig
>  Using
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen
> as source for kernel
>  GEN
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/Makefile
>  CHK     include/linux/version.h
>  UPD     include/linux/version.h
>  CHK     include/linux/utsrelease.h
>  UPD     include/linux/utsrelease.h
>  SYMLINK include/asm -> include/asm-x86
>  Updating
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/scripts/Makefile.xen
>  CC      kernel/bounds.s
>  GEN     include/linux/bounds.h
>  CC      arch/x86/kernel/asm-offsets.s
> In file included from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/spinlock.h:88,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/seqlock.h:29,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/time.h:8,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/stat.h:60,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/module.h:10,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/crypto.h:21,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets_64.c:7,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:4:
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:134:
> error: expected identifier or ‘(’ before ‘:’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
> error: expected identifier or ‘(’ before ‘}’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
> error: expected identifier or ‘(’ before ‘while’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:
> In function ‘__ticket_spin_lock’:
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
> error: expected ‘:’ or ‘)’ before ‘;’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
> warning: unused variable ‘tmp’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:227:
> error: expected ‘while’ before ‘static’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:5:
> error: expected declaration or statement at end of input
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:215:
> warning: unused variable ‘free’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
> warning: unused variable ‘count’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
> warning: unused variable ‘token’
> make[5]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> make[4]: *** [prepare0] Error 2
>
> Marco
>
> --
> ---------------------------------------------------------------------
> |    Marco Nenciarini    | Debian/GNU Linux Developer - Plug Member |
> | mnencia@... | http://www.prato.linux.it/~mnencia       |
> ---------------------------------------------------------------------
> Key fingerprint = FED9 69C7 9E67 21F5 7D95  5270 6864 730D F095 E5E4
>
>

Weird, I can compile both 32 and 64 bit domU and dom0 without any
errors like that, looking at the code I'd expect to hit that error
straight away.

I've CC'ed Jan and attached your patch to this message, he may want to
merge this upstream (or point out that I'm wrong again).

Andy

-----Inline Attachment Follows-----

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users

Can you test with CONFIG_NR_CPUS set to less than 256?

The code in spinlock.h is assembly and I'm not very familiar with that, before I spend a lot of time looking into this I'd like to know if the bug is specific to the codepath for > 256 cpus.

Thanks
Andy

Andy

_______________________________________________
Xen-users mailing list
Xen-users@...
http://lists.xensource.com/xen-users