Nabble - ruby-core

[ruby-core:28325] [Bug #2670](Closed) Net::IMAP parser problem

2010-02-23T18:01:41Z

Issue #2670 has been updated by Shugo Maeda.

Status changed from Open to Closed

It seems that the fix has been already backported into the ruby_1_8_7 branch.
If you would like to see the fix in the ruby_1_8_6 branch, please create a ticket in the Ruby 1.8.6 project.
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2670

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28324] [Bug #2788] nil.instance_eval pushes nil onto cref

2010-02-23T17:10:42Z

Bug #2788: nil.instance_eval pushes nil onto cref
http://redmine.ruby-lang.org/issues/show/2788

Author: Shugo Maeda
Status: Assigned, Priority: Low
Assigned to: Yukihiro Matsumoto, Category: core
ruby -v: ruby 1.9.2dev (2010-02-18 trunk 26704) [i686-linux]

A singleton class definition of nil pushes NilClass onto cref.
It is reasonable because NilClass has nil as the only instance.
However, nil.instance_eval pushes nil onto cref, which means that method definitions are not permitted in that context.

defiant:ruby$ ruby-trunk -ve 'class <<nil; def foo; puts "foo" end; end; nil.foo'
ruby 1.9.2dev (2010-02-18 trunk 26704) [i686-linux]
foo
defiant:ruby$ ruby-trunk -ve 'nil.instance_eval {|i| def foo; puts "foo" end }; nil.foo'
ruby 1.9.2dev (2010-02-18 trunk 26704) [i686-linux]
-e:1:in `block in <main>': no class/module to add method (TypeError)
from -e:1:in `instance_eval'
from -e:1:in `<main>'

The behavior is the same in Ruby 1.8.7.
Is it intended or a bug?

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28323] [Bug #2555] "case n when *VALID" Broken in Ruby 1.8.8; affects Ruby on Rails

2010-02-23T16:13:41Z

Issue #2555 has been updated by Sam Ruby.

http://redmine.ruby-lang.org/repositories/revision/ruby-18?rev=26737 reverts http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=24695 and addresses this problem. This issue can be closed at this time.
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2555

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28322] [Bug #2786] Segfault when loading gem

2010-02-23T15:25:53Z

Bug #2786: Segfault when loading gem
http://redmine.ruby-lang.org/issues/show/2786

Author: Ryan Bates
Status: Open, Priority: Normal
ruby -v: ruby 1.9.2dev (2010-02-24 trunk 26744) [x86_64-darwin10.0.0]

I am occasionally getting a segfault error when using cucumber 0.6.2 with latest ruby trunk (26744) in Mac OS X 10.6.1. It is happening about 25% of the time I run the cucumber command. Here's the full error:

http://gist.github.com/312461#file_cucumber_segfault

From that error it looks like it is happening when calling the "gem" method and RubyGems is trying to raise an error when it can't find the gem. This is the line in cucumber (ansicolor.rb).

gem 'genki-ruby-terminfo'

I tried to duplicate this by executing that line in irb. I get a Gem::LoadError saying the gem doesn't exist but never a segfault there.

Sorry if this isn't the right place to post this ticket.

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28321] Re: [Bug #2782] Binding#eval not completely indicative of its binding

2010-02-23T14:56:21Z

On Feb 23, 2010, at 05:18 , Thomas Sawyer wrote:

> Bug #2782: Binding#eval not completely indicative of its binding
> http://redmine.ruby-lang.org/issues/show/2782
>
> Author: Thomas Sawyer
> Status: Open, Priority: Normal
> Category: core
> ruby -v: 1.9.1
>
> binding.eval("__FILE__") does not return the file from which the binding was created.
>
> Given the purpose of binding it should hold that:
>
> __FILE__ == binding.eval("__FILE__")

Just my two cents: (yen?)

__FILE__ is expanded at parse time directly into the parse tree. As such, it isn't really a variable or a constant, just a placeholder. I don't think it is going to be easy to make it act like a constant for Binding#eval.

[ruby-core:28320] [Bug #2785] Resolv::DNS Requester#request not checking for nil result

2010-02-23T12:38:59Z

Bug #2785: Resolv::DNS Requester#request not checking for nil result
http://redmine.ruby-lang.org/issues/show/2785

Author: Paul Clegg
Status: Open, Priority: Normal
Category: lib
ruby -v: ruby 1.8.7 (2009-06-12 patchlevel 174) [x86_64-linux]

We've been using Resolv::DNS for some heavy-duty DNS querying, and came across this exception:

/usr/local/lib/ruby/1.8/resolv.rb:630:in `request': undefined method `data' for nil:NilClass (NoMethodError)

Although we haven't been able to reproduce it consistently, looking at the code, there are two ways this scenario can happen:

1. Within the timeout period, all the messages received failed to decode for one reason or another.
2. All the messages received were the results for other DNS queries.

In either case, the local variable 's' is never assigned (or is assigned 'nil') so the final "return msg, s.data" results in a NoMethodError exception.

I'm not sure if it should return "nil" if no valid result is returned, or raise a more specific exception (such as DecodeError), but dereferencing nil definitely seems like a bug.

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28319] [Bug #2781] crash when gc_mark()ing already free'd locals of cloned scope

2010-02-23T12:02:05Z

Issue #2781 has been updated by coderrr ..

just realized the check for SCOPE_CLONE is also no longer needed before freeing locals: http://github.com/coderrr/matzruby/commit/9c80aae67002e443314033b04ceb9c6e5b886c57
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2781

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28318] [Bug #2784] The formatting options hash passed to the to_yaml methods do nothing.

2010-02-23T11:09:26Z

Bug #2784: The formatting options hash passed to the to_yaml methods do nothing.
http://redmine.ruby-lang.org/issues/show/2784

Author: Anshul Khandelwal
Status: Open, Priority: High
Category: lib
ruby -v: 1.8.7, 1.9.1

At the moment, there appears to be no documented way to format the output of the various to_yaml methods. They all accept an options hash but the documentation does not specify what options may be passed.

Also, the use of to_yaml_style is undocumented.

class Array
def to_yaml_style
:inline
end
end

results in inline formatting of the resulting yaml. This is not documented anywhere but works.

This is further described in [1] and [2].

[1] http://stackoverflow.com/questions/1054730/is-it-possible-to-specify-formatting-options-for-toyaml-in-ruby
[2] http://stackoverflow.com/questions/2156762/how-to-get-the-formatting-options-for-the-to-yaml-method-working-on-ruby-1-9-1

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28317] [Bug #2783] Segmentation Fault (using libxml-ruby)

2010-02-23T10:30:38Z

Issue #2783 has been updated by Jon Forums.

If you've somehow installed the x86-mswin32-60 gem in your RubyInstaller environment, the gem linked against a different Ruby version (MSVCRT-RUBY18.DLL) than the 1.9.1 version you're running. This issue is a known cause of segfaults.

A very good XML library that uses libxml2 is Nokogiri http://nokogiri.org/

It is well documented, well maintained, and works well on multiple Ruby versions and implementations including Windows. I'd highly suggest the switch. Try it out with a simple "gem install nokogiri"

Jon
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2783

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28316] [Bug #2783] Segmentation Fault (using libxml-ruby)

2010-02-23T10:07:09Z

Issue #2783 has been updated by Jon Forums.

Please show the results of running the following commands

gem env

gem list libxml-ruby -d

----------------------------------------
http://redmine.ruby-lang.org/issues/show/2783

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28315] [Bug #2783] Segmentation Fault (using libxml-ruby)

2010-02-23T09:51:57Z

Bug #2783: Segmentation Fault (using libxml-ruby)
http://redmine.ruby-lang.org/issues/show/2783

Author: Damián D'Onia
Status: Open, Priority: Normal
ruby -v: ruby 1.9.1p378 (2010-01-10 revision 26273) [i386-mingw32]

I was running a program that creates a new XML node each iteration and save it to a file. I'm newbi using Ruby. This was the error text:

C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:36: [BUG] Segmentation fault
ruby 1.9.1p378 (2010-01-10 revision 26273) [i386-mingw32]

-- control frame ----------
c:0015 p:---- s:0051 b:0051 l:000050 d:000050 CFUNC :[]
c:0014 p:0008 s:0047 b:0047 l:000028 d:000046 BLOCK C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:36
c:0013 p:---- s:0043 b:0043 l:000042 d:000042 FINISH
c:0012 p:---- s:0041 b:0041 l:000040 d:000040 CFUNC :each
c:0011 p:0058 s:0038 b:0038 l:000028 d:000037 BLOCK C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:35
c:0010 p:---- s:0034 b:0034 l:000033 d:000033 FINISH
c:0009 p:---- s:0032 b:0032 l:000031 d:000031 CFUNC :each
c:0008 p:0055 s:0029 b:0029 l:000028 d:000028 METHOD C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:32
c:0007 p:0118 s:0025 b:0025 l:000024 d:000024 METHOD C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file_manager.rb:111
c:0006 p:0065 s:0018 b:0018 l:001a3c d:000017 BLOCK C:/workspace/netbeans/DespegarLogPreProcessor/lib/main.rb:20
c:0005 p:---- s:0013 b:0013 l:000012 d:000012 FINISH
c:0004 p:---- s:0011 b:0011 l:000010 d:000010 CFUNC :each
c:0003 p:0108 s:0008 b:0008 l:001a3c d:00193c EVAL C:/workspace/netbeans/DespegarLogPreProcessor/lib/main.rb:13
c:0002 p:---- s:0004 b:0004 l:000003 d:000003 FINISH
c:0001 p:0000 s:0002 b:0002 l:001a3c d:001a3c TOP
---------------------------
C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:36: [BUG] object allocation during garbage collection phase
ruby 1.9.1p378 (2010-01-10 revision 26273) [i386-mingw32]

-- control frame ----------
c:0015 p:---- s:0051 b:0051 l:000050 d:000050 CFUNC :[]
c:0014 p:0008 s:0047 b:0047 l:000028 d:000046 BLOCK C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:36
c:0013 p:---- s:0043 b:0043 l:000042 d:000042 FINISH
c:0012 p:---- s:0041 b:0041 l:000040 d:000040 CFUNC :each
c:0011 p:0058 s:0038 b:0038 l:000028 d:000037 BLOCK C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:35
c:0010 p:---- s:0034 b:0034 l:000033 d:000033 FINISH
c:0009 p:---- s:0032 b:0032 l:000031 d:000031 CFUNC :each
c:0008 p:0055 s:0029 b:0029 l:000028 d:000028 METHOD C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:32
c:0007 p:0118 s:0025 b:0025 l:000024 d:000024 METHOD C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file_manager.rb:111
c:0006 p:0065 s:0018 b:0018 l:001a3c d:000017 BLOCK C:/workspace/netbeans/DespegarLogPreProcessor/lib/main.rb:20
c:0005 p:---- s:0013 b:0013 l:000012 d:000012 FINISH
c:0004 p:---- s:0011 b:0011 l:000010 d:000010 CFUNC :each
c:0003 p:0108 s:0008 b:0008 l:001a3c d:00193c EVAL C:/workspace/netbeans/DespegarLogPreProcessor/lib/main.rb:13
c:0002 p:---- s:0004 b:0004 l:000003 d:000003 FINISH
c:0001 p:0000 s:0002 b:0002 l:001a3c d:001a3c TOP
---------------------------
-- Ruby level backtrace information-----------------------------------------
C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:36:in `[]'
C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:36:in `block (2 levels) in getrecord'
C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:35:in `each'
C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:35:in `block in getrecord'
C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:32:in `each'
C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file.rb:32:in `getrecord'
C:/workspace/netbeans/DespegarLogPreProcessor/lib/despegar_log_file_manager.rb:111:in `to_xml3'
C:/workspace/netbeans/DespegarLogPreProcessor/lib/main.rb:20:in `block in <main>'
C:/workspace/netbeans/DespegarLogPreProcessor/lib/main.rb:13:in `each'
C:/workspace/netbeans/DespegarLogPreProcessor/lib/main.rb:13:in `<main>'

[NOTE]
You may encounter a bug of Ruby interpreter. Bug reports are welcome.
For details: http://www.ruby-lang.org/bugreport.html

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28314] Re: Is Math module a wrapper of libm?

2010-02-23T08:40:18Z

Hi

On 2010/02/23, at 14:15, Marc-Andre Lafortune <ruby-core-mailing-list@...
> wrote:

> ArgumentError makes sense to me, but I'm not sure why it was
> originally chosen that DivisionByZero was not an ArgumentError.

I believe DivideByZero may be a subclass of ArgumentError because it
is almost synonym to the pole error.

--
Kenta Murata from iPhone

[ruby-core:28313] Re: [Feature #1082] add Object#singleton_class method

2010-02-23T07:00:54Z

On Feb 23, 2010, at 8:48 AM, Shugo Maeda wrote:

>> singleton_class?
>
> x.singleton_class? sounds like "Is x a singleton class?", doesn't it?

Yes, good point.

James Edward Gray II

[ruby-core:28312] Re: [Feature #1082] add Object#singleton_class method

2010-02-23T06:48:54Z

Hi,

2010/2/23 James Edward Gray II <james@...>:
>> He said that it may be worth considering whether
>> singleton_class should provide an (optional) way to tell the existence
>> of a singleton class.
>
> I think I would rather have another method for that, than a boolean flag:

Then, how about to introduce singleton_class as just a short form of
class <<obj; self; end at first?
We can add another method or an optional argument of singleton_class later.

> singleton_class?

x.singleton_class? sounds like "Is x a singleton class?", doesn't it?

--
Shugo Maeda

[ruby-core:28311] Re: [Feature #1082] add Object#singleton_class method

2010-02-23T06:28:59Z

On Feb 23, 2010, at 8:26 AM, Shugo Maeda wrote:

> He said that it may be worth considering whether
> singleton_class should provide an (optional) way to tell the existence
> of a singleton class.

I think I would rather have another method for that, than a boolean flag:

singleton_class?
has_singleton_class?

James Edward Gray II

[ruby-core:28310] Re: [Feature #1082] add Object#singleton_class method

2010-02-23T06:28:22Z

On Feb 23, 2010, at 1:14 AM, Shugo Maeda wrote:

> Hi,
>
> 2010/1/5 Yukihiro Matsumoto <matz@...>:
>> Basically, I agree. But I cannot deny the fact that we already have
>> singleton.rb in the distribution, which provide Singleton class. I
>> confess I did. Probably I shouldn't have.
>
> Today, I talked with Matz, and he has finally agreed with the use of
> the term "singleton class." The reason why he has chosen the term
> "singleton class" is that we have already had
> Kernel#singleton_methods.

Hooray!

James Edward Gray II

[ruby-core:28309] Re: [Feature #1082] add Object#singleton_class method

2010-02-23T06:26:31Z

Hi,

2010/2/23 Kornelius Kalnbach <murphy@...>:
>> Then, the next issue is whether Kernel#singleton_class should create
>> an eigenclass when the receiver has no eigenclass. It would be better
>> to have an optional argument (singleton_class(true/false) or
>> singleton_class(:create => true)?) to switch the behavior.
> I always perceived singleton classes to be transparently created in the
> background. Would it be wise to give the programmer access to its
> existence status? (I assume singleton_class(false) == nil would behave
> like a singleton_class? method.) Today, Ruby has no way of telling
> whether an object already has a singleton class, or am I wrong?

You are right, and it is why Matz wondered whether singleton_class
should create singleton classes. If it always creates singleton
classes, obj.singleton_class is just a short form of class << obj;
self; end. He said that it may be worth considering whether
singleton_class should provide an (optional) way to tell the existence
of a singleton class.

I think transparent creation of singleton classes is reasonable, but
it sometimes annoys me when I'm investigating the behavior of Ruby.
However, I don't come up with such a situation in a real-world
application.

--
Shugo Maeda

[ruby-core:28308] Re: [Feature #1082] add Object#singleton_class method

2010-02-23T06:23:35Z

On Feb 23, 2010, at 2:19 AM, Haase, Konstantin wrote:

> On Feb 23, 2010, at 08:46 , Kornelius Kalnbach wrote:
>
>>> Then, the next issue is whether Kernel#singleton_class should create
>>> an eigenclass when the receiver has no eigenclass. It would be better
>>> to have an optional argument (singleton_class(true/false) or
>>> singleton_class(:create => true)?) to switch the behavior.
>> I always perceived singleton classes to be transparently created in the
>> background. Would it be wise to give the programmer access to its
>> existence status? (I assume singleton_class(false) == nil would behave
>> like a singleton_class? method.) Today, Ruby has no way of telling
>> whether an object already has a singleton class, or am I wrong?
>>
>> Also, why would I ask for a singleton_class without using it?
>>
>
> Agreed. I always assumed that not having a singleton class object for every object was an implementation detail.

Yeah, I agree.

James Edward Gray II

[ruby-core:28307] [Bug #2782] Binding#eval not completely indicative of its binding

2010-02-23T05:18:25Z

Bug #2782: Binding#eval not completely indicative of its binding
http://redmine.ruby-lang.org/issues/show/2782

Author: Thomas Sawyer
Status: Open, Priority: Normal
Category: core
ruby -v: 1.9.1

binding.eval("__FILE__") does not return the file from which the binding was created.

Given the purpose of binding it should hold that:

__FILE__ == binding.eval("__FILE__")

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28306] Re: [Feature #1082] add Object#singleton_class method

2010-02-23T00:19:54Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Feb 23, 2010, at 08:46 , Kornelius Kalnbach wrote:

>> Then, the next issue is whether Kernel#singleton_class should create
>> an eigenclass when the receiver has no eigenclass. It would be better
>> to have an optional argument (singleton_class(true/false) or
>> singleton_class(:create => true)?) to switch the behavior.
> I always perceived singleton classes to be transparently created in the
> background. Would it be wise to give the programmer access to its
> existence status? (I assume singleton_class(false) == nil would behave
> like a singleton_class? method.) Today, Ruby has no way of telling
> whether an object already has a singleton class, or am I wrong?
>
> Also, why would I ask for a singleton_class without using it?
>

Agreed. I always assumed that not having a singleton class object for every object was an implementation detail.

Konstantin

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.14 (Darwin)

iQEcBAEBAgAGBQJLg4+mAAoJEDb0VmU+GZ4kwhgIAJ4gn9+fm46SX8AGlnpG9/N+
3X9Hsf43ua80s95Yy9qD15NSFX1BN4beLDKX9Fv9R9TfOPtzSFG2C03DiNE9Nx64
0y4/4ORrCk38sLDxWIsqaRcbLFsPrQnCq1yupF8o8SDuDPhbyzFRR0BM4ebl+D/E
hfVZuU/HDg8i63bN6UP3zKqBTx8bS1zQAAeltGFulg7x1l2Q0gq+i1oWWRWu1iFN
mjT+fh/r2SW36Yu+F2t1F0IkvayLJ+/nZP73Cs/7z4vF8eK1DFCyjuFWrcJ1d2Gz
r6oPmb/1Zt54twQF7bmjz0svHiCHjyJT5amH+2ZBvMURXKiPwU7oRsjfLtMhNqk=
=BWKR
-----END PGP SIGNATURE-----

[ruby-core:28305] Re: [Feature #1082] add Object#singleton_class method

2010-02-22T23:46:30Z

On 23.02.10 08:14, Shugo Maeda wrote:
> Today, I talked with Matz, and he has finally agreed with the use of
> the term "singleton class." The reason why he has chosen the term
> "singleton class" is that we have already had
> Kernel#singleton_methods.
Yay! \o/

> Then, the next issue is whether Kernel#singleton_class should create
> an eigenclass when the receiver has no eigenclass. It would be better
> to have an optional argument (singleton_class(true/false) or
> singleton_class(:create => true)?) to switch the behavior.
I always perceived singleton classes to be transparently created in the
background. Would it be wise to give the programmer access to its
existence status? (I assume singleton_class(false) == nil would behave
like a singleton_class? method.) Today, Ruby has no way of telling
whether an object already has a singleton class, or am I wrong?

Also, why would I ask for a singleton_class without using it?

[murphy]

[ruby-core:28304] Re: [Feature #1082] add Object#singleton_class method

2010-02-22T23:14:20Z

Hi,

2010/1/5 Yukihiro Matsumoto <matz@...>:
> Basically, I agree. But I cannot deny the fact that we already have
> singleton.rb in the distribution, which provide Singleton class. I
> confess I did. Probably I shouldn't have.

Today, I talked with Matz, and he has finally agreed with the use of
the term "singleton class." The reason why he has chosen the term
"singleton class" is that we have already had
Kernel#singleton_methods.

Then, the next issue is whether Kernel#singleton_class should create
an eigenclass when the receiver has no eigenclass. It would be better
to have an optional argument (singleton_class(true/false) or
singleton_class(:create => true)?) to switch the behavior.

Any thoughts?

--
Shugo Maeda

[ruby-core:28303] Re: Is Math module a wrapper of libm?

2010-02-22T23:07:04Z

2010/2/23 Marc-Andre Lafortune <ruby-core-mailing-list@...>:

> 4) Since we never raise Errno::EDOM and Errno::ERANGE, should they
> still be defined?

They are not only for math library.

% ruby -rsocket -ve '
s = Socket.new(:INET, :DGRAM)
s.setsockopt(:SOCKET, :SNDTIMEO, "\x7f"*8)
'
ruby 1.9.2dev (2009-09-24 trunk 25067) [i686-linux]
-e:3:in `setsockopt': Numerical argument out of domain (Errno::EDOM)
from -e:3:in `<main>'
--
Tanaka Akira

[ruby-core:28302] Re: Is Math module a wrapper of libm?

2010-02-22T21:15:21Z

So here's a summary of the changes that Kenta and I propose, followed
by final questions for everyone.

** Compared to Ruby 1.8:

- New Exception class: DomainError, raised by mathematical functions
for inputs without well defined results
- Errno::EDOM and Errno::ERANGE are no longer raised.
- Corner cases are now platform independent; a few deviate from SUSv3
(see below)

** Interpretation of SUSv3:

- Domain Errors: Ruby 1.9 raises a DomainError in these cases
- Pole Errors: Ruby 1.9 returns +-Infinity, as appropriate.
- Range Errors: Ruby 1.9 returns the under/overflowed result.

** Ruby 1.9 deviates from SUSv3 in a few corner cases:

- Math.atan2(+-0.0, +-0.0) raises a DomainError (instead of returning
+-pi/2 or +-0.0)
- Math.atan2(+-Infinity, +-Infinity) raises a DomainError (instead of
returning +-pi/4 or +-3pi/4)
- Math.lgamma(-Infinity) raises a DomainError (instead of returning +Infinity)
- Math.sqrt(-0.0) returns 0.0 (instead of -0.0)

** Remaining questions

1) Is it ok if 0.0/0.0 raises a DomainError instead of returning NaN?

This has the benefits of making the treatment of domain errors
consistent. The only way to get a NaN from a calculation would then be
to explicitly use Float::NAN for an input.
This might imply some incompatibilities, though?
Should Ruby 1.8.7/8 issue a warning?

2) Should DivisionByZero error be a subclass of DomainError?

I feel it should, but I don't know how much changes to error class
hierarchy should be avoided.

3) Should the new DomainError be a subclass of ArgumentError, or of
RuntimeError?

ArgumentError makes sense to me, but I'm not sure why it was
originally chosen that DivisionByZero was not an ArgumentError.

4) Since we never raise Errno::EDOM and Errno::ERANGE, should they
still be defined?

Removing them might cause incompatibilities (?) but keeping them might
give the wrong impression.

Hopefully others can chime in on these 4 questions?

[ruby-core:28301] Re: [Feature #2759] Regexp /g and /G options

2010-02-22T19:50:27Z

Hi,

2010/2/22 Michael Fellinger <redmine@...>:
> I still don't understand the reasons to fork Oniguruma, why would a fork provide less features than the original?

I think that the "fork" is not a right word in this case.

Oniguruma has not only one regexp. It has language flavors (configura-
tions) to allow each language to select an enabled set of features.
And, Oniguruma's Ruby flavor just disabled ONIG_OPTION_CAPTURE_GROUP.
For another example, Oniguruma itself supports the \Q\E feature for Perl
flavor. Ruby flavor disables \Q\E too.

The reason why Ruby flavor disabled ONIG_OPTION_CAPTURE_GROUP seems:

- ONIG_OPTION_CAPTURE_GROUP is not easy to understand (even Kosako said)
- using both named and unnamed capture at the time is considered as bad
and confusing style in Ruby
- when it was discussed, there was no compatibility issue because there
was no oniguruma gem

It was better for oniguruma gem to disable ONIG_OPTION_CAPTURE_GROUP as
long as it quotes 1.9. Otherwise, it had to explicitly state "the gem
should not be used as 1.9-compat layer, but a wrapper for Oniguruma."

--
Yusuke ENDOH <mame@...>

[ruby-core:28300] [Bug #2781] crash when gc_mark()ing already free'd locals of cloned scope

2010-02-22T15:48:56Z

Bug #2781: crash when gc_mark()ing already free'd locals of cloned scope
http://redmine.ruby-lang.org/issues/show/2781

Author: coderrr .
Status: Open, Priority: High
Category: core
ruby -v: >= 1.8.7-p248

This causes a segfault on >= 1.8.7-p248

---
def def_x(arg)
Object.send :define_method, :x do
def_x lambda{}
end
end

GC.stress = true # unnecessary but makes it occur faster
def_x nil
n = 3 # minimum for crash, increase if needed
n.times { x 0 }
---

This bug was caused by the fix i suggested for #1322, http://github.com/rubyspec/matzruby/commit/7c646cbba0815b3c9c7dc76f80fae58b30ec66b4.

The previous fix is flawed in that it added the SCOPE_MALLOC flag to the scope just so scope_dup() didn't process it. This had the side-effect that gc_mark_children() now processes the scope whereas it would not have before. A better fix is the following, which instead of adding the SCOPE_MALLOC flag, we add a check for the SCOPE_CLONE flag to scope_dup(). This fixes bug #1322 as well as the segfault: http://github.com/coderrr/matzruby/commit/249c7d9912b961a9350f300ed148857100a659f8

Please check the patch for other unforseen side effects. I didn't see any changes in rubyspec failures from p174 to a patched p248.

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28299] Re: Is Math module a wrapper of libm?

2010-02-22T08:15:49Z

Hi,

I agree with your patch including the change of sqrt and logs.
These functions will return complex values for negative input values
in future version of ruby (I believe it is 1.9.3 or later).
So, I don't stick to them.

I feel that returning NaN isn't programmer friendly. I think
generating NaN is need to be noticed for programmers. Though NaN
ruins all of computations with it, the execution isn't interrupted.
Because of that, I suggest raising DomainError instead of retuning
NaN. If raising DomainError, programmers will have to write codes
handling DomainErrors may be raised.

So far, the literal 0.0/0.0 is used for explicitly generating NaN.
Since ruby now have Float::NAN, I think 0.0/0.0 may raises DomainError.

--
Kenta Murata
OpenPGP FP = FA26 35D7 4F98 3498 0810 E0D5 F213 966F E9EB 0BCC

本を書きました!!
『Ruby 逆引きレシピ』 http://www.amazon.co.jp/dp/4798119881/mrkn-22

E-mail: mrkn@...
twitter: http://twitter.com/mrkn/
blog: http://d.hatena.ne.jp/mrkn/

[ruby-core:28298] [Bug #2780] "Handle is invalid" when accessing the file system from different threads (win32)

2010-02-22T08:04:37Z

Bug #2780: "Handle is invalid" when accessing the file system from different threads (win32)
http://redmine.ruby-lang.org/issues/show/2780

Author: Dennis Ranke
Status: Open, Priority: Normal
Category: core
ruby -v: ruby 1.9.1p376 (2009-12-07 revision 26041) [i386-mswin32]

Sometimes when building projects using our own build tool written in ruby, the ruby interpreter crashes on us. The build tool uses multiple threads to compile files in parallel. (Like "make -j 2")

First we got this backtrace:

C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/dependencies.rb:32: [BUG] Das Handle ist ung³ltig.
ruby 1.9.1p0 (2009-01-30 revision 21907) [i386-mswin32]
-- control frame ----------
c:0013 p:---- s:0052 b:0052 l:000051 d:000051 CFUNC :initialize
c:0012 p:---- s:0050 b:0050 l:000049 d:000049 CFUNC :open
c:0011 p:0042 s:0045 b:0045 l:000044 d:000044 METHOD C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/dependencies.rb:32
c:0010 p:0497 s:0039 b:0039 l:000bf0 d:002164 BLOCK C:/projekte/tools/code/shared/modules_compiler/compiler/win32/msvc/vc13106030/msvcbase.def:154
c:0009 p:0038 s:0029 b:0029 l:000028 d:000028 METHOD C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/compilerbase.rb:200
c:0008 p:0043 s:0022 b:0022 l:000021 d:000021 METHOD C:/projekte/tools/code/shared/modules_compiler/compiler/win32/msvc/vc13106030/msvcbase.def:104
c:0007 p:0185 s:0016 b:0016 l:001d68 d:000015 BLOCK C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/compilerbase.rb:282
c:0006 p:---- s:0013 b:0013 l:000012 d:000012 FINISH
c:0005 p:---- s:0011 b:0011 l:000010 d:000010 CFUNC :loop
c:0004 p:0009 s:0008 b:0008 l:001d68 d:000007 BLOCK C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/compilerbase.rb:269
c:0003 p:0007 s:0006 b:0006 l:001d8c d:000005 BLOCK C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/compilerbase.rb:221
c:0002 p:---- s:0004 b:0004 l:000003 d:000003 FINISH
c:0001 p:---- s:0002 b:0002 l:000001 d:000001 TOP
---------------------------
-- Ruby level backtrace information-----------------------------------------
C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/compilerbase.rb:200:in `read'
C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/compilerbase.rb:200:in `check_optimized_dependencies'
C:/projekte/tools/code/shared/modules_compiler/compiler/win32/msvc/vc13106030/msvcbase.def:104:in `compile'
C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/compilerbase.rb:282:in `block (2 levels) in process_files'
C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/compilerbase.rb:269:in `loop'
C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/compilerbase.rb:269:in `block in process_files'
C:/projekte/tools/code/animation/AnimationConverter/helpers/lace/lib/lace/compilerbase.rb:221:in `block (2 levels) in threaded'
[NOTE]
You may encounter a bug of Ruby interpreter. Bug reports are welcome.
For details: http://www.ruby-lang.org/bugreport.html

This is in a File.read call.
I have then wrapped this File.read in a mutex and now get (less frequently):

C:/projekte/xxx/code_buildmachine/local/helpers/lace/lib/lace/dependencies.rb:31: [BUG] Das Handle ist ung³ltig.
ruby 1.9.1p376 (2009-12-07 revision 26041) [i386-mswin32]
-- control frame ----------
c:0018 p:---- s:0066 b:0065 l:000064 d:000064 CFUNC :expand_path
c:0017 p:0027 s:0061 b:0061 l:000043 d:000060 BLOCK C:/projekte/xxx/code_buildmachine/local/helpers/lace/lib/lace/dependencies.rb:31
c:0016 p:---- s:0058 b:0058 l:000057 d:000057 FINISH
c:0015 p:---- s:0056 b:0056 l:000055 d:000055 CFUNC :each
c:0014 p:0029 s:0053 b:0053 l:000043 d:000052 BLOCK C:/projekte/xxx/code_buildmachine/local/helpers/lace/lib/lace/dependencies.rb:30
c:0013 p:---- s:0049 b:0049 l:000048 d:000048 FINISH
c:0012 p:---- s:0047 b:0047 l:000046 d:000046 CFUNC :map
c:0011 p:0016 s:0044 b:0044 l:000043 d:000043 METHOD C:/projekte/xxx/code_buildmachine/local/helpers/lace/lib/lace/dependencies.rb:28
c:0010 p:0379 s:0038 b:0038 l:001608 d:000aec BLOCK C:/projekte/xxx/code_buildmachine/stable/modules_compilers/compiler/xb360/module.lace:61
c:0009 p:0070 s:0028 b:0028 l:000027 d:000027 METHOD C:/projekte/xxx/code_buildmachine/local/helpers/lace/lib/lace/compilerbase.rb:202
c:0008 p:0043 s:0022 b:0022 l:001608 d:001608 METHOD C:/projekte/xxx/code_buildmachine/stable/modules_compilers/compiler/xb360/module.lace:18
c:0007 p:0185 s:0016 b:0016 l:000e40 d:000015 BLOCK C:/projekte/xxx/code_buildmachine/local/helpers/lace/lib/lace/compilerbase.rb:283
c:0006 p:---- s:0013 b:0013 l:000012 d:000012 FINISH
c:0005 p:---- s:0011 b:0011 l:000010 d:000010 CFUNC :loop
c:0004 p:0009 s:0008 b:0008 l:000e40 d:000007 BLOCK C:/projekte/xxx/code_buildmachine/local/helpers/lace/lib/lace/compilerbase.rb:270
c:0003 p:0007 s:0006 b:0006 l:002074 d:000005 BLOCK C:/projekte/xxx/code_buildmachine/local/helpers/lace/lib/lace/compilerbase.rb:222
c:0001 p:---- s:0002 b:0002 l:000001 d:000001 TOP
c:0002 p:---- s:0004 b:0004 l:000003 d:000003 FINISH

Ie. the same error in a File.expand_path. ("Das Handle ist ung³ltig." translates to "The handle is invalid.") This was tested on Windows XP.

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28297] Re: [Bug #2330] Non systematic segmentation fault with autoload rubyspec

2010-02-22T07:48:18Z

Hi.

On Mon, Feb 1, 2010 at 12:54 PM, Marc-Andre Lafortune
<ruby-core-mailing-list@...> wrote:
> I can confirm that it doesn't segfault anymore if this patch is applied.

It turns out it doesn't segfault _most of the times_. When running the
original rubyspec, though, it still crashes most of the time. I ran a
loop on my minimal case. It still crashes, but it may take thousands
of runs before it does.

Appears related to [ruby-dev:40452]

I should install valgrind...

[ruby-core:28296] [Bug #2779] Net::HTTP#get raises NoMethodError

2010-02-22T04:26:30Z

Bug #2779: Net::HTTP#get raises NoMethodError
http://redmine.ruby-lang.org/issues/show/2779

Author: Stephen Sykes
Status: Open, Priority: Normal
Category: lib
ruby -v: ruby 1.8.7 (2009-12-24 patchlevel 248) [i686-darwin10.2.0]

I think this was introduced in Revision 25851:

require 'net/http'
nh = Net::HTTP.new("does_not_exist_at_all.com")
nh.get("/")
NoMethodError: undefined method `closed?' for nil:NilClass
from /usr/local/lib/ruby/1.8/net/http.rb:1060:in `request'
from /usr/local/lib/ruby/1.8/net/http.rb:772:in `get'
from (irb):11
from /usr/local/lib/ruby/1.8/net/http.rb:2042

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28295] [Backport #1743] r23201 should be backported to 1.8.6

2010-02-22T02:24:56Z

Issue #1743 has been updated by Kornelius Kalnbach.

I get "Virtual timer expired" after this patch when using Rails. The "Phusion passenger guys":http://blog.phusion.nl/2009/05/20/ruby-enterprise-edition-186-20090520-released/ seem to have fixed the issue.
----------------------------------------
http://redmine.ruby-lang.org/issues/show/1743

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28294] [Feature #2778] Regular Expression Named Group Matching does not work with String#[]

2010-02-22T01:54:35Z

Issue #2778 has been updated by Yui NARUSE.

"will" means 1.9.2 is not released yet; the code is already in trunk.
see also #966
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2778

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28293] [Feature #2778] Regular Expression Named Group Matching does not work with String#[]

2010-02-22T01:24:22Z

Issue #2778 has been updated by Robert Klemme.

Thanks for the update! I wonder whether closing is the proper resolution. Shouldn't we be setting target version to 1.9.2 and keep this open until the code change is done?
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2778

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28292] [Feature #2778](Closed) Regular Expression Named Group Matching does not work with String#[]

2010-02-22T00:58:09Z

Issue #2778 has been updated by Yui NARUSE.

Status changed from Open to Closed

This will be implemented in Ruby 1.9.2.
----------------------------------------
http://redmine.ruby-lang.org/issues/show/2778

----------------------------------------
http://redmine.ruby-lang.org

[ruby-core:28291] Re: Is Math module a wrapper of libm?

2010-02-22T00:31:19Z

Hi!

I like the direction we're taking.

I've been thinking about a general decision algorithm. It would look like:

Try to come up with a valid mathematical value (including +-inf but
excluding NaN):
- Check all possible values (excluding NaN). If there is exactly one,
you're done.
- If there are many possible values, are they all basically equal
(e.g. -0.0 vs +0.0, or +pi vs -pi for an angle)? If so, then return
the best one.
- If the possible values are +-Infinity, and the input is +-0.0 can
tell you which to pick, then return the right infinity (pole error
case)
- Otherwise return NaN or raise an error.

This algorithm agrees with your proposal that atan2(0,0) should raise
an error. While we're contradicting IEEE, have you thought of
atan2(+-Inf, +-Inf)? I feel it should also be an error, in the same
way that Inf/Inf doesn't return 1!

Here's an incremental patch that modifies the code according to this.
Note that infinity_check was already redundant, so I removed it.
domain_check was also redundant except potentially for some corner
cases. Indeed SUSv3 states that implementations may set the ERANGE
error flag in case of subnormal values. domain_check would raise an
error if this was the case. Since this behavior is platform dependant
(and far from useful), I removed domain_check also.

I included a line so that sqrt(-0.0) = +0.0 instead of -0.0, because I
feel it makes sense and is consistent with pow(-0.0, 0.5) == +0.0, but
I don't think it matters all that much and I definitely won't fight
over it.

The question that remains in my mind: is it better to return NaN or
raise a domain error? Why should 0.0/0.0 == NaN and atan2(0.0, 0.0)
raise an error? I personally would lean towards always returning NaN
instead of raising an error, but I am not confident in this
preference. Or never return NaN? Thoughts?

diff --git a/math.c b/math.c
index 5064d05..77a8757 100644
--- a/math.c
+++ b/math.c
@@ -11,7 +11,6 @@

#include "ruby/ruby.h"
#include <math.h>
-#include <errno.h>

#define numberof(array) (int)(sizeof(array) / sizeof((array)[0]))

@@ -28,45 +27,6 @@ extern VALUE rb_to_float(VALUE val);
#define domain_error(msg) \
rb_raise(rb_eMathDomainError, "Numerical argument is out of
domain - " #msg);

-static void
-domain_check(double x, double y, const char *msg)
-{
- if (errno) {
- if (isinf(y)) return;
- }
- else {
- if (!isnan(y)) return;
- else if (isnan(x)) return;
- else {
-#if defined(EDOM)
- errno = EDOM;
-#else
- errno = ERANGE;
-#endif
- }
- }
- rb_sys_fail(msg);
-}
-
-static void
-infinity_check(VALUE arg, double res, const char *msg)
-{
- while(1) {
- if (errno) {
- rb_sys_fail(msg);
- }
- if (isinf(res) && !isinf(RFLOAT_VALUE(arg))) {
-#if defined(EDOM)
- errno = EDOM;
-#elif defined(ERANGE)
- errno = ERANGE;
-#endif
- continue;
- }
- break;
- }
-}
-
/*
* call-seq:
* Math.atan2(y, x) => float
@@ -95,6 +55,7 @@ math_atan2(VALUE obj, VALUE y, VALUE x)
dx = RFLOAT_VALUE(x);
dy = RFLOAT_VALUE(y);
if (dx == 0.0 && dy == 0.0) domain_error("atan2");
+ if (isinf(dx) && isinf(dy)) domain_error("atan2");
return DBL2NUM(atan2(dy, dx));
}

@@ -159,12 +120,10 @@ math_acos(VALUE obj, VALUE x)
double d0, d;

Need_Float(x);
- errno = 0;
d0 = RFLOAT_VALUE(x);
/* check for domain error */
if (d0 < -1.0 || 1.0 < d0) domain_error("acos");
d = acos(d0);
- domain_check(d0, d, "acos");
return DBL2NUM(d);
}

@@ -181,12 +140,10 @@ math_asin(VALUE obj, VALUE x)
double d0, d;

Need_Float(x);
- errno = 0;
d0 = RFLOAT_VALUE(x);
/* check for domain error */
if (d0 < -1.0 || 1.0 < d0) domain_error("asin");
d = asin(d0);
- domain_check(d0, d, "asin");
return DBL2NUM(d);
}

@@ -286,12 +243,10 @@ math_acosh(VALUE obj, VALUE x)
double d0, d;

Need_Float(x);
- errno = 0;
d0 = RFLOAT_VALUE(x);
/* check for domain error */
if (d0 < 1.0) domain_error("acosh");
d = acosh(d0);
- domain_check(d0, d, "acosh");
return DBL2NUM(d);
}

@@ -322,7 +277,6 @@ math_atanh(VALUE obj, VALUE x)
double d0, d;

Need_Float(x);
- errno = 0;
d0 = RFLOAT_VALUE(x);
/* check for domain error */
if (d0 < -1.0 || +1.0 < d0) domain_error("atanh");
@@ -330,8 +284,6 @@ math_atanh(VALUE obj, VALUE x)
if (d0 == -1.0) return DBL2NUM(-INFINITY);
if (d0 == +1.0) return DBL2NUM(+INFINITY);
d = atanh(d0);
- domain_check(d0, d, "atanh");
- infinity_check(x, d, "atanh");
return DBL2NUM(d);
}

@@ -387,19 +339,16 @@ math_log(int argc, VALUE *argv)

rb_scan_args(argc, argv, "11", &x, &base);
Need_Float(x);
- errno = 0;
d0 = RFLOAT_VALUE(x);
/* check for domain error */
- if (signbit(d0)) domain_error("log");
+ if (d0 < 0.0) domain_error("log");
/* check for pole error */
- if (d0 == +0.0) return DBL2NUM(-INFINITY);
+ if (d0 == 0.0) return DBL2NUM(-INFINITY);
d = log(d0);
if (argc == 2) {
Need_Float(base);
d /= log(RFLOAT_VALUE(base));
}
- domain_check(d0, d, "log");
- infinity_check(x, d, "log");
return DBL2NUM(d);
}

@@ -434,15 +383,12 @@ math_log2(VALUE obj, VALUE x)
double d0, d;

Need_Float(x);
- errno = 0;
d0 = RFLOAT_VALUE(x);
/* check for domain error */
- if (signbit(d0)) domain_error("log2");
+ if (d0 < 0.0) domain_error("log2");
/* check for pole error */
- if (d0 == +0.0) return DBL2NUM(-INFINITY);
+ if (d0 == 0.0) return DBL2NUM(-INFINITY);
d = log2(d0);
- domain_check(d0, d, "log2");
- infinity_check(x, d, "log2");
return DBL2NUM(d);
}

@@ -464,15 +410,12 @@ math_log10(VALUE obj, VALUE x)
double d0, d;

Need_Float(x);
- errno = 0;
d0 = RFLOAT_VALUE(x);
/* check for domain error */
- if (signbit(d0)) domain_error("log10");
+ if (d0 < 0.0) domain_error("log10");
/* check for pole error */
- if (d0 == +0.0) return DBL2NUM(-INFINITY);
+ if (d0 == 0.0) return DBL2NUM(-INFINITY);
d = log10(d0);
- domain_check(d0, d, "log10");
- infinity_check(x, d, "log10");
return DBL2NUM(d);
}

@@ -506,12 +449,11 @@ math_sqrt(VALUE obj, VALUE x)
double d0, d;

Need_Float(x);
- errno = 0;
d0 = RFLOAT_VALUE(x);
/* check for domain error */
- if (signbit(d0)) domain_error("sqrt");
+ if (d0 < 0) domain_error("sqrt");
+ if (d0 == 0) return DBL2NUM(0);
d = sqrt(d0);
- domain_check(d0, d, "sqrt");
return DBL2NUM(d);
}

@@ -718,14 +660,14 @@ math_gamma(VALUE obj, VALUE x)
/* check for domain error */
if (isinf(d0) && signbit(d0)) domain_error("gamma");
fracpart = modf(d0, &intpart);
- if (fracpart == 0.0 &&
- 0 < intpart &&
- intpart - 1 < (double)numberof(fact_table)) {
- return DBL2NUM(fact_table[(int)intpart - 1]);
+ if (fracpart == 0.0) {
+ if (intpart < 0) domain_error("gamma");
+ if (0 < intpart &&
+ intpart - 1 < (double)numberof(fact_table)) {
+ return DBL2NUM(fact_table[(int)intpart - 1]);
+ }
}
- errno = 0;
d = tgamma(d0);
- domain_check(d0, d, "gamma");
return DBL2NUM(d);
}

@@ -748,7 +690,6 @@ math_lgamma(VALUE obj, VALUE x)
int sign=1;
VALUE v;
Need_Float(x);
- errno = 0;
d0 = RFLOAT_VALUE(x);
/* check for domain error */
if (isinf(d0) && signbit(d0)) domain_error("lgamma");
@@ -756,7 +697,6 @@ math_lgamma(VALUE obj, VALUE x)
return rb_assoc_new(DBL2NUM(INFINITY), INT2FIX(1));
}
d = lgamma_r(d0, &sign);
- domain_check(d0, d, "lgamma");
v = DBL2NUM(d);
return rb_assoc_new(v, INT2FIX(sign));
}
diff --git a/test/ruby/test_math.rb b/test/ruby/test_math.rb
index 3963e91..2f654c1 100644
--- a/test/ruby/test_math.rb
+++ b/test/ruby/test_math.rb
@@ -18,6 +18,7 @@ class TestMath < Test::Unit::TestCase

def test_atan2
assert_raise(Math::DomainError) { Math.atan2(0, 0) }
+ assert_raise(Math::DomainError) { Math.atan2(1.0 / 0.0, 1.0 / 0.0) }
check(0, Math.atan2(0, 1))
check(Math::PI / 4, Math.atan2(1, 1))
check(Math::PI / 2, Math.atan2(1, 0))
@@ -131,7 +132,7 @@ class TestMath < Test::Unit::TestCase
check(2, Math.log(100, 10))
assert_equal(1.0/0, Math.log(1.0/0))
assert_nothing_raised { assert_infinity -Math.log(+0.0) }
- assert_raise(Math::DomainError) { Math.log(-0.0) } # TODO:
[ruby-core:28265]
+ assert_nothing_raised { assert_infinity -Math.log(-0.0) }
assert_raise(Math::DomainError) { Math.log(-1.0) }
assert_raise(TypeError) { Math.log(1,nil) }
end
@@ -142,7 +143,7 @@ class TestMath < Test::Unit::TestCase
check(2, Math.log2(4))
assert_equal(1.0/0, Math.log2(1.0/0))
assert_nothing_raised { assert_infinity -Math.log2(+0.0) }
- assert_raise(Math::DomainError) { Math.log2(-0.0) } # TODO:
[ruby-core:28265]
+ assert_nothing_raised { assert_infinity -Math.log2(-0.0) }
assert_raise(Math::DomainError) { Math.log2(-1.0) }
end

@@ -152,7 +153,7 @@ class TestMath < Test::Unit::TestCase
check(2, Math.log10(100))
assert_equal(1.0/0, Math.log10(1.0/0))
assert_nothing_raised { assert_infinity -Math.log10(+0.0) }
- assert_raise(Math::DomainError) { Math.log10(-0.0) } # TODO:
[ruby-core:28265]
+ assert_nothing_raised { assert_infinity -Math.log10(-0.0) }
assert_raise(Math::DomainError) { Math.log10(-1.0) }
end

@@ -161,7 +162,7 @@ class TestMath < Test::Unit::TestCase
check(1, Math.sqrt(1))
check(2, Math.sqrt(4))
assert_equal(1.0/0, Math.sqrt(1.0/0))
- assert_raise(Math::DomainError) { Math.sqrt(-0.0) } # TODO:
[ruby-core:28265]
+ assert_equal("0.0", Math.sqrt(-0.0).to_s) # insure it is +0.0, not -0.0
assert_raise(Math::DomainError) { Math.sqrt(-1.0) }
end