slf4j dependency and scalax.logging

View: New views
2 Messages — Rating Filter:   Alert me  

slf4j dependency and scalax.logging

by David MacIver :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

From the build.xml:

<pathelement location="${user.home}/.m2/repository/org/slf4j/slf4j-api/1.5.0/slf4j-api-1.5.0.jar"/>

scalax.logging depends on slf4j. In particular, it depends on you
having gotten it from maven. This seems wildly inappropriate to me.

a) I was under the impression that scalax core was intended to not
have external dependencies.
b) Implicitly requiring maven behaviour for the ant buildfile is just
wrong. If you want a dependency and don't want to use an integrated
dependency manager within scalax (whether it's maven, ivy, some hacked
together replacement, whatever), it needs to be in the source
repository.

Additionally, it breaks the makefile because it doesn't include this
dependency in the build.


Re: slf4j dependency and scalax.logging

by Jamie Webb-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 2008-08-25 16:42:00 David MacIver wrote:

> From the build.xml:
>
> <pathelement
> location="${user.home}/.m2/repository/org/slf4j/slf4j-api/1.5.0/slf4j-api-1.5.0.jar"/>
>
> scalax.logging depends on slf4j. In particular, it depends on you
> having gotten it from maven. This seems wildly inappropriate to me.
>
> a) I was under the impression that scalax core was intended to not
> have external dependencies.

No, just to have minimal dependencies. Logging is pretty unavoidable. I
agree it would nice not to have that dependency for the more 'pure'
parts of the code though. This is probably a good argument for Maven
subprojects.

> b) Implicitly requiring maven behaviour for the ant buildfile is just
> wrong. If you want a dependency and don't want to use an integrated
> dependency manager within scalax (whether it's maven, ivy, some hacked
> together replacement, whatever), it needs to be in the source
> repository.
>
> Additionally, it breaks the makefile because it doesn't include this
> dependency in the build.

Indeed. Essentially, I think most of us use Maven and only want to
support Maven. The other two methods are retained, but with no
promises. I've fixed them up for now, and added messages explaining the
situation.

/J