some regressions in current HEAD
|
View:
New views
17 Messages
—
Rating Filter:
Alert me
|
 |
some regressions in current HEAD
by Ildar Mulyukov
::
Rate this Message:
Hi!
I've got some regressions with current HEAD. 1. Changing identities in the New message window wipes out the signature and does not add another sig. Have to insert the signature by hand. 2. In Mailbox properties the "Update" button is disabled. If I change the Identity, it doesn't get enabled. I believe that it was not that way. This is for Maildir only. The mbox behaves allright. Best regards, Ildar -- Ildar Mulyukov, free SW designer/programmer/packager ========================================= email: ildar@... Jabber: ildar@... ICQ: 4334029 ALT Linux Sisyphus http://www.sisyphus.ru ========================================= _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Ildar Mulyukov
::
Rate this Message:
On 29.06.2009 10:59:41, Ildar Mulyukov wrote:
> Hi! > > I've got some regressions with current HEAD. > > 1. Changing identities in the New message window wipes out the > signature and does not add another sig. Have to insert the signature > by hand. > > 2. In Mailbox properties the "Update" button is disabled. If I change > the Identity, it doesn't get enabled. I believe that it was not that > way. This is for Maildir only. The mbox behaves allright. And 3: Unread mail counter sometimes gets to negative numbers. This is not a regression - it was there for ages. It can be seen for example when you "Hide Unflagged" and some new mail arrives or gets read. Counter algorithms are not good for filtered box situations. Thanks. -- Ildar Mulyukov, free SW designer/programmer/packager ========================================= email: ildar@... Jabber: ildar@... ICQ: 4334029 ALT Linux Sisyphus http://www.sisyphus.ru ========================================= _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Ildar Mulyukov
::
Rate this Message:
On 29.06.2009 12:12:48, Ildar Mulyukov wrote:
> On 29.06.2009 10:59:41, Ildar Mulyukov wrote: >> I've got some regressions with current HEAD. >> >> 1. Changing identities in the New message window wipes out the >> signature and does not add another sig. Have to insert the signature >> by hand. >> 2. In Mailbox properties the "Update" button is disabled. If I >> change the Identity, it doesn't get enabled. I believe that it was >> not that way. This is for Maildir only. The mbox behaves allright. > 3: Unread mail counter sometimes gets to negative numbers. This is > not a regression - it was there for ages. It can be seen for example > when you "Hide Unflagged" and some new mail arrives or gets read. > Counter algorithms are not good for filtered box situations. True regression: 4. *Find in Message* does not work either. Anyone to react? -- Ildar Mulyukov, free SW designer/programmer/packager ========================================= email: ildar@... Jabber: ildar@... ICQ: 4334029 ALT Linux Sisyphus http://www.sisyphus.ru ========================================= _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Pawel Salek-4
::
Rate this Message:
On 06/30/2009 07:41:25 AM, Ildar Mulyukov wrote:
> On 29.06.2009 12:12:48, Ildar Mulyukov wrote: >> On 29.06.2009 10:59:41, Ildar Mulyukov wrote: >>> I've got some regressions with current HEAD. >>> >>> 1. Changing identities in the New message window wipes out the >>> signature and does not add another sig. Have to insert the >>> signature by hand. Confirmed. >>> 2. In Mailbox properties the "Update" button is disabled. If I >>> change the Identity, it doesn't get enabled. I believe that it was >>> not that way. This is for Maildir only. The mbox behaves allright. Confirmed. >> 3: Unread mail counter sometimes gets to negative numbers. This is >> not a regression - it was there for ages. It can be seen for example >> when you "Hide Unflagged" and some new mail arrives or gets read. >> Counter algorithms are not good for filtered box situations. I don't see that. I did as follows: > True regression: > 4. *Find in Message* does not work either. I do not see that. The search widget is displated and when I type characters, the current hit gets highlighted as expeted. Can you please list a step-by-step scenario that exposes the problem? > Anyone to react? Could you please verify whether the attached patch fixes the problems 1 and 2? Pawel [0001--src-mailbox-conf.c-enable-update-button-when-ed.patch] From 81be24cd120e1d3d7adbdeaac9c517f8faa2b35a Mon Sep 17 00:00:00 2001 From: Pawel Salek <pawsa@...> Date: Tue, 30 Jun 2009 18:56:19 +0200 Subject: [PATCH] Fix two out of four issues reported by Ildar. * src/mailbox-conf.c: enable "update" button when editing maildir/mh mboxes. * src/sendmsg-window.c: insert sig when changing identities in a new message. --- src/mailbox-conf.c | 2 +- src/sendmsg-window.c | 45 +++++++++++++++++++++++++-------------------- 2 files changed, 26 insertions(+), 21 deletions(-) diff --git a/src/mailbox-conf.c b/src/mailbox-conf.c index 9e108d8..1f8a6e1 100644 --- a/src/mailbox-conf.c +++ b/src/mailbox-conf.c @@ -1095,7 +1095,7 @@ create_local_mailbox_dialog(MailboxConfWindow *mcw) action = mcw->mailbox_type == LIBBALSA_TYPE_MAILBOX_MBOX ? GTK_FILE_CHOOSER_ACTION_SAVE : - GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER; + GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER; dialog = gtk_file_chooser_dialog_new(_("Local Mailbox Configurator"), GTK_WINDOW(balsa_app.main_window), diff --git a/src/sendmsg-window.c b/src/sendmsg-window.c index 9c651ab..ae8faa7 100644 --- a/src/sendmsg-window.c +++ b/src/sendmsg-window.c @@ -180,11 +180,11 @@ static void edit_with_gnome(GtkAction * action, BalsaSendmsg* bsmsg); #endif static void change_identity_dialog_cb(GtkAction * action, BalsaSendmsg * bsmsg); -static void repl_identity_signature(BalsaSendmsg* bsmsg, - LibBalsaIdentity* new_ident, - LibBalsaIdentity* old_ident, - gint* replace_offset, gint siglen, - gchar* new_sig); +static void replace_identity_signature(BalsaSendmsg* bsmsg, + LibBalsaIdentity* new_ident, + LibBalsaIdentity* old_ident, + gint* replace_offset, gint siglen, + const gchar* new_sig); static void update_bsmsg_identity(BalsaSendmsg*, LibBalsaIdentity*); static void sw_size_alloc_cb(GtkWidget * window, GtkAllocation * alloc); @@ -1269,9 +1269,9 @@ change_identity_dialog_cb(GtkAction * action, BalsaSendmsg* bsmsg) /* NOTE: replace_offset and siglen are utf-8 character offsets. */ static void -repl_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, - LibBalsaIdentity* old_ident, gint* replace_offset, - gint siglen, gchar* new_sig) +replace_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, + LibBalsaIdentity* old_ident, gint* replace_offset, + gint siglen, const gchar* new_sig) { gint newsiglen; gboolean reply_type = (bsmsg->type == SEND_REPLY || @@ -1299,8 +1299,9 @@ repl_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, /* check to see if this is a reply or forward and compare identity * settings to determine whether to add signature */ - if ((reply_type && new_ident->sig_whenreply) || - (forward_type && new_ident->sig_whenforward)) { + if (bsmsg->type == SEND_NORMAL || + (reply_type && new_ident->sig_whenreply) || + (forward_type && new_ident->sig_whenforward)) { /* see if sig location is probably going to be the same */ if (new_ident->sig_prepend == old_ident->sig_prepend) { @@ -1315,6 +1316,7 @@ repl_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, /* put it at the end of the message */ gtk_text_buffer_get_end_iter(buffer, &ins); } + printf("Inserting new sig\n"); gtk_text_buffer_place_cursor(buffer, &ins); gtk_text_buffer_insert_at_cursor(buffer, new_sig, -1); } @@ -1549,8 +1551,8 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) if (!old_sig) { replace_offset = bsmsg->ident->sig_prepend ? 0 : g_utf8_strlen(message_text, -1); - repl_identity_signature(bsmsg, ident, old_ident, &replace_offset, - 0, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, &replace_offset, + 0, new_sig); } else { /* split on sig separator */ message_split = g_strsplit(message_text, "\n-- \n", 0); @@ -1561,8 +1563,8 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) if (g_ascii_strncasecmp(old_sig, compare_str, siglen) == 0) { g_free(compare_str); - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen - 1, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen - 1, new_sig); found_sig = TRUE; } else { g_free(compare_str); @@ -1572,8 +1574,9 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) /* try to find occurance of old signature */ if (g_ascii_strncasecmp(old_sig, compare_str, siglen) == 0) { - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen, + new_sig); found_sig = TRUE; } @@ -1596,16 +1599,18 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) if (g_ascii_strncasecmp(old_sig, tmpstr, siglen) == 0) { g_free(tmpstr); - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen - 1, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen - 1, + new_sig); } else { g_free(tmpstr); replace_offset++; compare_str = g_utf8_next_char(compare_str); while (*compare_str) { if (g_ascii_strncasecmp(old_sig, compare_str, siglen) == 0) { - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen, + new_sig); } replace_offset++; compare_str = g_utf8_next_char(compare_str); -- 1.6.0.6 _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Pawel Salek
::
Rate this Message:
On 06/30/2009 07:41:25 AM, Ildar Mulyukov wrote:
> On 29.06.2009 12:12:48, Ildar Mulyukov wrote: >> On 29.06.2009 10:59:41, Ildar Mulyukov wrote: >>> I've got some regressions with current HEAD. >>> >>> 1. Changing identities in the New message window wipes out the >>> signature and does not add another sig. Have to insert the >>> signature by hand. Confirmed. >>> 2. In Mailbox properties the "Update" button is disabled. If I >>> change the Identity, it doesn't get enabled. I believe that it was >>> not that way. This is for Maildir only. The mbox behaves allright. Confirmed. >> 3: Unread mail counter sometimes gets to negative numbers. This is >> not a regression - it was there for ages. It can be seen for example >> when you "Hide Unflagged" and some new mail arrives or gets read. >> Counter algorithms are not good for filtered box situations. I don't see that. I did as follows: > True regression: > 4. *Find in Message* does not work either. I do not see that. The search widget is displated and when I type characters, the current hit gets highlighted as expeted. Can you please list a step-by-step scenario that exposes the problem? > Anyone to react? Could you please verify whether the attached patch fixes the problems 1 and 2? Pawel [0001--src-mailbox-conf.c-enable-update-button-when-ed.patch] From 81be24cd120e1d3d7adbdeaac9c517f8faa2b35a Mon Sep 17 00:00:00 2001 From: Pawel Salek <pawsa@...> Date: Tue, 30 Jun 2009 18:56:19 +0200 Subject: [PATCH] Fix two out of four issues reported by Ildar. * src/mailbox-conf.c: enable "update" button when editing maildir/mh mboxes. * src/sendmsg-window.c: insert sig when changing identities in a new message. --- src/mailbox-conf.c | 2 +- src/sendmsg-window.c | 45 +++++++++++++++++++++++++-------------------- 2 files changed, 26 insertions(+), 21 deletions(-) diff --git a/src/mailbox-conf.c b/src/mailbox-conf.c index 9e108d8..1f8a6e1 100644 --- a/src/mailbox-conf.c +++ b/src/mailbox-conf.c @@ -1095,7 +1095,7 @@ create_local_mailbox_dialog(MailboxConfWindow *mcw) action = mcw->mailbox_type == LIBBALSA_TYPE_MAILBOX_MBOX ? GTK_FILE_CHOOSER_ACTION_SAVE : - GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER; + GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER; dialog = gtk_file_chooser_dialog_new(_("Local Mailbox Configurator"), GTK_WINDOW(balsa_app.main_window), diff --git a/src/sendmsg-window.c b/src/sendmsg-window.c index 9c651ab..ae8faa7 100644 --- a/src/sendmsg-window.c +++ b/src/sendmsg-window.c @@ -180,11 +180,11 @@ static void edit_with_gnome(GtkAction * action, BalsaSendmsg* bsmsg); #endif static void change_identity_dialog_cb(GtkAction * action, BalsaSendmsg * bsmsg); -static void repl_identity_signature(BalsaSendmsg* bsmsg, - LibBalsaIdentity* new_ident, - LibBalsaIdentity* old_ident, - gint* replace_offset, gint siglen, - gchar* new_sig); +static void replace_identity_signature(BalsaSendmsg* bsmsg, + LibBalsaIdentity* new_ident, + LibBalsaIdentity* old_ident, + gint* replace_offset, gint siglen, + const gchar* new_sig); static void update_bsmsg_identity(BalsaSendmsg*, LibBalsaIdentity*); static void sw_size_alloc_cb(GtkWidget * window, GtkAllocation * alloc); @@ -1269,9 +1269,9 @@ change_identity_dialog_cb(GtkAction * action, BalsaSendmsg* bsmsg) /* NOTE: replace_offset and siglen are utf-8 character offsets. */ static void -repl_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, - LibBalsaIdentity* old_ident, gint* replace_offset, - gint siglen, gchar* new_sig) +replace_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, + LibBalsaIdentity* old_ident, gint* replace_offset, + gint siglen, const gchar* new_sig) { gint newsiglen; gboolean reply_type = (bsmsg->type == SEND_REPLY || @@ -1299,8 +1299,9 @@ repl_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, /* check to see if this is a reply or forward and compare identity * settings to determine whether to add signature */ - if ((reply_type && new_ident->sig_whenreply) || - (forward_type && new_ident->sig_whenforward)) { + if (bsmsg->type == SEND_NORMAL || + (reply_type && new_ident->sig_whenreply) || + (forward_type && new_ident->sig_whenforward)) { /* see if sig location is probably going to be the same */ if (new_ident->sig_prepend == old_ident->sig_prepend) { @@ -1315,6 +1316,7 @@ repl_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, /* put it at the end of the message */ gtk_text_buffer_get_end_iter(buffer, &ins); } + printf("Inserting new sig\n"); gtk_text_buffer_place_cursor(buffer, &ins); gtk_text_buffer_insert_at_cursor(buffer, new_sig, -1); } @@ -1549,8 +1551,8 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) if (!old_sig) { replace_offset = bsmsg->ident->sig_prepend ? 0 : g_utf8_strlen(message_text, -1); - repl_identity_signature(bsmsg, ident, old_ident, &replace_offset, - 0, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, &replace_offset, + 0, new_sig); } else { /* split on sig separator */ message_split = g_strsplit(message_text, "\n-- \n", 0); @@ -1561,8 +1563,8 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) if (g_ascii_strncasecmp(old_sig, compare_str, siglen) == 0) { g_free(compare_str); - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen - 1, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen - 1, new_sig); found_sig = TRUE; } else { g_free(compare_str); @@ -1572,8 +1574,9 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) /* try to find occurance of old signature */ if (g_ascii_strncasecmp(old_sig, compare_str, siglen) == 0) { - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen, + new_sig); found_sig = TRUE; } @@ -1596,16 +1599,18 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) if (g_ascii_strncasecmp(old_sig, tmpstr, siglen) == 0) { g_free(tmpstr); - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen - 1, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen - 1, + new_sig); } else { g_free(tmpstr); replace_offset++; compare_str = g_utf8_next_char(compare_str); while (*compare_str) { if (g_ascii_strncasecmp(old_sig, compare_str, siglen) == 0) { - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen, + new_sig); } replace_offset++; compare_str = g_utf8_next_char(compare_str); -- 1.6.0.6 _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Ildar Mulyukov
::
Rate this Message:
On 30.06.2009 23:00:48, Pawel Salek wrote:
> On 06/30/2009 07:41:25 AM, Ildar Mulyukov wrote: >>>> 1. Changing identities in the New message window wipes out the >>>> signature and does not add another sig. Have to insert the >>>> signature by hand. > Confirmed. >>>> 2. In Mailbox properties the "Update" button is disabled. If I >>>> change the Identity, it doesn't get enabled. I believe that it was >>>> not that way. This is for Maildir only. The mbox behaves allright. > Confirmed. >>> 3: Unread mail counter sometimes gets to negative numbers. This is >>> not a regression - it was there for ages. It can be seen for >>> example when you "Hide Unflagged" and some new mail arrives or gets >>> read. Counter algorithms are not good for filtered box situations. > > I don't see that. I did as follows: Ok. Maybe later. Tricky to reproduce. >> True regression: >> 4. *Find in Message* does not work either. > > I do not see that. The search widget is displated and when I type > characters, the current hit gets highlighted as expeted. Can you > please list a step-by-step scenario that exposes the problem? :-) I don't see it now. Funny. Maybe I get back to it later. >> Anyone to react? > > Could you please verify whether the attached patch fixes the problems > 1 and 2? Yes! The patch covers the problems 1 and 2. Thanks. Regards, Ildar -- Ildar Mulyukov, free SW designer/programmer/packager ========================================= email: ildar@... Jabber: ildar@... ICQ: 4334029 ALT Linux Sisyphus http://www.sisyphus.ru ========================================= _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Ildar Mulyukov
::
Rate this Message:
On 01.07.2009 00:57:29, Ildar Mulyukov wrote:
> On 30.06.2009 23:00:48, Pawel Salek wrote: >> Could you please verify whether the attached patch fixes the >> problems 1 and 2? > > Yes! The patch covers the problems 1 and 2. Thanks. ... But still it's not complete. The message where I wrote "Yes! The patch covers the problems 1 and 2. Thanks." particularly suffers from the problem #1. #2 is really OK. -- Ildar Mulyukov, free SW designer/programmer/packager ========================================= email: ildar@... Jabber: ildar@... ICQ: 4334029 ALT Linux Sisyphus http://www.sisyphus.ru ========================================= _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Peter Bloomfield
::
Rate this Message:
On Jun 30, 2009, at 1:41 AM, Ildar Mulyukov wrote:
[ snip ] > True regression: > 4. *Find in Message* does not work either. > > Anyone to react? >-- > Ildar Mulyukov, free SW designer/programmer/packager FWIW: Using rawhide at one point prior to the Fedora 11 release, I found *Find in Message* had become case-sensitive, but it seems to be back to being case-insensitive now. No known changes in the Balsa code! Peter _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Pawel Salek
::
Rate this Message:
On 06/30/2009 09:04:21 PM, Ildar Mulyukov wrote:
> On 01.07.2009 00:57:29, Ildar Mulyukov wrote: >> On 30.06.2009 23:00:48, Pawel Salek wrote: >>> Could you please verify whether the attached patch fixes the >>> problems 1 and 2? >> >> Yes! The patch covers the problems 1 and 2. Thanks. > ... But still it's not complete. The message where I wrote "Yes! The > patch covers the problems 1 and 2. Thanks." particularly suffers from > the problem #1. > #2 is really OK. I guess I will need again a detailed scenario to reproduce it... What I do is: Press 'N' to open the compose window. It gets displayed with my default identity selected that has no signature attached. Next, I select another identity, one that has an associated signature. The signature gets inserted. What do you do differently? Pawel _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Ildar Mulyukov
::
Rate this Message:
On 01.07.2009 01:31:21, Pawel Salek wrote:
> On 06/30/2009 09:04:21 PM, Ildar Mulyukov wrote: >> On 01.07.2009 00:57:29, Ildar Mulyukov wrote: >>> On 30.06.2009 23:00:48, Pawel Salek wrote: >>>> Could you please verify whether the attached patch fixes the >>>> problems 1 and 2? >>> >>> Yes! The patch covers the problems 1 and 2. Thanks. >> ... But still it's not complete. The message where I wrote "Yes! The >> patch covers the problems 1 and 2. Thanks." particularly suffers >> from the problem #1. >> #2 is really OK. > > I guess I will need again a detailed scenario to reproduce it... Yeah, sure. I'm sorry I didn't it yesterday. Just it was too late. Here it is: 1. Take my letter from this thread dated 01.07.2009 00:57:29 GMT+6 and copy it to Drafts. 2. Double-click the copied message. 3. Remove the signature in the end of the letter. 4. Ctrl+G to insert your own. 5. Change ids and see what happens. Hope it would show the problem. Regards, Ildar -- Ildar Mulyukov, free SW designer/programmer/packager ========================================= email: ildar@... Jabber: ildar@... ICQ: 4334029 ALT Linux Sisyphus http://www.sisyphus.ru ========================================= _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Pawel Salek-4
::
Rate this Message:
On 07/01/2009 05:34:54 AM, Ildar Mulyukov wrote:
> On 01.07.2009 01:31:21, Pawel Salek wrote: >> On 06/30/2009 09:04:21 PM, Ildar Mulyukov wrote: >>> On 01.07.2009 00:57:29, Ildar Mulyukov wrote: >>>> On 30.06.2009 23:00:48, Pawel Salek wrote: >>>>> Could you please verify whether the attached patch fixes the >>>>> problems 1 and 2? >>>> >>>> Yes! The patch covers the problems 1 and 2. Thanks. >>> ... But still it's not complete. The message where I wrote "Yes! >>> The patch covers the problems 1 and 2. Thanks." particularly >>> suffers from the problem #1. >>> #2 is really OK. >> >> I guess I will need again a detailed scenario to reproduce it... > > Yeah, sure. I'm sorry I didn't it yesterday. Just it was too late. > Here it is: > 1. Take my letter from this thread dated 01.07.2009 00:57:29 GMT+6 > and copy it to Drafts. > 2. Double-click the copied message. > 3. Remove the signature in the end of the letter. > 4. Ctrl+G to insert your own. > 5. Change ids and see what happens. > > Hope it would show the problem. Yes, it does! The key action here is that one edits the draft. Frankly, I do not know how balsa should really behave. We have a settings controlling automatic signature insertion, signature insertion when editing a reply and when forwarding a message... What should happen when we continue writing a draft? I am leaning towards a solution that if the message contained the signature before switching the identity of the sender, it will have the signature replaced with the signature of the new identity. Would you call it a consistent behaviour? Pawel _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Ildar Mulyukov
::
Rate this Message:
On 03.07.2009 11:19:30, Pawel Salek wrote:
> I am leaning towards a solution that if the message contained the > signature before switching the identity of the sender, it will have > the signature replaced with the signature of the new identity. Would > you call it a consistent behaviour? That's how it was and that's how it should be. IMO. Regards, Ildar -- Ildar Mulyukov, free SW designer/programmer/packager ========================================= email: ildar@... Jabber: ildar@... ICQ: 4334029 ALT Linux Sisyphus http://www.sisyphus.ru ========================================= _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Pawel Salek
::
Rate this Message:
On 07/03/2009 11:00:04 AM, Ildar Mulyukov wrote:
> On 03.07.2009 11:19:30, Pawel Salek wrote: >> I am leaning towards a solution that if the message contained the >> signature before switching the identity of the sender, it will have >> the signature replaced with the signature of the new identity. Would >> you call it a consistent behaviour? > > That's how it was and that's how it should be. IMO. Can you please try the attached patch that replaces the one sent previously? Pawel [signature-2-patch] diff --git a/src/mailbox-conf.c b/src/mailbox-conf.c index 9e108d8..1f8a6e1 100644 --- a/src/mailbox-conf.c +++ b/src/mailbox-conf.c @@ -1095,7 +1095,7 @@ create_local_mailbox_dialog(MailboxConfWindow *mcw) action = mcw->mailbox_type == LIBBALSA_TYPE_MAILBOX_MBOX ? GTK_FILE_CHOOSER_ACTION_SAVE : - GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER; + GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER; dialog = gtk_file_chooser_dialog_new(_("Local Mailbox Configurator"), GTK_WINDOW(balsa_app.main_window), diff --git a/src/sendmsg-window.c b/src/sendmsg-window.c index 9c651ab..0f625df 100644 --- a/src/sendmsg-window.c +++ b/src/sendmsg-window.c @@ -180,11 +180,11 @@ static void edit_with_gnome(GtkAction * action, BalsaSendmsg* bsmsg); #endif static void change_identity_dialog_cb(GtkAction * action, BalsaSendmsg * bsmsg); -static void repl_identity_signature(BalsaSendmsg* bsmsg, - LibBalsaIdentity* new_ident, - LibBalsaIdentity* old_ident, - gint* replace_offset, gint siglen, - gchar* new_sig); +static void replace_identity_signature(BalsaSendmsg* bsmsg, + LibBalsaIdentity* new_ident, + LibBalsaIdentity* old_ident, + gint* replace_offset, gint siglen, + const gchar* new_sig); static void update_bsmsg_identity(BalsaSendmsg*, LibBalsaIdentity*); static void sw_size_alloc_cb(GtkWidget * window, GtkAllocation * alloc); @@ -1269,9 +1269,9 @@ change_identity_dialog_cb(GtkAction * action, BalsaSendmsg* bsmsg) /* NOTE: replace_offset and siglen are utf-8 character offsets. */ static void -repl_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, - LibBalsaIdentity* old_ident, gint* replace_offset, - gint siglen, gchar* new_sig) +replace_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, + LibBalsaIdentity* old_ident, gint* replace_offset, + gint siglen, const gchar* new_sig) { gint newsiglen; gboolean reply_type = (bsmsg->type == SEND_REPLY || @@ -1298,9 +1298,13 @@ repl_identity_signature(BalsaSendmsg* bsmsg, LibBalsaIdentity* new_ident, newsiglen = strlen(new_sig); /* check to see if this is a reply or forward and compare identity - * settings to determine whether to add signature */ - if ((reply_type && new_ident->sig_whenreply) || - (forward_type && new_ident->sig_whenforward)) { + * settings to determine whether to add signature. We always add a + * new signature when continuing a message, or when composing a + * new one. */ + if ( (bsmsg->type == SEND_NORMAL && new_ident->sig_sending) || + (reply_type && new_ident->sig_whenreply) || + (forward_type && new_ident->sig_whenforward) || + bsmsg->type == SEND_CONTINUE ) { /* see if sig location is probably going to be the same */ if (new_ident->sig_prepend == old_ident->sig_prepend) { @@ -1549,8 +1553,8 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) if (!old_sig) { replace_offset = bsmsg->ident->sig_prepend ? 0 : g_utf8_strlen(message_text, -1); - repl_identity_signature(bsmsg, ident, old_ident, &replace_offset, - 0, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, &replace_offset, + 0, new_sig); } else { /* split on sig separator */ message_split = g_strsplit(message_text, "\n-- \n", 0); @@ -1561,8 +1565,8 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) if (g_ascii_strncasecmp(old_sig, compare_str, siglen) == 0) { g_free(compare_str); - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen - 1, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen - 1, new_sig); found_sig = TRUE; } else { g_free(compare_str); @@ -1572,8 +1576,9 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) /* try to find occurance of old signature */ if (g_ascii_strncasecmp(old_sig, compare_str, siglen) == 0) { - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen, + new_sig); found_sig = TRUE; } @@ -1596,16 +1601,18 @@ update_bsmsg_identity(BalsaSendmsg* bsmsg, LibBalsaIdentity* ident) if (g_ascii_strncasecmp(old_sig, tmpstr, siglen) == 0) { g_free(tmpstr); - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen - 1, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen - 1, + new_sig); } else { g_free(tmpstr); replace_offset++; compare_str = g_utf8_next_char(compare_str); while (*compare_str) { if (g_ascii_strncasecmp(old_sig, compare_str, siglen) == 0) { - repl_identity_signature(bsmsg, ident, old_ident, - &replace_offset, siglen, new_sig); + replace_identity_signature(bsmsg, ident, old_ident, + &replace_offset, siglen, + new_sig); } replace_offset++; compare_str = g_utf8_next_char(compare_str); _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Ildar Mulyukov
::
Rate this Message:
On 30.06.2009 23:39:54, Pawel Salek wrote:
> On 06/30/2009 07:41:25 AM, Ildar Mulyukov wrote: >>>> 2. In Mailbox properties the "Update" button is disabled. If I >>>> change the Identity, it doesn't get enabled. I believe that it was >>>> not that way. This is for Maildir only. The mbox behaves allright. > Confirmed. Dear Pawel, the patch you sent indeed works. But I don't see it in GIT. Could you revise and push it? Thanks. Best regards, Ildar P.S. as a clue, it was - GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER; + GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER; -- Ildar Mulyukov, free SW designer/programmer/packager ========================================= email: ildar@... Jabber: ildar@... ICQ: 4334029 ALT Linux Sisyphus http://www.sisyphus.ru ========================================= _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Peter Bloomfield
::
Rate this Message:
Hi Ildar:
On 09/09/2009 09:22:52 AM Wed, Ildar Mulyukov wrote: > On 30.06.2009 23:39:54, Pawel Salek wrote: >> On 06/30/2009 07:41:25 AM, Ildar Mulyukov wrote: >>>>> 2. In Mailbox properties the "Update" button is disabled. If I >>>>> change the Identity, it doesn't get enabled. I believe that it was >>>>> not that way. This is for Maildir only. The mbox behaves allright. >> Confirmed. > > Dear Pawel, > > the patch you sent indeed works. But I don't see it in GIT. Could you > revise and push it? Thanks. > Best regards, Ildar > P.S. as a clue, it was > - GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER; > + GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER; I don't think that's the right patch--after applying it, I can't create a new maildir box. We should probably just be more careful in managing the sensitivity of the button--I'll look into it. Peter _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Peter Bloomfield
::
Rate this Message:
On 09/10/2009 05:51:33 PM Thu, Peter Bloomfield wrote:
> Hi Ildar: > > On 09/09/2009 09:22:52 AM Wed, Ildar Mulyukov wrote: >> On 30.06.2009 23:39:54, Pawel Salek wrote: >>> On 06/30/2009 07:41:25 AM, Ildar Mulyukov wrote: >>>>>> 2. In Mailbox properties the "Update" button is disabled. If I >>>>>> change the Identity, it doesn't get enabled. I believe that it was >>>>>> not that way. This is for Maildir only. The mbox behaves allright. >>> Confirmed. >> >> Dear Pawel, >> >> the patch you sent indeed works. But I don't see it in GIT. Could you >> revise and push it? Thanks. >> Best regards, Ildar >> P.S. as a clue, it was >> - GTK_FILE_CHOOSER_ACTION_CREATE_FOLDER; >> + GTK_FILE_CHOOSER_ACTION_SELECT_FOLDER; > > Pawel has been busy with his real life, so I'll take this up. > > I don't think that's the right patch--after applying it, I can't create > a new maildir box. We should probably just be more careful in managing > the sensitivity of the button--I'll look into it. I've pushed a patch that sets the "Update" button sensitive when the identity is changed, and when any of the other three options on the properties dialog is changed. Does that work? Peter _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
|
|
Re: some regressions in current HEAD
by Ildar Mulyukov
::
Rate this Message:
On 11.09.2009 07:27:51, Peter Bloomfield wrote:
> I've pushed a patch that sets the "Update" button sensitive when the > identity is changed, and when any of the other three options on the > properties dialog is changed. Does that work? confirm thank you -- Ildar Mulyukov, free SW designer/programmer/packager ========================================= email: ildar@... Jabber: ildar@... ICQ: 4334029 ALT Linux Sisyphus http://www.sisyphus.ru ========================================= _______________________________________________ balsa-list mailing list balsa-list@... http://mail.gnome.org/mailman/listinfo/balsa-list |
attachment0 (197 bytes) | Free embeddable forum powered by Nabble | Forum Help |
