surf.m overwrites "facecolor" property

[Michael Goffioul-2]

Hi,

Why does surf.m overwrite "facecolor" property of the generated surface?
This property should be "flat" by default for surface object. Setting it
explicitely makes it impossible to call surf like:

surf(peaks, "facecolor", "r");

Michael.

[David Bateman]

Michael Goffioul wrote:

> Hi,
>
> Why does surf.m overwrite "facecolor" property of the generated surface?
> This property should be "flat" by default for surface object. Setting it
> explicitely makes it impossible to call surf like:
>
> surf(peaks, "facecolor", "r");
>
> Michael.
>
>  

I see no reason not to do that as "flat" is already the default for the

surfaces.. However, the gnuplot code doesn't respect facecolors other
than "flat" at the moment. As I noted in

http://www.nabble.com/Re%3A-anything-else-for-2.9.18--p14169305.html

its one of the issues I'm looking at. John please consider the attached
patch..

D.

--
David Bateman                                David.Bateman@...
Motorola Labs - Paris                        [phone] (Ph)
Parc Les Algorithmes, Commune de St Aubin    [phone] (Mob)
91193 Gif-Sur-Yvette FRANCE                  [phone] (Fax)

The information contained in this communication has been classified as:

[x] General Business Information
[ ] Motorola Internal Use Only
[ ] Motorola Confidential Proprietary


*** ./scripts/plot/surf.m.orig3 2007-12-07 17:04:07.713180166 +0100
--- ./scripts/plot/surf.m 2007-12-07 17:01:04.325474414 +0100
***************
*** 39,45 ****
      newplot ();
      tmp = surface (varargin{:});
 
-     set (tmp, "facecolor", "flat");
      if (! ishold ())
        set (h, "view", [-37.5, 30]);
      endif
--- 39,44 ----

[John W. Eaton]

On  7-Dec-2007, David Bateman wrote:

| Michael Goffioul wrote:
| > Hi,
| >
| > Why does surf.m overwrite "facecolor" property of the generated surface?
| > This property should be "flat" by default for surface object. Setting it
| > explicitely makes it impossible to call surf like:
| >
| > surf(peaks, "facecolor", "r");
| >
| > Michael.
| >
| >  
| I see no reason not to do that as "flat" is already the default for the
| surfaces.. However, the gnuplot code doesn't respect facecolors other
| than "flat" at the moment. As I noted in
|
| http://www.nabble.com/Re%3A-anything-else-for-2.9.18--p14169305.html
|
| its one of the issues I'm looking at. John please consider the attached
| patch..

I made this change.

Thanks,

jwe

[John W. Eaton]

On  6-Dec-2007, Michael Goffioul wrote:

| Why does surf.m overwrite "facecolor" property of the generated surface?
| This property should be "flat" by default for surface object. Setting it
| explicitely makes it impossible to call surf like:
|
| surf(peaks, "facecolor", "r");

Removing the

  "facecolor", "flat"

args from the call to __go_surface__ in surface.m doesn't seem to be
enough to make your example work properly.  I could use some help here
as I don't fully understand the way surface plotting is supposed to
work.

Thanks,

jwe

[John W. Eaton]

On 10-Dec-2007, John W. Eaton wrote:

| On  6-Dec-2007, Michael Goffioul wrote:
|
| | Why does surf.m overwrite "facecolor" property of the generated surface?
| | This property should be "flat" by default for surface object. Setting it
| | explicitely makes it impossible to call surf like:
| |
| | surf(peaks, "facecolor", "r");
|
| Removing the
|
|   "facecolor", "flat"
|
| args from the call to __go_surface__ in surface.m doesn't seem to be
| enough to make your example work properly.  I could use some help here
| as I don't fully understand the way surface plotting is supposed to
| work.

Oh, now I see this message:

  https://www.cae.wisc.edu/pipermail/octave-maintainers/2007-December/005189.html

which is I think related.  If fixing this is difficult, then I'd say
we skip it for 3.0.

jwe

[dbateman]

John W. Eaton wrote:

On 10-Dec-2007, John W. Eaton wrote:

| On  6-Dec-2007, Michael Goffioul wrote:
|
| | Why does surf.m overwrite "facecolor" property of the generated surface?
| | This property should be "flat" by default for surface object. Setting it
| | explicitely makes it impossible to call surf like:
| |
| | surf(peaks, "facecolor", "r");
|
| Removing the
|
|   "facecolor", "flat"
|
| args from the call to __go_surface__ in surface.m doesn't seem to be
| enough to make your example work properly.  I could use some help here
| as I don't fully understand the way surface plotting is supposed to
| work.

Oh, now I see this message:

  https://www.cae.wisc.edu/pipermail/octave-maintainers/2007-December/005189.html

which is I think related.  If fixing this is difficult, then I'd say
we skip it for 3.0.

jwe

I think we should forget it for 3.0. It on my list of things to fix..

D.

[Michael Goffioul-2]

On 12/11/07, John W. Eaton <jwe@...> wrote:

> On  6-Dec-2007, Michael Goffioul wrote:
>
> | Why does surf.m overwrite "facecolor" property of the generated surface?
> | This property should be "flat" by default for surface object. Setting it
> | explicitely makes it impossible to call surf like:
> |
> | surf(peaks, "facecolor", "r");
>
> Removing the
>
>  "facecolor", "flat"
>
> args from the call to __go_surface__ in surface.m doesn't seem to be
> enough to make your example work properly.

It is for JHandles, but there are gnuplot-specific problems with
coloring surface.

Michael.

[John W. Eaton]

On 11-Dec-2007, Michael Goffioul wrote:

| On 12/11/07, John W. Eaton <jwe@...> wrote:
| > On  6-Dec-2007, Michael Goffioul wrote:
| >
| > | Why does surf.m overwrite "facecolor" property of the generated surface?
| > | This property should be "flat" by default for surface object. Setting it
| > | explicitely makes it impossible to call surf like:
| > |
| > | surf(peaks, "facecolor", "r");
| >
| > Removing the
| >
| >  "facecolor", "flat"
| >
| > args from the call to __go_surface__ in surface.m doesn't seem to be
| > enough to make your example work properly.
|
| It is for JHandles, but there are gnuplot-specific problems with
| coloring surface.

Since the default seems to be "flat" anyway, I removed the facecolor
property/value pair from the __go_surface__ call.

Thanks,

jwe