svn+ssh -- Killed by signal 15.

[Mike-85]

Hi,

I've recently upgraded Subversion from 1.6.0 to 1.6.6 and suddenly the
old bug appeared
again - whenever I access repository through svn+ssh:// I get "Killed
by signal 15." message
on stderr. Just in case I've compiled and tested versions 1.5.7-1.6.6
and trunk. The result is that
versions 1.5.7-1.6.4 produce no such a message but others do produce
it. I've tried to access
repositories on both Linux (svn-1.6.5) and Solaris (svn-1.4.2) with
the same result.

Any advise on should I reopen the issue
http://subversion.tigris.org/issues/show_bug.cgi?id=2580
or this behavior is expected?

Regards,
Mikhail

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2414982

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Stefan Sperling-7]

On Thu, Nov 05, 2009 at 10:57:58PM -0500, Mikhail Terekhov wrote:

> Hi,
>
> I've recently upgraded Subversion from 1.6.0 to 1.6.6 and suddenly the
> old bug appeared
> again - whenever I access repository through svn+ssh:// I get "Killed
> by signal 15." message
> on stderr. Just in case I've compiled and tested versions 1.5.7-1.6.6
> and trunk. The result is that
> versions 1.5.7-1.6.4 produce no such a message but others do produce
> it. I've tried to access
> repositories on both Linux (svn-1.6.5) and Solaris (svn-1.4.2) with
> the same result.
>
> Any advise on should I reopen the issue
> http://subversion.tigris.org/issues/show_bug.cgi?id=2580

Please do not reopen. The message you are seeing is printed by ssh
as a result of the fix for issue #2580.

> or this behavior is expected?

This is expected. You need to add -q to the ssh command invoked by
svn, which happens by default as of 1.6.6.

Put this in ~/.subversion/config:

  ssh = $SVN_SSH ssh -q

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2415053

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Mike-85]

On Fri, Nov 6, 2009 at 5:30 AM, Stefan Sperling <stsp@...> wrote:

> On Thu, Nov 05, 2009 at 10:57:58PM -0500, Mikhail Terekhov wrote:
>> Hi,
>
> Please do not reopen. The message you are seeing is printed by ssh
> as a result of the fix for issue #2580.
>
>> or this behavior is expected?
>
> This is expected. You need to add -q to the ssh command invoked by
> svn, which happens by default as of 1.6.6.
>
> Put this in ~/.subversion/config:
>
>  ssh = $SVN_SSH ssh -q
>

Thanks for the clarification. This fixed the problem.

May be it is a good idea to use this switch by default, mention it in the
config file and somewhere in documentation as well.

Regards,
--
Mikhail Terekhov

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2415111

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Stefan Sperling-7]

On Fri, Nov 06, 2009 at 10:02:08AM -0500, Mikhail Terekhov wrote:

> On Fri, Nov 6, 2009 at 5:30 AM, Stefan Sperling <stsp@...> wrote:
> > On Thu, Nov 05, 2009 at 10:57:58PM -0500, Mikhail Terekhov wrote:
> >> Hi,
> >
> > Please do not reopen. The message you are seeing is printed by ssh
> > as a result of the fix for issue #2580.
> >
> >> or this behavior is expected?
> >
> > This is expected. You need to add -q to the ssh command invoked by
> > svn, which happens by default as of 1.6.6.

Correction: As of 1.6.5.

> >
> > Put this in ~/.subversion/config:
> >
> >  ssh = $SVN_SSH ssh -q
> >
>
> Thanks for the clarification. This fixed the problem.
>
> May be it is a good idea to use this switch by default, mention it in the
> config file and somewhere in documentation as well.

Create a fresh config file template using 1.6.5 and you'll see that
we've done just that.

  $ svn --config-dir /tmp/svn-conf help >/dev/null
  $ grep 'ssh =' /tmp/svn-conf/config
  # ssh = $SVN_SSH ssh -q

Of course, if you've created your config file template with a client
older than 1.6.5, you won't see -q in there.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2415134

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Mike-85]

On Fri, Nov 6, 2009 at 11:04 AM, Stefan Sperling <stsp@...> wrote:
>  $ svn --config-dir /tmp/svn-conf help >/dev/null
>  $ grep 'ssh =' /tmp/svn-conf/config
>  # ssh = $SVN_SSH ssh -q
>
> Of course, if you've created your config file template with a client
> older than 1.6.5, you won't see -q in there.

Yes that explains it. But this line is just a comment i.e. it is not used
as a default still. Does this mean that there are cases when '-q' is not
needed? May be I need to tune/configure my ssh/sshd somehow?
If there is no such cases then probably '-q' should be just used by default.

Regards,
--
Mikhail Terekhov

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2415145

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Stefan Sperling-7]

On Fri, Nov 06, 2009 at 11:53:09AM -0500, Mikhail Terekhov wrote:

> On Fri, Nov 6, 2009 at 11:04 AM, Stefan Sperling <stsp@...> wrote:
> >  $ svn --config-dir /tmp/svn-conf help >/dev/null
> >  $ grep 'ssh =' /tmp/svn-conf/config
> >  # ssh = $SVN_SSH ssh -q
> >
> > Of course, if you've created your config file template with a client
> > older than 1.6.5, you won't see -q in there.
>
> Yes that explains it. But this line is just a comment i.e. it is not used
> as a default still. Does this mean that there are cases when '-q' is not
> needed? May be I need to tune/configure my ssh/sshd somehow?
> If there is no such cases then probably '-q' should be just used by default.

'-q' is passed by default, unless you override it in your config.

See the code in subversion/libsvn_ra_svn/client.c:

  /* We have one predefined tunnel scheme, if it isn't overridden by config. */
  if (!val && strcmp(tunnel, "ssh") == 0)
    {
      /* Killing the tunnel agent with SIGTERM leads to unsightly
       * stderr output from ssh, unless we pass -q.
       * The "-q" option to ssh is widely supported: all versions of
       * OpenSSH have it, the old ssh-1.x and the 2.x, 3.x ssh.com
       * versions have it too. If the user is using some other ssh
       * implementation that doesn't accept it, they can override it
       * in the [tunnels] section of the config. */
      val = "$SVN_SSH ssh -q";
    }

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2415181

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].

[Mike-85]

On Fri, Nov 6, 2009 at 1:32 PM, Stefan Sperling <stsp@...> wrote:

> '-q' is passed by default, unless you override it in your config.
>
> See the code in subversion/libsvn_ra_svn/client.c:
>
>  /* We have one predefined tunnel scheme, if it isn't overridden by config. */
>  if (!val && strcmp(tunnel, "ssh") == 0)
>    {
>      /* Killing the tunnel agent with SIGTERM leads to unsightly
>       * stderr output from ssh, unless we pass -q.
>       * The "-q" option to ssh is widely supported: all versions of
>       * OpenSSH have it, the old ssh-1.x and the 2.x, 3.x ssh.com
>       * versions have it too. If the user is using some other ssh
>       * implementation that doesn't accept it, they can override it
>       * in the [tunnels] section of the config. */
>      val = "$SVN_SSH ssh -q";
>    }

Ok, I think I understand it now. Thanks for the very detailed and
patient explanation.

Regards,
--
Mikhail Terekhov

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=1065&dsMessageId=2415194

To unsubscribe from this discussion, e-mail: [users-unsubscribe@...].