svn commit: r831181 - in /tapestry/tapestry4/trunk/tapestry-framework/src: java/org/apache/tapestry/components/ java/org/apache/tapestry/form/ test/org/apache/tapestry/form/

View: New views

1 Messages — Rating Filter: Alert me

svn commit: r831181 - in /tapestry/tapestry4/trunk/tapestry-framework/src: java/org/apache/tapestry/components/ java/org/apache/tapestry/form/ test/org/apache/tapestry/form/

by andyhot-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Author: andyhot
Date: Fri Oct 30 01:28:29 2009
New Revision: 831181

URL: http://svn.apache.org/viewvc?rev=831181&view=rev
Log:
TAPESTRY-2747: Lowercase onClick (and friends) attribute rendered by LinkSubmit & AbstractSubmit

Modified:
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/components/LinkEventType.java
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/AbstractSubmit.java
tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/LinkSubmit.java
tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/LinkSubmitTest.java
tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestSubmit.java

Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/components/LinkEventType.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/components/LinkEventType.java?rev=831181&r1=831180&r2=831181&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/components/LinkEventType.java (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/components/LinkEventType.java Fri Oct 30 01:28:29 2009
@@ -27,13 +27,13 @@
* Type for <code>onMouseOver</code>. This may also be called "focus".
*/

- public static final LinkEventType MOUSE_OVER = new LinkEventType("MOUSE_OVER", "onMouseOver");
+ public static final LinkEventType MOUSE_OVER = new LinkEventType("MOUSE_OVER", "onmouseover");

/**
* Type for <code>onMouseOut</code>. This may also be called "blur".
*/

- public static final LinkEventType MOUSE_OUT = new LinkEventType("MOUSE_OUT", "onMouseOut");
+ public static final LinkEventType MOUSE_OUT = new LinkEventType("MOUSE_OUT", "onmouseout");

/**
* Type for <code>onClick</code>.
@@ -41,7 +41,7 @@
* @since 1.0.1
*/

- public static final LinkEventType CLICK = new LinkEventType("CLICK", "onClick");
+ public static final LinkEventType CLICK = new LinkEventType("CLICK", "onclick");

/**
* Type for <code>onDblClick</code>.
@@ -49,7 +49,7 @@
* @since 1.0.1
*/

- public static final LinkEventType DOUBLE_CLICK = new LinkEventType("DOUBLE_CLICK", "onDblClick");
+ public static final LinkEventType DOUBLE_CLICK = new LinkEventType("DOUBLE_CLICK", "ondblclick");

/**
* Type for <code>onMouseDown</code>.
@@ -57,7 +57,7 @@
* @since 1.0.1.
*/

- public static final LinkEventType MOUSE_DOWN = new LinkEventType("MOUSE_DOWN", "onMouseDown");
+ public static final LinkEventType MOUSE_DOWN = new LinkEventType("MOUSE_DOWN", "onmousedown");

/**
* Type for <code>onMouseUp</code>.
@@ -65,7 +65,7 @@
* @since 1.0.1
*/

- public static final LinkEventType MOUSE_UP = new LinkEventType("MOUSE_UP", "onMouseUp");
+ public static final LinkEventType MOUSE_UP = new LinkEventType("MOUSE_UP", "onmouseup");

private final String _name;

Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/AbstractSubmit.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/AbstractSubmit.java?rev=831181&r1=831180&r2=831181&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/AbstractSubmit.java (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/AbstractSubmit.java Fri Oct 30 01:28:29 2009
@@ -167,7 +167,7 @@

str.append(")");

- writer.attribute("onClick", str.toString());
+ writer.attribute("onclick", str.toString());
return;
}

Modified: tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/LinkSubmit.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/LinkSubmit.java?rev=831181&r1=831180&r2=831181&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/LinkSubmit.java (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/java/org/apache/tapestry/form/LinkSubmit.java Fri Oct 30 01:28:29 2009
@@ -86,7 +86,7 @@
json.put(new JSONLiteral("url"), new JSONLiteral("this.href"));

writer.attribute("href", getDirectService().getLink(true, dsp).getURL());
- writer.attribute("onClick", js + "," + json.toString() + "); return false;");
+ writer.attribute("onclick", js + "," + json.toString() + "); return false;");
}
else
{

Modified: tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/LinkSubmitTest.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/LinkSubmitTest.java?rev=831181&r1=831180&r2=831181&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/LinkSubmitTest.java (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/LinkSubmitTest.java Fri Oct 30 01:28:29 2009
@@ -148,7 +148,7 @@
verify();

assertBuffer("<a href=\"http://submit\" " +
- "onClick=\"tapestry.form.submit('form', 'submitMe'," +
+ "onclick=\"tapestry.form.submit('form', 'submitMe'," +
"{async:true,json:false,url:this.href}); return false;\" id=\"submitMe\">BODY</a>");
}

Modified: tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestSubmit.java
URL: http://svn.apache.org/viewvc/tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestSubmit.java?rev=831181&r1=831180&r2=831181&view=diff
==============================================================================
--- tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestSubmit.java (original)
+++ tapestry/tapestry4/trunk/tapestry-framework/src/test/org/apache/tapestry/form/TestSubmit.java Fri Oct 30 01:28:29 2009
@@ -278,7 +278,7 @@

expect(form.getClientId()).andReturn("formtest");

- writer.attribute("onClick", "tapestry.form.cancel('formtest','fred')");
+ writer.attribute("onclick", "tapestry.form.cancel('formtest','fred')");

writer.closeTag();