svn-commits-list size limit opens a possibility to hide commits

View: New views
2 Messages — Rating Filter:   Alert me  

svn-commits-list size limit opens a possibility to hide commits

by Christian Persch :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi;

it's happened to me a few times that the autogenerated mail from a svn
commit to the svn-commits-list exceeded that list's mail size limit
(500KiB). In that case the comitter gets a moderator mail, with a link
to click to cancel the mail. This is obviously bad, in that it allows a
comitter to cancel the notification mail about his commit, effectively
hiding his commit!
IMHO, in case the commit mail exceeds the size limit (which the script
that's generating the mail can check), a diff-less replacement mail must
instead be generated (with the usual link to the viewsvn to view the
diffs), so that in all cases the svn-commits-list has a record of the
commit.

Regards,
        Christian

_______________________________________________
Gnome-infrastructure mailing list
Gnome-infrastructure@...
http://mail.gnome.org/mailman/listinfo/gnome-infrastructure

Re: svn-commits-list size limit opens a possibility to hide commits

by Olav Vitters :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Fri, Mar 21, 2008 at 01:18:30PM +0100, Christian Persch wrote:
> IMHO, in case the commit mail exceeds the size limit (which the script
> that's generating the mail can check), a diff-less replacement mail must
> instead be generated (with the usual link to the viewsvn to view the
> diffs), so that in all cases the svn-commits-list has a record of the
> commit.

I planned to do this after Subversion reviewed my existing patches. But
ehr, they never do.

I've emailed 5 patches now.. none got a proper review.
--
Regards,
Olav
_______________________________________________
Gnome-infrastructure mailing list
Gnome-infrastructure@...
http://mail.gnome.org/mailman/listinfo/gnome-infrastructure