sw-accept-reject-redline.diff looks obsolete

View: New views
2 Messages — Rating Filter:   Alert me  

sw-accept-reject-redline.diff looks obsolete

by Andras Timar :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi,

The patch  sw-accept-reject-redline.diff looks obsolete. In upstream OOo
3.1 a very similar feature were added.
See: http://development.openoffice.org/releases/3.1.0.html
Accept/Reject Change in context menu   i6191

Now we have duplicated menu entries in Go-OO! redlines context menu.

Regards,
Andras
_______________________________________________
Dev mailing list
Dev@...
http://lists.go-oo.org/listinfo.cgi/dev-go-oo.org

Re: sw-accept-reject-redline.diff looks obsolete

by Petr Mladek :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On Saturday 23 May 2009, Andras Timar wrote:
> Hi,
>
> The patch  sw-accept-reject-redline.diff looks obsolete. In upstream OOo
> 3.1 a very similar feature were added.
> See: http://development.openoffice.org/releases/3.1.0.html
> Accept/Reject Change in context menu   i6191
>
> Now we have duplicated menu entries in Go-OO! redlines context menu.

Great catch! I have just removed the diff.

Our patch added also the "Record" context menu entry. It was easy to rework
the diff to keep it but I decided to remove it as well. I think that it was
controversal. It should be needed just once for each document => it needed
not be in the context menu. It was not requested by the bug reporters...


--
Best Regards,

Petr Mladek
software developer
---------------------------------------------------------------------  
SUSE LINUX, s. r. o.                        e-mail: pmladek@...
Lihovarská 1060/12                          tel: +420 284 028 952
190 00 Prague 9                             fax: +420 284 028 951
Czech Republic                              http://www.suse.cz/
_______________________________________________
Dev mailing list
Dev@...
http://lists.go-oo.org/listinfo.cgi/dev-go-oo.org