test failure 216: Substitute and define special characters

View: New views
2 Messages — Rating Filter:   Alert me  

test failure 216: Substitute and define special characters

by Ralf Wildenhues :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

AIX 4.3.3 and IRIX 6.5 fail this test, both similarly:

#                             -*- compilation -*-
216. torture.at:801: testing ...
../../autoconf/tests/torture.at:865: autoconf --force
../../autoconf/tests/torture.at:866: autoheader
[...]
../../autoconf/tests/torture.at:884: sed '/#/!d
/INTTYPES/d
/MEMORY/d
/PACKAGE_/d
/STDC_HEADERS/d
/STDINT/d
/STDLIB/d
/STRING/d
/SYS_STAT/d
/SYS_TYPES/d
/UNISTD/d' config.h
--- Standard Input      Sat Oct 31 02:55:27 2009
+++ /home/rwild/ac/build-mips-sgi-irix6.5/tests/testsuite.dir/at-groups/216/stdout      Sat Oct 31 02:55:27 2009
@@ -8,5 +8,5 @@
 #define unq4 set
 #define unq5 "a b"
 #define unq6 hi
-#define unq7 '\"'
+#define unq7 '"'


This is the portability issue described in the `Here-Documents' node of
the manual.  Fixed with below, OK to push?

Thanks,
Ralf

commit 7bd8f11d67ef73120dabd8aa0e068155cf34498d
Author: Ralf Wildenhues <Ralf.Wildenhues@...>
Date:   Sat Oct 31 17:04:38 2009 +0100

    Fix testsuite failure on IRIX and AIX.
   
    * tests/torture.at (Substitute and define special characters):
    Double the backslash before the double-quote in
    AC_DEFINE_UNQUOTED, as documented for here-documents.
   
    Signed-off-by: Ralf Wildenhues <Ralf.Wildenhues@...>

diff --git a/ChangeLog b/ChangeLog
index e29e53b..27b0992 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2009-10-31  Ralf Wildenhues  <Ralf.Wildenhues@...>
 
+ Fix testsuite failure on IRIX and AIX.
+ * tests/torture.at (Substitute and define special characters):
+ Double the backslash before the double-quote in
+ AC_DEFINE_UNQUOTED, as documented for here-documents.
+
  Fix testsuite failures with SHELL=zsh.
  * tests/statesave.m4 (AC_STATE_SAVE): Ignore argv and ARGC when
  comparing configure variables.
diff --git a/tests/torture.at b/tests/torture.at
index b2fc7c3..8f22013 100644
--- a/tests/torture.at
+++ b/tests/torture.at
@@ -858,7 +858,7 @@ AC_DEFINE_UNQUOTED([unq3], ["$baz"], [unquoted, test 3])
 AC_DEFINE_UNQUOTED([unq4], [${baz+set}], [unquoted, test 4])
 AC_DEFINE_UNQUOTED([unq5], ["${baz+`echo "a b"`}"], [unquoted, test 5])
 AC_DEFINE_UNQUOTED([unq6], [`echo hi`], [unquoted, test 6])
-AC_DEFINE_UNQUOTED([unq7], ['\"'], [unquoted, test 7])
+AC_DEFINE_UNQUOTED([unq7], ['\\"'], [unquoted, test 7])
 AC_PROG_AWK
 AC_CONFIG_FILES([Foo Zardoz])]])
 



Re: test failure 216: Substitute and define special characters

by Paolo Bonzini-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

On 10/31/2009 05:06 PM, Ralf Wildenhues wrote:
> This is the portability issue described in the `Here-Documents' node of
> the manual.  Fixed with below, OK to push?

Makes sense.  Thanks!

Paolo