threads2

View: New views
6 Messages — Rating Filter:   Alert me  

threads2

by Sam Steingold :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Vladimir,
I finished the merge.
the current tree is tagged [post-threads-merge].
please add files to your [threads1] branch.

I have two requests:

1. Please fix these warnings:

In file included from ../src/spvw.d:976:
../src/spvw_garcol.d: In function 'gar_col_normal':
../src/spvw_garcol.d:1997: warning: passing argument 7 of
'gc_sweep1_varobject_page' from incompatible pointer type
In file included from ../src/spvw.d:990:
../src/spvw_circ.d: In function 'mlb_add':
../src/spvw_circ.d:342: warning: large integer implicitly truncated to unsigned
type

the first one comes from holes_count being uintC and gc_sweep1_varobject_page
expencting an aint*.
I am not sure about the second one.

2. spinlocks for amd64 are not implemented, mutexes are used instead. build
fails with
...
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
[../src/xthread.d:628]
...

it would be nice if spinlocks were supported on amd64 too.

thanks

happy hacking

S.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
clisp-devel mailing list
clisp-devel@...
https://lists.sourceforge.net/lists/listinfo/clisp-devel

Re: threads2

by Vladimir Tzankov :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Oct 29, 2008, at 5:32 PM, Sam Steingold wrote:
> Vladimir,
> I finished the merge.
> the current tree is tagged [post-threads-merge].
> please add files to your [threads1] branch.

There is no [threads1] branch in the CVS.
I see the CVSROOT change:
-avail | vtz | clisp | threads
+avail | vtz | clisp | threads1
but when I try to make the initial checkout:
cvs -z3 -d:ext:vtz@...:/cvsroot/clisp co -P -r  
threads1 clisp
I get:
cvs [checkout aborted]: no such tag threads1

> I have two requests:
>
> 1. Please fix these warnings:
>
> In file included from ../src/spvw.d:976:
> ../src/spvw_garcol.d: In function 'gar_col_normal':
> ../src/spvw_garcol.d:1997: warning: passing argument 7 of  
> 'gc_sweep1_varobject_page' from incompatible pointer type
> In file included from ../src/spvw.d:990:
> ../src/spvw_circ.d: In function 'mlb_add':
> ../src/spvw_circ.d:342: warning: large integer implicitly truncated  
> to unsigned type
>
> the first one comes from holes_count being uintC and  
> gc_sweep1_varobject_page expencting an aint*.
> I am not sure about the second one.

ok

> 2. spinlocks for amd64 are not implemented, mutexes are used  
> instead. build fails with
> ...
> [../src/xthread.d:628]
fixed. these were not tested for a quite long time.

> it would be nice if spinlocks were supported on amd64 too.

sure.

Vladimir

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
clisp-devel mailing list
clisp-devel@...
https://lists.sourceforge.net/lists/listinfo/clisp-devel

Re: threads2

by Sam Steingold :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Vladimir Tzankov wrote:

>
> There is no [threads1] branch in the CVS.
> I see the CVSROOT change:
> -avail | vtz | clisp | threads
> +avail | vtz | clisp | threads1
> but when I try to make the initial checkout:
> cvs -z3 -d:ext:vtz@...:/cvsroot/clisp co -P -r  
> threads1 clisp
> I get:
> cvs [checkout aborted]: no such tag threads1

please try again.
I put ChangeLog and multithread.txt there myself - as a reminder that you have
to keep good docs of your work. ;-)
You can add the files you need there yourself.

Thanks
Sam.


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
clisp-devel mailing list
clisp-devel@...
https://lists.sourceforge.net/lists/listinfo/clisp-devel

Re: threads2

by Vladimir Tzankov :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Oct 29, 2008, at 6:25 PM, Sam Steingold wrote:

> Vladimir Tzankov wrote:
>> There is no [threads1] branch in the CVS.
>> I see the CVSROOT change:
>> -avail | vtz | clisp | threads
>> +avail | vtz | clisp | threads1
>> but when I try to make the initial checkout:
>> cvs -z3 -d:ext:vtz@...:/cvsroot/clisp co -P -
>> r  threads1 clisp
>> I get:
>> cvs [checkout aborted]: no such tag threads1
>
> please try again.
> I put ChangeLog and multithread.txt there myself - as a reminder  
> that you have to keep good docs of your work. ;-)
> You can add the files you need there yourself.
>

Thanks.



-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
clisp-devel mailing list
clisp-devel@...
https://lists.sourceforge.net/lists/listinfo/clisp-devel

Re: threads2

by Vladimir Tzankov :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Sam,
On Oct 29, 2008, at 5:32 PM, Sam Steingold wrote:
>
> 2. spinlocks for amd64 are not implemented, mutexes are used  
> instead. build fails with
> ...
> [../src/xthread.d:628]
>

Just fixed it and committed to threads1 branch.
What OS you are using? Do you have defined PTHREAD_MUTEX_RECURSIVE_NP  
or PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP?

Vladimir

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
clisp-devel mailing list
clisp-devel@...
https://lists.sourceforge.net/lists/listinfo/clisp-devel

Re: threads2

by Sam Steingold :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Vladimir,
> Just fixed it and committed to threads1 branch.

thanks. and I just fixed your ChangeLog :-)

> What OS you are using?

Linux nyc-qws-005 2.6.18-53.1.4.el5+unionfs #1 SMP Thu Jun 26 12:24:26 EDT 2008
x86_64 x86_64 x86_64 GNU/Linux

> Do you have defined PTHREAD_MUTEX_RECURSIVE_NP  

no, it's an enum

> or PTHREAD_RECURSIVE_MUTEX_INITIALIZER_NP?

yes, ifdef __USE_GNU

Sam.

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
clisp-devel mailing list
clisp-devel@...
https://lists.sourceforge.net/lists/listinfo/clisp-devel