tsk_fs_file_walk - char * vs. u_char *

[Simson Garfinkel-3]

The function tsk_fs_file_walk() takes a callback with this function signature:

file_act(TSK_FS_FILE * fs_file, TSK_OFF_T a_off, TSK_DADDR_T addr, char *buf,
         size_t size, TSK_FS_BLOCK_FLAG_ENUM flags, void *ptr)

My concern is that "buf" should properly be an unsigned char array, not a signed char array. That's because it's being used for bulk data and the current convention among many programs is to use u_char * for bulk data, and reserve char * for printable data.

What do others think?

-Simson


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
sleuthkit-users mailing list
https://lists.sourceforge.net/lists/listinfo/sleuthkit-users
http://www.sleuthkit.org