typo3/mod.php does NOT allow scrolling

[Mathias Schreiber [wmdb]]

Hi guys (n gals),

I just wanted to ask whether you considr this a bug or an intended
"feature" before I supply a patch.

Background:
typo3/stylesheet.css sets all body tags with the ID typo3-mod-php to
height 100% and overflow hidden.

This involves all backend modules that use mod.php (see
typo3/template.php on line 235, which changes typo3/mod.php to
typo3-mod-php).

At least for me this makes no sense, since scrolling in modules might
appear from time to time.

In order to break next to nothing I suggest to remove the selector
body#typo3-mod-php from the stylesheet rule and copy the selector to

body#typo3-mod-php {
        padding: 0;
        margin: 0;
        overflow: auto;
        height: 100%;
}

Another option would be to leave the module body like it is but then
give the div.typo3-bigDoc 100% height and overflow: auto;

Suggestions please.

Mathias
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Kamper-3]

Hi Mathias,

Mathias Schreiber [wmdb >] schrieb:

> Hi guys (n gals),
>
> I just wanted to ask whether you considr this a bug or an intended
> "feature" before I supply a patch.
>
> Background:
> typo3/stylesheet.css sets all body tags with the ID typo3-mod-php to
> height 100% and overflow hidden.
>
> This involves all backend modules that use mod.php (see
> typo3/template.php on line 235, which changes typo3/mod.php to
> typo3-mod-php).
>
> At least for me this makes no sense, since scrolling in modules might
> appear from time to time.
>
> In order to break next to nothing I suggest to remove the selector
> body#typo3-mod-php from the stylesheet rule and copy the selector to
>
> body#typo3-mod-php {
>     padding: 0;
>     margin: 0;
>     overflow: auto;
>     height: 100%;
> }
>
> Another option would be to leave the module body like it is but then
> give the div.typo3-bigDoc 100% height and overflow: auto;
>
> Suggestions please.
>
> Mathias

It's correct that the body has overflow: hidden

The reason is the docheader. Now use an inner div like core does:
typo3-docbody

and give it overflow: auto;

and you're done.

mod.php isn't related as it's only used for link generation.

vg Steffen
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Mathias Schreiber [wmdb]]

Steffen Kamper schrieb:
> It's correct that the body has overflow: hidden
>
> The reason is the docheader. Now use an inner div like core does:
> typo3-docbody

I see but does this make sense?
Since CGL suggests to use template.php which offers:
- typo3-bigDoc
- typo3-noDoc
- typo3-smallDoc
- typo3-mediumDoc

I don't see the reason for the extension author to add another div plus
an additional style if we would simply reuse what already there.

So my option No. 2 would be the way to go and add a css rule something
like this:
div.typo3-bigDoc,div.typo3-noDoc,div.typo3-smallDoc,div.typo3-mediumDoc {
        height:99%;
        overflow: auto;
}

This would return everything back to normal (meaning: What users would
expect and how it used to be).

Mathias
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Dmitry Dulepov [typo3]]

Hi!

Mathias Schreiber [wmdb >] wrote:
> I don't see the reason for the extension author to add another div plus
> an additional style if we would simply reuse what already there.

Sounds absolutely logical.

--
Dmitry Dulepov
TYPO3 core team
http://dmitry-dulepov.com/
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Mathias Schreiber [wmdb]]

Dmitry Dulepov schrieb:
> Hi!
>
> Mathias Schreiber [wmdb >] wrote:
>> I don't see the reason for the extension author to add another div plus
>> an additional style if we would simply reuse what already there.
>
> Sounds absolutely logical.

I found another minor issue.
If we set the overflow thingy to auto, modules that need more width than
bigDoc allows (roughly 650 pixels or something), they will trigger a
horizontal scrollbar.
But I think in this case it would be ok for the extension author to
overwrite the TYPO3 style in his module.
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Dmitry Dulepov [typo3]]

Hi!

Mathias Schreiber [wmdb >] wrote:
> I found another minor issue.
> If we set the overflow thingy to auto, modules that need more width than
> bigDoc allows (roughly 650 pixels or something), they will trigger a
> horizontal scrollbar.

What about using "overflow-y: auto" instead of "overflow: auto"?

--
Dmitry Dulepov
TYPO3 core team
http://dmitry-dulepov.com/
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Mathias Schreiber [wmdb]]

Dmitry Dulepov schrieb:

> Hi!
>
> Mathias Schreiber [wmdb >] wrote:
>> I found another minor issue.
>> If we set the overflow thingy to auto, modules that need more width than
>> bigDoc allows (roughly 650 pixels or something), they will trigger a
>> horizontal scrollbar.
>
> What about using "overflow-y: auto" instead of "overflow: auto"?
>

Works weird in FF3 and IE6.
But this seems to do the job...
overflow-y: auto;
overflow-x: hidden;

So...
Do I make a patch for this?
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Dmitry Dulepov [typo3]]

Hi!

Mathias Schreiber [wmdb >] wrote:
> Do I make a patch for this?

Yes :) And if you can make a simple test extension for this with a module that uses mod.php, it will greatly speed up reviews ;)

--
Dmitry Dulepov
TYPO3 core team
http://dmitry-dulepov.com/
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Franz Koch-4]

Hi,

>> Mathias Schreiber [wmdb >] wrote:
>>> I found another minor issue.
>>> If we set the overflow thingy to auto, modules that need more width than
>>> bigDoc allows (roughly 650 pixels or something), they will trigger a
>>> horizontal scrollbar.
>>
>> What about using "overflow-y: auto" instead of "overflow: auto"?
>>
>
> Works weird in FF3 and IE6.
> But this seems to do the job...
> overflow-y: auto;
> overflow-x: hidden;
>
> So...
> Do I make a patch for this?

why prohibiting the horizontal scrollbar by default if needed by the
displayed content? And why the 650px limit in bigDoc (or at all)? Just
make it 100% and everybody is happy - it really sucks having only a
small workarea on large screens and have it not adjustable for smaller
ones. So simply use relative dimensions and not fixed px dimensions.

Same for the RTE - why not using the available screen width by default
(setting 100% is not working like expected due to the wrapping table in
TCEforms) - come one and finally arrive in the year 2009 where the
output device can have more (or less) than 800x600px.
--
kind regards,
Franz Koch

---------------------------------------------------
PayPal-Account: 'paypal _at_ elements-net _dot_ de'
---------------------------------------------------
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Mathias Schreiber [wmdb]]

Franz Koch schrieb:

> Hi,
>>> Mathias Schreiber [wmdb >] wrote:
>>>> I found another minor issue.
>>>> If we set the overflow thingy to auto, modules that need more width
>>>> than
>>>> bigDoc allows (roughly 650 pixels or something), they will trigger a
>>>> horizontal scrollbar.
>>>
>>> What about using "overflow-y: auto" instead of "overflow: auto"?
>>>
>>
>> Works weird in FF3 and IE6.
>> But this seems to do the job...
>> overflow-y: auto;
>> overflow-x: hidden;
>>
>> So...
>> Do I make a patch for this?
>
> why prohibiting the horizontal scrollbar by default if needed by the
> displayed content? And why the 650px limit in bigDoc (or at all)? Just
> make it 100% and everybody is happy - it really sucks having only a
> small workarea on large screens and have it not adjustable for smaller
> ones. So simply use relative dimensions and not fixed px dimensions.

Good point.
So my patch would involve two things:
a) make bigDoc 100% wide
b) allow scrolling
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Mathias Schreiber [wmdb]]

Hola,

Dmitry Dulepov schrieb:
> Yes :) And if you can make a simple test extension for this with a
 > module that uses mod.php, it will greatly speed up reviews ;)

Just did as you said.
Hope everything is optimal to work with, if not, tell me for later bug
fixes.

cherio
Mathias

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Francois Suter-2]

Hi,

> a) make bigDoc 100% wide

Another possibility could be to drop the use of "bigDoc" (and "smallDoc"
and "mediumDoc" and "noDoc") and replace them simply with "template",
which has no width restriction. I don't know what could be the side
effects of such a change, but at least that's what I do in the BE
modules that I develop.

These extra template classes could be deprecated then.

But that's probably beyond the scope of your original question.

Cheers

--

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Mathias Schreiber [wmdb]]

Francois Suter schrieb:
> Hi,
>
>> a) make bigDoc 100% wide
>
> Another possibility could be to drop the use of "bigDoc" (and "smallDoc"
> and "mediumDoc" and "noDoc") and replace them simply with "template",
> which has no width restriction. I don't know what could be the side
> effects of such a change, but at least that's what I do in the BE
> modules that I develop.

template.php would have to "react" on the old instances though (maybe
with some sort of "deprecated" flag or similar) in order to stay
backwards compatible.

> These extra template classes could be deprecated then.

jep.
But I don't know the exact procedure on deprecated stuff and if I look
at static_templates.... :)

> But that's probably beyond the scope of your original question.

not really.
The scope was to remove this bug :)

cheerio
Mathias
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Gebert]

Mathias Schreiber [wmdb >] wrote:
> In order to break next to nothing I suggest to remove the selector
> body#typo3-mod-php from the stylesheet rule and copy the selector to

Does this also affect 4.3?
I don't miss scrollbars there, but 2nd bars are added.

For 4.2 I see the problem (but currently have no test installation where I
could quickly change the styles).

Steffen

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Thorsten Kahler [dkd]]

Hi Steffen,

Steffen Gebert schrieb am 11.03.2009 14:52 Uhr:
> Mathias Schreiber [wmdb >] wrote:
>> In order to break next to nothing I suggest to remove the selector
>> body#typo3-mod-php from the stylesheet rule and copy the selector to
>
> Does this also affect 4.3?
> I don't miss scrollbars there, but 2nd bars are added.

is that effect reproducible for you in every browser? I experienced it
with Opera, where it's caused by an outdated version of Prototype.

Regards
Thorsten
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Gebert]

Thorsten Kahler [dkd] wrote:
> is that effect reproducible for you in every browser? I experienced it
> with Opera, where it's caused by an outdated version of Prototype.

I just tried Firefox and IE7 and have no scrollbars in none of them. In
Opera I can at least use my mouse wheel.
That's a quite obvious bug :)

The only effect of outdated prototype in Opera I noticed is the ~660px height
of backend..

Steffen

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Kamper-3]

Hi,

Steffen Gebert schrieb:

> Thorsten Kahler [dkd] wrote:
>> is that effect reproducible for you in every browser? I experienced it
>> with Opera, where it's caused by an outdated version of Prototype.
>
> I just tried Firefox and IE7 and have no scrollbars in none of them. In
> Opera I can at least use my mouse wheel.
> That's a quite obvious bug :)
>
> The only effect of outdated prototype in Opera I noticed is the ~660px height
> of backend..
>
> Steffen
>

very strange as i have scrollbars everywhere ...

vg Steffen
_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Gebert]

Steffen Kamper wrote:
> very strange as i have scrollbars everywhere ...

In 4.2 with Mathias' test extension?
I never noticed missing scrollbars before, too.

4.3 is ok...

Steffen

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Sonja Scholz]

Hi Mathias,

where I can find your patch? I didn't find a bug report or something
else, but I would like to test it on IE7.

When I create a simple standart backend module with the current
kickstarter extension the module uses also the mod.php way. In IE7 this
module has no scrollbar on the right so the content will be croped.

Kind regards,

Sonja


_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev

[Steffen Gebert]

Sonja Scholz wrote:
> where I can find your patch? I didn't find a bug report or something
> else, but I would like to test it on IE7.

Hi Sonja,

bugtracker entry: http://bugs.typo3.org/view.php?id=8433
thread in core list: <http://lists.netfielders.de/pipermail/typo3-team-
core/2009-March/024389.html>

Greets
Steffen

_______________________________________________
TYPO3-dev mailing list
TYPO3-dev@...
http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-dev