v2.1 build failure

[Simon Josefsson-2]

Hi.  Congratulations on the release!

I'm building it to setup a IMAP server with SCRAM-SHA-1 support via GNU
SASL.  I'm running into a build error:

make[3]: Leaving directory `/root/mailutils-2.1/mail/testsuite'
make[3]: Entering directory `/root/mailutils-2.1/mail'
gcc -DHAVE_CONFIG_H -I. -I.. -I. -I../include -I../lib -I../lib -I.. -I../include -I../mailbox -I../libmu_argp -I../libmu_cfg    -DSYSCONFDIR=\"/usr/local/etc\" -DSITE_MAIL_RC=\"/usr/local/etc/mail.rc\" -g -MT table.o -MD -MP -MF .deps/table.Tpo -c -o table.o table.c
table.c:126: error: ‘mailvar_set_compl’ undeclared here (not in a function)
make[3]: *** [table.o] Error 1
make[3]: Leaving directory `/root/mailutils-2.1/mail'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/root/mailutils-2.1/mail'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/root/mailutils-2.1'
make: *** [all] Error 2
nubb:~/mailutils-2.1#

Any ideas?

/Simon


_______________________________________________
Bug-mailutils mailing list
Bug-mailutils@...
http://lists.gnu.org/mailman/listinfo/bug-mailutils

[Simon Josefsson-2]

I'm happy to announce that GNU MailUtils imapd will use SCRAM-SHA-1 (the
next generation SASL mechanism) without any code changes if compiled
with --with-gsasl and the system's GNU SASL is recent enough to support
SCRAM-SHA-1.

Example session (use password 'pencil'):

jas@mocca:~/src/gsasl master$ src/gsasl --connect nubb.josefsson.org -a user
Trying `nubb.josefsson.org'...
* OK IMAP4rev1
. CAPABILITY
* CAPABILITY IMAP4rev1 NAMESPACE ID IDLE LITERAL+ UNSELECT AUTH=ANONYMOUS AUTH=EXTERNAL AUTH=LOGIN AUTH=PLAIN AUTH=SECURID AUTH=DIGEST-MD5 AUTH=CRAM-MD5 AUTH=SCRAM-SHA-1
. OK CAPABILITY Completed
. CAPABILITY
* CAPABILITY IMAP4rev1 NAMESPACE ID IDLE LITERAL+ UNSELECT AUTH=ANONYMOUS AUTH=EXTERNAL AUTH=LOGIN AUTH=PLAIN AUTH=SECURID AUTH=DIGEST-MD5 AUTH=CRAM-MD5 AUTH=SCRAM-SHA-1
. OK CAPABILITY Completed
. AUTHENTICATE SCRAM-SHA-1
+
biwsbj11c2VyLHI9Y3BsU0ZOV2hzYWI2NG52ZWdHYTdvNy9Z
+ cj1jcGxTRk5XaHNhYjY0bnZlZ0dhN283L1loTTF1a2h4ZlFPZWgrT3krOXcscz1CYUc2UDRmRGpuNDhHcFh0LGk9NDA5Ng==
Enter password:
Yz1iaXdzLHI9Y3BsU0ZOV2hzYWI2NG52ZWdHYTdvNy9ZaE0xdWtoeGZRT2VoK095Kzl3LHA9aXF2R212Q0YzRE1jYTMweUFWZUlKYTBDN3M4PQ==
+ dj1zTmdERmFnd3dDVTVwL0RuTXhpTmxCdUg1Z1U9
. OK AUTHENTICATE SCRAM-SHA-1 authentication successful
Client authentication finished (server trusted)...
Enter application data (EOF to finish):
. capability
* CAPABILITY IMAP4rev1 NAMESPACE ID IDLE LITERAL+ UNSELECT
. OK CAPABILITY Completed
. logout
* BYE Session terminating.
. OK LOGOUT Completed
Session finished...
. LOGOUT
jas@mocca:~/src/gsasl master$

/Simon


_______________________________________________
Bug-mailutils mailing list
Bug-mailutils@...
http://lists.gnu.org/mailman/listinfo/bug-mailutils

[Sergey Poznyakoff-2]

Hi Simon,

> I'm building it to setup a IMAP server with SCRAM-SHA-1 support via GNU
> SASL.  I'm running into a build error:

Probably you are compiling without GNU readline support, aren't you?
Try the following patch:

diff --git a/mail/mail.h b/mail/mail.h
index 7eeb600..d9950b0 100644
--- a/mail/mail.h
+++ b/mail/mail.h
@@ -476,6 +476,7 @@ extern char **exec_compl (int argc, char **argv, int ws);
 # define alias_compl NULL
 # define var_compl NULL
 # define exec_compl NULL    
+# define mailvar_set_compl NULL
 #endif
 
 #ifdef __cplusplus

Regards,
Sergey


_______________________________________________
Bug-mailutils mailing list
Bug-mailutils@...
http://lists.gnu.org/mailman/listinfo/bug-mailutils

[Sergey Poznyakoff-2]

Simon Josefsson <simon@...> ha escrit:

> I'm happy to announce that GNU MailUtils imapd will use SCRAM-SHA-1 (the
> next generation SASL mechanism) without any code changes if compiled
> with --with-gsasl and the system's GNU SASL is recent enough to support
> SCRAM-SHA-1.

Great! Thanks for good news :)

Regards,
Sergey


_______________________________________________
Bug-mailutils mailing list
Bug-mailutils@...
http://lists.gnu.org/mailman/listinfo/bug-mailutils

[Simon Josefsson-2]

Sergey Poznyakoff <gray@...> writes:

> Hi Simon,
>
>> I'm building it to setup a IMAP server with SCRAM-SHA-1 support via GNU
>> SASL.  I'm running into a build error:
>
> Probably you are compiling without GNU readline support, aren't you?
> Try the following patch:

Yes this solves the problem.  Thank you!

Btw, 'make check' works.

/Simon

> diff --git a/mail/mail.h b/mail/mail.h
> index 7eeb600..d9950b0 100644
> --- a/mail/mail.h
> +++ b/mail/mail.h
> @@ -476,6 +476,7 @@ extern char **exec_compl (int argc, char **argv, int ws);
>  # define alias_compl NULL
>  # define var_compl NULL
>  # define exec_compl NULL    
> +# define mailvar_set_compl NULL
>  #endif
>  
>  #ifdef __cplusplus
>
> Regards,
> Sergey

_______________________________________________
Bug-mailutils mailing list
Bug-mailutils@...
http://lists.gnu.org/mailman/listinfo/bug-mailutils

[Simon Josefsson-2]

Sergey Poznyakoff <gray@...> writes:

> Simon Josefsson <simon@...> ha escrit:
>
>> I'm happy to announce that GNU MailUtils imapd will use SCRAM-SHA-1 (the
>> next generation SASL mechanism) without any code changes if compiled
>> with --with-gsasl and the system's GNU SASL is recent enough to support
>> SCRAM-SHA-1.
>
> Great! Thanks for good news :)

However, imapd/auth_gsasl.c could use some cleaning up to use the latest
GNU SASL interface (right now there are warnings about using deprecated
interfaces).  Before sending a patch, are you OK with abandoning support
for old GNU SASL?  GNU SASL 0.2.x with the new interface was released in
2004 and not even my Ubuntu 8.04 LTS system has it anymore.

If you agree with this, I can prepare a patch to cleanup the code a bit.

/Simon


_______________________________________________
Bug-mailutils mailing list
Bug-mailutils@...
http://lists.gnu.org/mailman/listinfo/bug-mailutils

[Sergey Poznyakoff-2]

Simon Josefsson <simon@...> ha escrit:

> However, imapd/auth_gsasl.c could use some cleaning up to use the latest
> GNU SASL interface (right now there are warnings about using deprecated
> interfaces).  Before sending a patch, are you OK with abandoning support
> for old GNU SASL?

Yes, of course.

> If you agree with this, I can prepare a patch to cleanup the code a
> bit.

Yes, please do.

Regards,
Sergey


_______________________________________________
Bug-mailutils mailing list
Bug-mailutils@...
http://lists.gnu.org/mailman/listinfo/bug-mailutils

[Simon Josefsson-2]

Sergey Poznyakoff <gray@...> writes:

> Simon Josefsson <simon@...> ha escrit:
>
>> However, imapd/auth_gsasl.c could use some cleaning up to use the latest
>> GNU SASL interface (right now there are warnings about using deprecated
>> interfaces).  Before sending a patch, are you OK with abandoning support
>> for old GNU SASL?
>
> Yes, of course.
>
>> If you agree with this, I can prepare a patch to cleanup the code a
>> bit.
>
> Yes, please do.

The code was in better shape than I first thought.  The patch below is
the only patch needed to bring it up to speed.

However I believe I identified a gsasl related problem, will debug and
report separately.

/Simon

From 277000fa27dc09df08ca7877998238d6f4923af3 Mon Sep 17 00:00:00 2001
From: Simon Josefsson <simon@...>
Date: Thu, 24 Sep 2009 13:47:40 +0200
Subject: [PATCH] Don't use deprecated GNU SASL types.

---
 include/mailutils/gsasl.h |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/include/mailutils/gsasl.h b/include/mailutils/gsasl.h
index 6067746..ef33f25 100644
--- a/include/mailutils/gsasl.h
+++ b/include/mailutils/gsasl.h
@@ -37,8 +37,7 @@ struct mu_gsasl_module_data mu_gsasl_module_data;
 #include <gsasl.h>
 
 int mu_gsasl_stream_create (mu_stream_t *stream, mu_stream_t transport,
-    Gsasl_session_ctx *ctx,
-    int flags);
+    Gsasl_session *ctx, int flags);
 
 #endif
 
--
1.6.3.3



_______________________________________________
Bug-mailutils mailing list
Bug-mailutils@...
http://lists.gnu.org/mailman/listinfo/bug-mailutils