version.properties

View: New views
3 Messages — Rating Filter:   Alert me  

version.properties

by hdockter :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message

Hi Adam,

in commit: http://github.com/gradle/gradle/commit/73dfb8ad7c70d74bd7619db94e118ca1bfc7d8d1

you have removed the version properties file from the src/test/
resources dir. It is now created as part of the build.  I see the  
advantage of generating it as part of the build (keeping things  
syncronized). The problem with this approach is that it makes it  
harder to execute the Gradle build from the IDE Gradle project (which  
I do very often).

Should I roll this change back?

- Hans

--
Hans Dockter
Gradle Project Manager
http://www.gradle.org

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email



Re: version.properties

by Adam Murdoch-2 :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message



Hans Dockter wrote:

> Hi Adam,
>
> in commit:
> http://github.com/gradle/gradle/commit/73dfb8ad7c70d74bd7619db94e118ca1bfc7d8d1 
>
>
> you have removed the version properties file from the
> src/test/resources dir. It is now created as part of the build.  I see
> the advantage of generating it as part of the build (keeping things
> syncronized). The problem with this approach is that it makes it
> harder to execute the Gradle build from the IDE Gradle project (which
> I do very often).
>

It is generated into build/resources/test, which you can add to your IDE
classpath, and all works fine again.

> Should I roll this change back?
>

If you like. You'll need to find some other way to get the current
version into the DistributionIntegrationTest. Possibly from the name of
the zip files.


Adam


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email



Re: version.properties

by hdockter :: Rate this Message:

Reply to Author | View Threaded | Show Only this Message


On Sep 29, 2009, at 11:33 PM, Adam Murdoch wrote:

>
>
> Hans Dockter wrote:
>> Hi Adam,
>>
>> in commit: http://github.com/gradle/gradle/commit/73dfb8ad7c70d74bd7619db94e118ca1bfc7d8d1
>>
>> you have removed the version properties file from the src/test/
>> resources dir. It is now created as part of the build.  I see the  
>> advantage of generating it as part of the build (keeping things  
>> syncronized). The problem with this approach is that it makes it  
>> harder to execute the Gradle build from the IDE Gradle project  
>> (which I do very often).
>>
>
> It is generated into build/resources/test, which you can add to your  
> IDE classpath, and all works fine again.

Why not generating it in a non build directory (like ide task does for  
the libs)? That would make things more stable if I want to build  
Gradle from IntelliJ.

- Hans

--
Hans Dockter
Gradle Project Manager
http://www.gradle.org


---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email