virtinst: acpi/apic == FALSE for Windows XP

[Guido Günther]

Hi,
virtinst has:

"winxp":{ "label": "Microsoft Windows XP (x86)",
                  "acpi": False, "apic": False },

I couldn't find any reason for this in the hg logs and
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
states that Windows XP is working fine with acpi/apic enabled which has
the immediate advantage that poweroff via ACPI works as expected.
So does it make sense to handle winxp the same win2k3?
Cheers,
 -- Guido

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Guido Günther]

On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
> Hi,
> virtinst has:
>
> "winxp":{ "label": "Microsoft Windows XP (x86)",
>                   "acpi": False, "apic": False },
>
> I couldn't find any reason for this in the hg logs and
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
The correct URL is:
  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
Cheers,
 -- Guido

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Cole Robinson]

On 07/05/2009 08:27 AM, Guido Günther wrote:

> On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
>> Hi,
>> virtinst has:
>>
>> "winxp":{ "label": "Microsoft Windows XP (x86)",
>>                   "acpi": False, "apic": False },
>>
>> I couldn't find any reason for this in the hg logs and
>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
> The correct URL is:
>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
> Cheers,
>  -- Guido
>

AFAIK this was done because windows installs on xen used to choke if ACPI was
enabled. There is an old wiki page corroborating that here, no idea if it is
still relevant, or if there were other issues at play:

http://wiki.xensource.com/xenwiki/XenWindowsACPI

I'm pretty sure the KVM maintainer has indicated we should enable ACPI
unconditionally these days, so I'd take a patch for that.

Thanks,
Cole


_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Pasi Kärkkäinen]

On Sun, Jul 05, 2009 at 04:50:59PM -0400, Cole Robinson wrote:

> On 07/05/2009 08:27 AM, Guido Günther wrote:
> > On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
> >> Hi,
> >> virtinst has:
> >>
> >> "winxp":{ "label": "Microsoft Windows XP (x86)",
> >>                   "acpi": False, "apic": False },
> >>
> >> I couldn't find any reason for this in the hg logs and
> >>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
> > The correct URL is:
> >   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
> > Cheers,
> >  -- Guido
> >
>
> AFAIK this was done because windows installs on xen used to choke if ACPI was
> enabled. There is an old wiki page corroborating that here, no idea if it is
> still relevant, or if there were other issues at play:
>
> http://wiki.xensource.com/xenwiki/XenWindowsACPI
>

I think that's obsolete and nowadays ACPI (and APIC) should be enabled for
Xen Windows guests.

Please correct me if I'm wrong.

-- Pasi

> I'm pretty sure the KVM maintainer has indicated we should enable ACPI
> unconditionally these days, so I'd take a patch for that.
>
> Thanks,
> Cole
>

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Chris Lalancette-2]

Pasi Kärkkäinen wrote:

> On Sun, Jul 05, 2009 at 04:50:59PM -0400, Cole Robinson wrote:
>> On 07/05/2009 08:27 AM, Guido Günther wrote:
>>> On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
>>>> Hi,
>>>> virtinst has:
>>>>
>>>> "winxp":{ "label": "Microsoft Windows XP (x86)",
>>>>                   "acpi": False, "apic": False },
>>>>
>>>> I couldn't find any reason for this in the hg logs and
>>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
>>> The correct URL is:
>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
>>> Cheers,
>>>  -- Guido
>>>
>> AFAIK this was done because windows installs on xen used to choke if ACPI was
>> enabled. There is an old wiki page corroborating that here, no idea if it is
>> still relevant, or if there were other issues at play:
>>
>> http://wiki.xensource.com/xenwiki/XenWindowsACPI
>>
>
> I think that's obsolete and nowadays ACPI (and APIC) should be enabled for
> Xen Windows guests.
>
> Please correct me if I'm wrong.

You are probably correct, although testing (especially on things like RHEL-5
Xen) is in order before making the change for Xen as well.

--
Chris Lalancette

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Laurent Léonard]

Le mardi 07 juillet 2009 à 09:53, Chris Lalancette a écrit :

> Pasi Kärkkäinen wrote:
> > On Sun, Jul 05, 2009 at 04:50:59PM -0400, Cole Robinson wrote:
> >> On 07/05/2009 08:27 AM, Guido Günther wrote:
> >>> On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
> >>>> Hi,
> >>>> virtinst has:
> >>>>
> >>>> "winxp":{ "label": "Microsoft Windows XP (x86)",
> >>>>                   "acpi": False, "apic": False },
> >>>>
> >>>> I couldn't find any reason for this in the hg logs and
> >>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
> >>>
> >>> The correct URL is:
> >>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
> >>> Cheers,
> >>>  -- Guido
> >>
> >> AFAIK this was done because windows installs on xen used to choke if
> >> ACPI was enabled. There is an old wiki page corroborating that here, no
> >> idea if it is still relevant, or if there were other issues at play:
> >>
> >> http://wiki.xensource.com/xenwiki/XenWindowsACPI
> >
> > I think that's obsolete and nowadays ACPI (and APIC) should be enabled
> > for Xen Windows guests.
> >
> > Please correct me if I'm wrong.
>
> You are probably correct, although testing (especially on things like
> RHEL-5 Xen) is in order before making the change for Xen as well.

As I wrote in a mail to Cole, I made some tests on Debian Squeeze with Xen
3.2.1.

I successfully installed a Windows XP virtual machine with ACPI enabled, the
installation ended without any manual intervention (excepted those requested
by the Windows setup). But I also installed a similar virtual machine without
ACPI. The virtual machine with ACPI enabled seems to be slower than the
virtual machine without ACPI. I suppose it's a bug in Xen 3.2.1, perhaps it
is fixed in Xen 3.3 or 3.4 ? Same problem with Windows Server 2003 (ACPI is
enabled in OS dictionary for this variant corrseponding to this Windows
version). I think there is no difference in ACPI handling between Windows XP
x86, x86_64 and Windows Server 2003 so there is no reason to have different
options in the OS dictionary...

--
Laurent Léonard


_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Pasi Kärkkäinen]

On Tue, Jul 07, 2009 at 09:53:45AM +0200, Chris Lalancette wrote:

> Pasi Kärkkäinen wrote:
> > On Sun, Jul 05, 2009 at 04:50:59PM -0400, Cole Robinson wrote:
> >> On 07/05/2009 08:27 AM, Guido Günther wrote:
> >>> On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
> >>>> Hi,
> >>>> virtinst has:
> >>>>
> >>>> "winxp":{ "label": "Microsoft Windows XP (x86)",
> >>>>                   "acpi": False, "apic": False },
> >>>>
> >>>> I couldn't find any reason for this in the hg logs and
> >>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
> >>> The correct URL is:
> >>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
> >>> Cheers,
> >>>  -- Guido
> >>>
> >> AFAIK this was done because windows installs on xen used to choke if ACPI was
> >> enabled. There is an old wiki page corroborating that here, no idea if it is
> >> still relevant, or if there were other issues at play:
> >>
> >> http://wiki.xensource.com/xenwiki/XenWindowsACPI
> >>
> >
> > I think that's obsolete and nowadays ACPI (and APIC) should be enabled for
> > Xen Windows guests.
> >
> > Please correct me if I'm wrong.
>
> You are probably correct, although testing (especially on things like RHEL-5
> Xen) is in order before making the change for Xen as well.
>

I actually asked about this on xen-devel, and Keir Fraser replied that ACPI
with Windows has been working properly at least since Xen 3.1.0 days.

I updated that XenWindowsACPI wiki page aswell.

-- Pasi

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Laurent Léonard]

Le mardi 07 juillet 2009 à 18:58, Pasi Kärkkäinen a écrit :

> On Tue, Jul 07, 2009 at 09:53:45AM +0200, Chris Lalancette wrote:
> > Pasi Kärkkäinen wrote:
> > > On Sun, Jul 05, 2009 at 04:50:59PM -0400, Cole Robinson wrote:
> > >> On 07/05/2009 08:27 AM, Guido Günther wrote:
> > >>> On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
> > >>>> Hi,
> > >>>> virtinst has:
> > >>>>
> > >>>> "winxp":{ "label": "Microsoft Windows XP (x86)",
> > >>>>                   "acpi": False, "apic": False },
> > >>>>
> > >>>> I couldn't find any reason for this in the hg logs and
> > >>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
> > >>>
> > >>> The correct URL is:
> > >>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
> > >>> Cheers,
> > >>>  -- Guido
> > >>
> > >> AFAIK this was done because windows installs on xen used to choke if
> > >> ACPI was enabled. There is an old wiki page corroborating that here,
> > >> no idea if it is still relevant, or if there were other issues at
> > >> play:
> > >>
> > >> http://wiki.xensource.com/xenwiki/XenWindowsACPI
> > >
> > > I think that's obsolete and nowadays ACPI (and APIC) should be enabled
> > > for Xen Windows guests.
> > >
> > > Please correct me if I'm wrong.
> >
> > You are probably correct, although testing (especially on things like
> > RHEL-5 Xen) is in order before making the change for Xen as well.
>
> I actually asked about this on xen-devel, and Keir Fraser replied that ACPI
> with Windows has been working properly at least since Xen 3.1.0 days.

I also installed Windows 2000 Server virtual machines with ACPI enabled on
Debian Squeeze with Xen 3.2.1 and KVM 85, no problem.

So the attached patch should be applied to virtinst to:
- Enable ACPI and APIC for Windows XP
- Enable ACPI and APIC for Windows 2000
- Merge Windows XP x86 and x86_64 variants because there is no more reason to
have different variants for the same OS

--
Laurent Léonard

[attachment removed]

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Cole Robinson]

Laurent Léonard wrote:

> Le mardi 07 juillet 2009 à 18:58, Pasi Kärkkäinen a écrit :
>> On Tue, Jul 07, 2009 at 09:53:45AM +0200, Chris Lalancette wrote:
>>> Pasi Kärkkäinen wrote:
>>>> On Sun, Jul 05, 2009 at 04:50:59PM -0400, Cole Robinson wrote:
>>>>> On 07/05/2009 08:27 AM, Guido Günther wrote:
>>>>>> On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
>>>>>>> Hi,
>>>>>>> virtinst has:
>>>>>>>
>>>>>>> "winxp":{ "label": "Microsoft Windows XP (x86)",
>>>>>>>                   "acpi": False, "apic": False },
>>>>>>>
>>>>>>> I couldn't find any reason for this in the hg logs and
>>>>>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
>>>>>> The correct URL is:
>>>>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
>>>>>> Cheers,
>>>>>>  -- Guido
>>>>> AFAIK this was done because windows installs on xen used to choke if
>>>>> ACPI was enabled. There is an old wiki page corroborating that here,
>>>>> no idea if it is still relevant, or if there were other issues at
>>>>> play:
>>>>>
>>>>> http://wiki.xensource.com/xenwiki/XenWindowsACPI
>>>> I think that's obsolete and nowadays ACPI (and APIC) should be enabled
>>>> for Xen Windows guests.
>>>>
>>>> Please correct me if I'm wrong.
>>> You are probably correct, although testing (especially on things like
>>> RHEL-5 Xen) is in order before making the change for Xen as well.
>> I actually asked about this on xen-devel, and Keir Fraser replied that ACPI
>> with Windows has been working properly at least since Xen 3.1.0 days.
>
> I also installed Windows 2000 Server virtual machines with ACPI enabled on
> Debian Squeeze with Xen 3.2.1 and KVM 85, no problem.
>
> So the attached patch should be applied to virtinst to:
> - Enable ACPI and APIC for Windows XP
> - Enable ACPI and APIC for Windows 2000
> - Merge Windows XP x86 and x86_64 variants because there is no more reason to
> have different variants for the same OS
>

Hmm, I would like to maintain the current behavior for xen < 3.1.0,
since RHEL/CentOS is still a target and I wouldn't want to regress. We
should be able to get this info from libvirt and the ACPI defaults
accordingly, I'll test it out shortly.

As for merging XP 32 and XP 64: the latter is actually more like windows
2003 than it is XP, so it should really remain a separate variant. We
may add more metadata to the osdict in the future that will actually
yeild a difference between XP and XP64. At the very least, back compat
would need to be maintained, so we would need to map the existing
'winxp64' label to something already in the dict.

Thanks,
Cole

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Cole Robinson]

Cole Robinson wrote:

> Laurent Léonard wrote:
>> Le mardi 07 juillet 2009 à 18:58, Pasi Kärkkäinen a écrit :
>>> On Tue, Jul 07, 2009 at 09:53:45AM +0200, Chris Lalancette wrote:
>>>> Pasi Kärkkäinen wrote:
>>>>> On Sun, Jul 05, 2009 at 04:50:59PM -0400, Cole Robinson wrote:
>>>>>> On 07/05/2009 08:27 AM, Guido Günther wrote:
>>>>>>> On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
>>>>>>>> Hi,
>>>>>>>> virtinst has:
>>>>>>>>
>>>>>>>> "winxp":{ "label": "Microsoft Windows XP (x86)",
>>>>>>>>                   "acpi": False, "apic": False },
>>>>>>>>
>>>>>>>> I couldn't find any reason for this in the hg logs and
>>>>>>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
>>>>>>> The correct URL is:
>>>>>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
>>>>>>> Cheers,
>>>>>>>  -- Guido
>>>>>> AFAIK this was done because windows installs on xen used to choke if
>>>>>> ACPI was enabled. There is an old wiki page corroborating that here,
>>>>>> no idea if it is still relevant, or if there were other issues at
>>>>>> play:
>>>>>>
>>>>>> http://wiki.xensource.com/xenwiki/XenWindowsACPI
>>>>> I think that's obsolete and nowadays ACPI (and APIC) should be enabled
>>>>> for Xen Windows guests.
>>>>>
>>>>> Please correct me if I'm wrong.
>>>> You are probably correct, although testing (especially on things like
>>>> RHEL-5 Xen) is in order before making the change for Xen as well.
>>> I actually asked about this on xen-devel, and Keir Fraser replied that ACPI
>>> with Windows has been working properly at least since Xen 3.1.0 days.
>> I also installed Windows 2000 Server virtual machines with ACPI enabled on
>> Debian Squeeze with Xen 3.2.1 and KVM 85, no problem.
>>
>> So the attached patch should be applied to virtinst to:
>> - Enable ACPI and APIC for Windows XP
>> - Enable ACPI and APIC for Windows 2000
>> - Merge Windows XP x86 and x86_64 variants because there is no more reason to
>> have different variants for the same OS
>>
>
> Hmm, I would like to maintain the current behavior for xen < 3.1.0,
> since RHEL/CentOS is still a target and I wouldn't want to regress. We
> should be able to get this info from libvirt and the ACPI defaults
> accordingly, I'll test it out shortly.
>

I've pushed changes which enable APIC and ACPI for XP and 2000 for
everything except Xen < 3.1.0.

Thanks,
Cole

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Laurent Léonard]

Le mardi 14 juillet 2009 à 18:16, Cole Robinson a écrit :

> Cole Robinson wrote:
> > Laurent Léonard wrote:
> >> Le mardi 07 juillet 2009 à 18:58, Pasi Kärkkäinen a écrit :
> >>> On Tue, Jul 07, 2009 at 09:53:45AM +0200, Chris Lalancette wrote:
> >>>> Pasi Kärkkäinen wrote:
> >>>>> On Sun, Jul 05, 2009 at 04:50:59PM -0400, Cole Robinson wrote:
> >>>>>> On 07/05/2009 08:27 AM, Guido Günther wrote:
> >>>>>>> On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
> >>>>>>>> Hi,
> >>>>>>>> virtinst has:
> >>>>>>>>
> >>>>>>>> "winxp":{ "label": "Microsoft Windows XP (x86)",
> >>>>>>>>                   "acpi": False, "apic": False },
> >>>>>>>>
> >>>>>>>> I couldn't find any reason for this in the hg logs and
> >>>>>>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
> >>>>>>>
> >>>>>>> The correct URL is:
> >>>>>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
> >>>>>>> Cheers,
> >>>>>>>  -- Guido
> >>>>>>
> >>>>>> AFAIK this was done because windows installs on xen used to choke if
> >>>>>> ACPI was enabled. There is an old wiki page corroborating that here,
> >>>>>> no idea if it is still relevant, or if there were other issues at
> >>>>>> play:
> >>>>>>
> >>>>>> http://wiki.xensource.com/xenwiki/XenWindowsACPI
> >>>>>
> >>>>> I think that's obsolete and nowadays ACPI (and APIC) should be
> >>>>> enabled for Xen Windows guests.
> >>>>>
> >>>>> Please correct me if I'm wrong.
> >>>>
> >>>> You are probably correct, although testing (especially on things like
> >>>> RHEL-5 Xen) is in order before making the change for Xen as well.
> >>>
> >>> I actually asked about this on xen-devel, and Keir Fraser replied that
> >>> ACPI with Windows has been working properly at least since Xen 3.1.0
> >>> days.
> >>
> >> I also installed Windows 2000 Server virtual machines with ACPI enabled
> >> on Debian Squeeze with Xen 3.2.1 and KVM 85, no problem.
> >>
> >> So the attached patch should be applied to virtinst to:
> >> - Enable ACPI and APIC for Windows XP
> >> - Enable ACPI and APIC for Windows 2000
> >> - Merge Windows XP x86 and x86_64 variants because there is no more
> >> reason to have different variants for the same OS
> >
> > Hmm, I would like to maintain the current behavior for xen < 3.1.0,
> > since RHEL/CentOS is still a target and I wouldn't want to regress. We
> > should be able to get this info from libvirt and the ACPI defaults
> > accordingly, I'll test it out shortly.
>
> I've pushed changes which enable APIC and ACPI for XP and 2000 for
> everything except Xen < 3.1.0.

I'm not sure but, why did you re-specify the value for non-Xen <3.1 hosts in
each item if the ACPI and APIC are already enabled by default for Windows
variants ?

What about this:

    },
    "variants": { \
        "winxp":{ "label": "Microsoft Windows XP (x86)",
                  "acpi": [ ("xen", 3001000, False) ],
                  "apic": [ ("xen", 3001000, False) ] },
        "winxp64":{ "label": "Microsoft Windows XP (x86_64)" },
        "win2k": { "label": "Microsoft Windows 2000",
                  "acpi": [ ("xen", 3001000, False) ],
                  "apic": [ ("xen", 3001000, False) ] },
        "win2k3": { "label": "Microsoft Windows 2003" },
        "win2k8": { "label": "Microsoft Windows 2008" },
        "vista": { "label": "Microsoft Windows Vista" },

instead of this:

    },
    "variants": { \
        "winxp":{ "label": "Microsoft Windows XP (x86)",
                  "acpi": [ ("xen", 3001000, False),
                            ("all", True ), ],
                  "apic": [ ("xen", 3001000, False),
                            ("all", True ), ], },
        "winxp64":{ "label": "Microsoft Windows XP (x86_64)" },
        "win2k": { "label": "Microsoft Windows 2000",
                  "acpi": [ ("xen", 3001000, False),
                            ("all", True ), ],
                  "apic": [ ("xen", 3001000, False),
                            ("all", True ), ], },
        "win2k3": { "label": "Microsoft Windows 2003" },
        "win2k8": { "label": "Microsoft Windows 2008" },
        "vista": { "label": "Microsoft Windows Vista" },

--
Laurent Léonard


_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools

[Cole Robinson]

Laurent Léonard wrote:

> Le mardi 14 juillet 2009 à 18:16, Cole Robinson a écrit :
>> Cole Robinson wrote:
>>> Laurent Léonard wrote:
>>>> Le mardi 07 juillet 2009 à 18:58, Pasi Kärkkäinen a écrit :
>>>>> On Tue, Jul 07, 2009 at 09:53:45AM +0200, Chris Lalancette wrote:
>>>>>> Pasi Kärkkäinen wrote:
>>>>>>> On Sun, Jul 05, 2009 at 04:50:59PM -0400, Cole Robinson wrote:
>>>>>>>> On 07/05/2009 08:27 AM, Guido Günther wrote:
>>>>>>>>> On Sat, Jul 04, 2009 at 06:09:01PM +0200, Guido Günther wrote:
>>>>>>>>>> Hi,
>>>>>>>>>> virtinst has:
>>>>>>>>>>
>>>>>>>>>> "winxp":{ "label": "Microsoft Windows XP (x86)",
>>>>>>>>>>                   "acpi": False, "apic": False },
>>>>>>>>>>
>>>>>>>>>> I couldn't find any reason for this in the hg logs and
>>>>>>>>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=512439
>>>>>>>>> The correct URL is:
>>>>>>>>>   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=533201
>>>>>>>>> Cheers,
>>>>>>>>>  -- Guido
>>>>>>>> AFAIK this was done because windows installs on xen used to choke if
>>>>>>>> ACPI was enabled. There is an old wiki page corroborating that here,
>>>>>>>> no idea if it is still relevant, or if there were other issues at
>>>>>>>> play:
>>>>>>>>
>>>>>>>> http://wiki.xensource.com/xenwiki/XenWindowsACPI
>>>>>>> I think that's obsolete and nowadays ACPI (and APIC) should be
>>>>>>> enabled for Xen Windows guests.
>>>>>>>
>>>>>>> Please correct me if I'm wrong.
>>>>>> You are probably correct, although testing (especially on things like
>>>>>> RHEL-5 Xen) is in order before making the change for Xen as well.
>>>>> I actually asked about this on xen-devel, and Keir Fraser replied that
>>>>> ACPI with Windows has been working properly at least since Xen 3.1.0
>>>>> days.
>>>> I also installed Windows 2000 Server virtual machines with ACPI enabled
>>>> on Debian Squeeze with Xen 3.2.1 and KVM 85, no problem.
>>>>
>>>> So the attached patch should be applied to virtinst to:
>>>> - Enable ACPI and APIC for Windows XP
>>>> - Enable ACPI and APIC for Windows 2000
>>>> - Merge Windows XP x86 and x86_64 variants because there is no more
>>>> reason to have different variants for the same OS
>>> Hmm, I would like to maintain the current behavior for xen < 3.1.0,
>>> since RHEL/CentOS is still a target and I wouldn't want to regress. We
>>> should be able to get this info from libvirt and the ACPI defaults
>>> accordingly, I'll test it out shortly.
>> I've pushed changes which enable APIC and ACPI for XP and 2000 for
>> everything except Xen < 3.1.0.
>
> I'm not sure but, why did you re-specify the value for non-Xen <3.1 hosts in
> each item if the ACPI and APIC are already enabled by default for Windows
> variants ?
>
> What about this:
>
>     },
>     "variants": { \
>         "winxp":{ "label": "Microsoft Windows XP (x86)",
>                   "acpi": [ ("xen", 3001000, False) ],
>                   "apic": [ ("xen", 3001000, False) ] },
>         "winxp64":{ "label": "Microsoft Windows XP (x86_64)" },
>         "win2k": { "label": "Microsoft Windows 2000",
>                   "acpi": [ ("xen", 3001000, False) ],
>                   "apic": [ ("xen", 3001000, False) ] },
>         "win2k3": { "label": "Microsoft Windows 2003" },
>         "win2k8": { "label": "Microsoft Windows 2008" },
>         "vista": { "label": "Microsoft Windows Vista" },
>
> instead of this:
>
>     },
>     "variants": { \
>         "winxp":{ "label": "Microsoft Windows XP (x86)",
>                   "acpi": [ ("xen", 3001000, False),
>                             ("all", True ), ],
>                   "apic": [ ("xen", 3001000, False),
>                             ("all", True ), ], },
>         "winxp64":{ "label": "Microsoft Windows XP (x86_64)" },
>         "win2k": { "label": "Microsoft Windows 2000",
>                   "acpi": [ ("xen", 3001000, False),
>                             ("all", True ), ],
>                   "apic": [ ("xen", 3001000, False),
>                             ("all", True ), ], },
>         "win2k3": { "label": "Microsoft Windows 2003" },
>         "win2k8": { "label": "Microsoft Windows 2008" },
>         "vista": { "label": "Microsoft Windows Vista" },
>

The lookup code is currently dumb in this respect: it only falls back to
the default value if the lookup key (apic, acpi, etc.) isn't present at
all. So the above change won't work at the moment, and indeed causes the
test suite (python setup.py test && python setup.py test_cli) to fail.
I'd take a patch to properly fix it though.

Thanks,
Cole

_______________________________________________
et-mgmt-tools mailing list
et-mgmt-tools@...
https://www.redhat.com/mailman/listinfo/et-mgmt-tools