vtkPLYReader patch to allow points only

[David Doria-2]

Current vtkPLYReader does not allow reading files that do not contain faces (i.e. files with only points or points+normals). It simply quits with an error "Cannot read geometry". I modified this class to allow this type of file to be read, along with making the error output a bit more specific in the case that there actually is a problem. In the process I think the whole section that searches for properties became a bit clearer - as previously it was all embedded in a single if statement.

Here is the new along with a patch and a couple of test ply files:
http://www.rpi.edu/~doriad/VTK_List/vtkPLYReader_Patch/

Thanks,

David

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers

[Sean McBride]

On 10/16/09 9:44 AM, David Doria said:

>Current vtkPLYReader does not allow reading files that do not contain faces
>(i.e. files with only points or points+normals). It simply quits with an
>error "Cannot read geometry". I modified this class to allow this type of
>file to be read, along with making the error output a bit more specific in
>the case that there actually is a problem. In the process I think the whole
>section that searches for properties became a bit clearer - as previously it
>was all embedded in a single if statement.
>
>Here is the new along with a patch and a couple of test ply files:
>http://www.rpi.edu/~doriad/VTK_List/vtkPLYReader_Patch/

Looks like a pretty simple patch.  Do all the tests still pass?  Adding
new tests with your sample files would be great too.

PS: please don't cross post to both vtk lists.

--
____________________________________________________________
Sean McBride, B. Eng                 sean@...
Rogue Research                        www.rogue-research.com
Mac Software Developer              Montréal, Québec, Canada



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers

[David Doria-2]

> Looks like a pretty simple patch.  Do all the tests still pass?  Adding
> new tests with your sample files would be great too.
>
> PS: please don't cross post to both vtk lists.
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng                 sean@...

Sean, thanks for taking a look. I ran an experimental dashboard
submission and everything passed.

The cross-post to the users list was because it seemed reasonable to
let users know about the new file if they want to use it. This is
something that the IJ type article submission that automatically sends
an email to everyone letting them know about new functionality would
be great for.

Thanks,

David
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers

[Sean McBride]

On 10/18/09 11:45 AM, David Doria said:

>Sean, thanks for taking a look. I ran an experimental dashboard
>submission and everything passed.

Great.  Can you file a bug with your patch?  Feel free to assign it to
me.  I'll try it in my working copy in the coming weeks.

>The cross-post to the users list was because it seemed reasonable to
>let users know about the new file if they want to use it. This is
>something that the IJ type article submission that automatically sends
>an email to everyone letting them know about new functionality would
>be great for.

The problem with cross posting is that not everyone is on both lists.
So you risk getting two different threads of replies on two different
lists.  That's not pleasant when it happens.

--
____________________________________________________________
Sean McBride, B. Eng                 sean@...
Rogue Research                        www.rogue-research.com
Mac Software Developer              Montréal, Québec, Canada



_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers

[David Doria-2]

On Sun, Oct 18, 2009 at 10:29 PM, Sean McBride <sean@...> wrote:

> On 10/18/09 11:45 AM, David Doria said:
>
>>Sean, thanks for taking a look. I ran an experimental dashboard
>>submission and everything passed.
>
> Great.  Can you file a bug with your patch?  Feel free to assign it to
> me.  I'll try it in my working copy in the coming weeks.
>
>>The cross-post to the users list was because it seemed reasonable to
>>let users know about the new file if they want to use it. This is
>>something that the IJ type article submission that automatically sends
>>an email to everyone letting them know about new functionality would
>>be great for.
>
> The problem with cross posting is that not everyone is on both lists.
> So you risk getting two different threads of replies on two different
> lists.  That's not pleasant when it happens.
>

I added it to Mantis here: http://public.kitware.com/Bug/view.php?id=9741

It doesn't seem like I am able to assign it to someone? Maybe it is an
access level thing? Can I have 'assignment' access?

Thanks,

David
_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers

[Berk Geveci-2]

I assigned it to Sean. It is up to the developer/manager to assign a
particular bug.

-berk

On Tue, Oct 20, 2009 at 9:46 AM, David Doria <daviddoria+vtk@...> wrote:

> On Sun, Oct 18, 2009 at 10:29 PM, Sean McBride <sean@...> wrote:
>> On 10/18/09 11:45 AM, David Doria said:
>>
>>>Sean, thanks for taking a look. I ran an experimental dashboard
>>>submission and everything passed.
>>
>> Great.  Can you file a bug with your patch?  Feel free to assign it to
>> me.  I'll try it in my working copy in the coming weeks.
>>
>>>The cross-post to the users list was because it seemed reasonable to
>>>let users know about the new file if they want to use it. This is
>>>something that the IJ type article submission that automatically sends
>>>an email to everyone letting them know about new functionality would
>>>be great for.
>>
>> The problem with cross posting is that not everyone is on both lists.
>> So you risk getting two different threads of replies on two different
>> lists.  That's not pleasant when it happens.
>>
>
> I added it to Mantis here: http://public.kitware.com/Bug/view.php?id=9741
>
> It doesn't seem like I am able to assign it to someone? Maybe it is an
> access level thing? Can I have 'assignment' access?
>
> Thanks,
>
> David
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Follow this link to subscribe/unsubscribe:
> http://www.vtk.org/mailman/listinfo/vtk-developers
>
>

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers

[David Doria-2]

On Tue, Oct 20, 2009 at 1:03 PM, Berk Geveci <berk.geveci@...> wrote:

I assigned it to Sean. It is up to the developer/manager to assign a
particular bug.

-berk

While I was looking at this patch, I also found some PLY files I had that still could not be read. The problem is that the header is as follows:

ply
format ascii 1.0
element vertex 182323
property float x
property float y
property float z
property float nx
property float ny
property float nz
property uchar diffuse_red
property uchar diffuse_green
property uchar diffuse_blue

If I change diffuse_red, diffuse_green, diffuse_blue to simply red, green, blue, everything works again. There doesn't seem to be a hard fast "rule" about what to name the colors... should we check for any vertex property that resembles a color array name and read it into RGBPoints? Or should we create a DiffuseRGBPoints?

Should we read the normals (nx,ny,nz)?

I think any time that data is skipped/ignored we should throw a warning. If I was the user and I loaded the data and my normals were missing without any errors/warnings, I'd be very confused. If I got a warning something like "vtkPLYReader does not support vertex property diffuse_red", etc I would at least know that there is a known lack of support for something I am trying to read.

Things are are/aren't supported should also be VERY clearly explained in the documentation.

Thoughts/comments?

Thanks,

David

_______________________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html

Follow this link to subscribe/unsubscribe:
http://www.vtk.org/mailman/listinfo/vtk-developers