warnings with -Wshadow

[Oliver Stöneberg]

Sorry for this rather verbose report, but I thought I add them all. I
was mainly concerned about the global handle thing.

In CRTLSvr.cpp the functions CTRLGetConfigCopy(), CTRLLogEnabled()
and CTRLThreadCountAdd() have a parameter named "hShbCTRL".
Unfortunately there also exists a global variable with the same name
and the same type, that originates in MailSvr.h.
The same problem exists with all the other global SHB_HANDLE
variables and the *Svr.cpp sources. I think the global variables (all
of them not just the ones being shadowed) should be marked somehow as
global as it can be confusing when reading the code.

In AliasDomain.cpp the variable ppszTabTokens is being shadowed in
ADomLookupDomainLK(). The existing one can be removed.

In SMTPSvr.cpp in SMTPHandleCmd_MAIL() the pszSMTPError variable is
shadowed, but I hink this is an easy fix by just removeing the second
ones as it's just used in the errorcases.

In UsrUtils.cpp in the function UsrSetUserInfoVar() the variable pUIV
is being shadowed and I think it can just be reused. In
UsrAliasLookupNameLK() the ppszTabTokens is shaowed and I think the
existing one can be reused as well.

PS: The copyright in 1.26 still shows 2004. Shouldn't that be
updated?
_______________________________________________
xmail mailing list
xmail@...
http://xmailserver.org/mailman/listinfo/xmail

[Davide Libenzi]

On Thu, 15 Oct 2009, Oliver Stöneberg wrote:

> Sorry for this rather verbose report, but I thought I add them all. I
> was mainly concerned about the global handle thing.
>
> In CRTLSvr.cpp the functions CTRLGetConfigCopy(), CTRLLogEnabled()
> and CTRLThreadCountAdd() have a parameter named "hShbCTRL".
> Unfortunately there also exists a global variable with the same name
> and the same type, that originates in MailSvr.h.
> The same problem exists with all the other global SHB_HANDLE
> variables and the *Svr.cpp sources. I think the global variables (all
> of them not just the ones being shadowed) should be marked somehow as
> global as it can be confusing when reading the code.

Will eventually do it later. It is pretty clear what those instances
refers to.

> In AliasDomain.cpp the variable ppszTabTokens is being shadowed in
> ADomLookupDomainLK(). The existing one can be removed.
>
> In SMTPSvr.cpp in SMTPHandleCmd_MAIL() the pszSMTPError variable is
> shadowed, but I hink this is an easy fix by just removeing the second
> ones as it's just used in the errorcases.
>
> In UsrUtils.cpp in the function UsrSetUserInfoVar() the variable pUIV
> is being shadowed and I think it can just be reused. In
> UsrAliasLookupNameLK() the ppszTabTokens is shaowed and I think the
> existing one can be reused as well.

Cleaned those up.



> PS: The copyright in 1.26 still shows 2004. Shouldn't that be
> updated?

Yeah, no really hurry about that :)



- Davide


_______________________________________________
xmail mailing list
xmail@...
http://xmailserver.org/mailman/listinfo/xmail