why does Buildr override invoke and invoke_with_call_chain in Rake::Task?

[Ittay Dror]

Just curious,


Ittay


--
--
Ittay Dror <ittay.dror@...>

[Assaf Arkin]

On Sun, Oct 19, 2008 at 12:12 AM, Ittay Dror <ittay.dror@...> wrote:
> Just curious,

checks for circular dependency:

task 'foo'=>'bar'
task 'bar' do
  task('foo').invoke
end

Assaf

>
>
> Ittay
>
>
> --
> --
> Ittay Dror <ittay.dror@...>
>
>
>

[Alex Boisvert-3]

Might be worth a code comment?

On Mon, Oct 20, 2008 at 9:04 AM, Assaf Arkin <arkin@...> wrote:

> On Sun, Oct 19, 2008 at 12:12 AM, Ittay Dror <ittay.dror@...> wrote:
> > Just curious,
>
> checks for circular dependency:
>
> task 'foo'=>'bar'
> task 'bar' do
>  task('foo').invoke
> end
>
> Assaf
>
> >
> >
> > Ittay
> >
> >
> > --
> > --
> > Ittay Dror <ittay.dror@...>
> >
> >
> >
>

[Assaf Arkin]

On Mon, Oct 20, 2008 at 9:53 AM, Alex Boisvert <boisvert@...> wrote:
> Might be worth a code comment?

added

>
> On Mon, Oct 20, 2008 at 9:04 AM, Assaf Arkin <arkin@...> wrote:
>
>> On Sun, Oct 19, 2008 at 12:12 AM, Ittay Dror <ittay.dror@...> wrote:
>> > Just curious,
>>
>> checks for circular dependency:
>>
>> task 'foo'=>'bar'
>> task 'bar' do
>>  task('foo').invoke
>> end
>>
>> Assaf
>>
>> >
>> >
>> > Ittay
>> >
>> >
>> > --
>> > --
>> > Ittay Dror <ittay.dror@...>
>> >
>> >
>> >
>>
>

[Ittay Dror-2]

Assaf Arkin wrote:

> On Sun, Oct 19, 2008 at 12:12 AM, Ittay Dror <ittay.dror@...> wrote:
>  
>> Just curious,
>>    
>
> checks for circular dependency:
>
> task 'foo'=>'bar'
> task 'bar' do
>   task('foo').invoke
> end
>  

but this code is already in rake (since 0.8.1 at least)

ittay

> Assaf
>
>  
>> Ittay
>>
>>
>> --
>> --
>> Ittay Dror <ittay.dror@...>
>>
>>
>>
>>    
>
>  

--
Ittay Dror <ittayd@...>
Tikal <http://www.tikalk.com>
Tikal Project <http://tikal.sourceforge.net>

[Assaf Arkin]

On Mon, Oct 20, 2008 at 10:39 AM, Ittay Dror <ittayd@...> wrote:

>
>
> Assaf Arkin wrote:
>
>> On Sun, Oct 19, 2008 at 12:12 AM, Ittay Dror <ittay.dror@...> wrote:
>>
>>>
>>> Just curious,
>>>
>>
>> checks for circular dependency:
>>
>> task 'foo'=>'bar'
>> task 'bar' do
>>  task('foo').invoke
>> end
>>
>
> but this code is already in rake (since 0.8.1 at least)

nope.  jim only accepted the portion that deals with prerequisites.

assaf

>
> ittay
>>
>> Assaf
>>
>>
>>>
>>> Ittay
>>>
>>>
>>> --
>>> --
>>> Ittay Dror <ittay.dror@...>
>>>
>>>
>>>
>>>
>>
>>
>
> --
> Ittay Dror <ittayd@...>
> Tikal <http://www.tikalk.com>
> Tikal Project <http://tikal.sourceforge.net>
>
>