wicket trunk: Compilation failure

[Martin Funk]

anyone else bothered by that?

mf

[Juergen Donnerstag]

I just did "maven -Dmaven.test.skip=true clean install" and it
completed successfully (on 1.4 trunk from 18 hrs ago).

-Juergen

On Mon, Jun 22, 2009 at 1:16 PM, Martin Funk<ich@...> wrote:
> anyone else bothered by that?
>
> mf
>

[igor.vaynberg]

compilation failure is in a test class, looks like someone didnt move
the test case. something that would work in eclipse but not with
maven.

http://wicketstuff.org/teamcity/viewLog.html?buildId=4051&tab=buildResultsDiv&buildTypeId=bt2

-igor

On Mon, Jun 22, 2009 at 8:32 AM, Juergen
Donnerstag<juergen.donnerstag@...> wrote:

> I just did "maven -Dmaven.test.skip=true clean install" and it
> completed successfully (on 1.4 trunk from 18 hrs ago).
>
> -Juergen
>
> On Mon, Jun 22, 2009 at 1:16 PM, Martin Funk<ich@...> wrote:
>> anyone else bothered by that?
>>
>> mf
>>
>

[Martin Funk-3]

Beyond that compilation failure I noticed that there are two  
incarnations of org.apache.wicket.WicketTestCase on in wicket and one  
in wicket-extensions. They seem so similar, that I fail to see a  
reason for their double existence.

One more I got. The tests are broken for quite a while now:
http://wicketstuff.org/teamcity/viewType.html?buildTypeId=bt2&tab=buildTypeStatusDiv

Actually I don't really want to be such a pain, but a successful
svn update
mvn clean install
just gives me such a great start in my day that I don't want to miss  
that.

mf

Am 22.06.2009 um 17:39 schrieb Igor Vaynberg:

> compilation failure is in a test class, looks like someone didnt move
> the test case. something that would work in eclipse but not with
> maven.
>
> http://wicketstuff.org/teamcity/viewLog.html?buildId=4051&tab=buildResultsDiv&buildTypeId=bt2
>
> -igor
>
> On Mon, Jun 22, 2009 at 8:32 AM, Juergen
> Donnerstag<juergen.donnerstag@...> wrote:
>> I just did "maven -Dmaven.test.skip=true clean install" and it
>> completed successfully (on 1.4 trunk from 18 hrs ago).
>>
>> -Juergen
>>
>> On Mon, Jun 22, 2009 at 1:16 PM, Martin Funk<ich@...>  
>> wrote:
>>> anyone else bothered by that?
>>>
>>> mf
>>>
>>

[Juergen Donnerstag]

I'll fix it. I added the DatePickerTest to the datetime project over
the weekend. No test case at all existed for that project so far.

Juergen

[igor.vaynberg]

if you dont like failures dont svn up off a trunk :)

-igor

On Mon, Jun 22, 2009 at 9:22 AM, Martin Funk<mafulafunk@...> wrote:

> Beyond that compilation failure I noticed that there are two incarnations of
> org.apache.wicket.WicketTestCase on in wicket and one in wicket-extensions.
> They seem so similar, that I fail to see a reason for their double
> existence.
>
> One more I got. The tests are broken for quite a while now:
> http://wicketstuff.org/teamcity/viewType.html?buildTypeId=bt2&tab=buildTypeStatusDiv
>
> Actually I don't really want to be such a pain, but a successful
> svn update
> mvn clean install
> just gives me such a great start in my day that I don't want to miss that.
>
> mf
>
> Am 22.06.2009 um 17:39 schrieb Igor Vaynberg:
>
>> compilation failure is in a test class, looks like someone didnt move
>> the test case. something that would work in eclipse but not with
>> maven.
>>
>>
>> http://wicketstuff.org/teamcity/viewLog.html?buildId=4051&tab=buildResultsDiv&buildTypeId=bt2
>>
>> -igor
>>
>> On Mon, Jun 22, 2009 at 8:32 AM, Juergen
>> Donnerstag<juergen.donnerstag@...> wrote:
>>>
>>> I just did "maven -Dmaven.test.skip=true clean install" and it
>>> completed successfully (on 1.4 trunk from 18 hrs ago).
>>>
>>> -Juergen
>>>
>>> On Mon, Jun 22, 2009 at 1:16 PM, Martin Funk<ich@...> wrote:
>>>>
>>>> anyone else bothered by that?
>>>>
>>>> mf
>>>>
>>>
>
>

[Martin Funk-3]

yeah, but than its only half of the fun :-)

mf
Am 22.06.2009 um 19:43 schrieb Igor Vaynberg:

> if you dont like failures dont svn up off a trunk :)
>
> -igor
>
> On Mon, Jun 22, 2009 at 9:22 AM, Martin  
> Funk<mafulafunk@...> wrote:
>> Beyond that compilation failure I noticed that there are two  
>> incarnations of
>> org.apache.wicket.WicketTestCase on in wicket and one in wicket-
>> extensions.
>> They seem so similar, that I fail to see a reason for their double
>> existence.
>>
>> One more I got. The tests are broken for quite a while now:
>> http://wicketstuff.org/teamcity/viewType.html?buildTypeId=bt2&tab=buildTypeStatusDiv
>>
>> Actually I don't really want to be such a pain, but a successful
>> svn update
>> mvn clean install
>> just gives me such a great start in my day that I don't want to  
>> miss that.
>>
>> mf
>>
>> Am 22.06.2009 um 17:39 schrieb Igor Vaynberg:
>>
>>> compilation failure is in a test class, looks like someone didnt  
>>> move
>>> the test case. something that would work in eclipse but not with
>>> maven.
>>>
>>>
>>> http://wicketstuff.org/teamcity/viewLog.html?buildId=4051&tab=buildResultsDiv&buildTypeId=bt2
>>>
>>> -igor
>>>
>>> On Mon, Jun 22, 2009 at 8:32 AM, Juergen
>>> Donnerstag<juergen.donnerstag@...> wrote:
>>>>
>>>> I just did "maven -Dmaven.test.skip=true clean install" and it
>>>> completed successfully (on 1.4 trunk from 18 hrs ago).
>>>>
>>>> -Juergen
>>>>
>>>> On Mon, Jun 22, 2009 at 1:16 PM, Martin Funk<ich@...>  
>>>> wrote:
>>>>>
>>>>> anyone else bothered by that?
>>>>>
>>>>> mf
>>>>>
>>>>
>>
>>

[Juergen Donnerstag]

/**
Disabled until we fixed the issue that WicketTestCase or WicketTester
is not available in  other projects. They are in src/test/java. Maven
will create a compile error since in Maven  the test folder is not
exported, which is what we want. We don't want the test cases to be
part of the Wicket distribution jar. In Eclipse it works since all
source folders are exported and you can not disable specific ones.
*/

Juergen

On Mon, Jun 22, 2009 at 8:48 PM, Martin Funk<mafulafunk@...> wrote:

> yeah, but than its only half of the fun :-)
>
> mf
> Am 22.06.2009 um 19:43 schrieb Igor Vaynberg:
>
>> if you dont like failures dont svn up off a trunk :)
>>
>> -igor
>>
>> On Mon, Jun 22, 2009 at 9:22 AM, Martin Funk<mafulafunk@...>
>> wrote:
>>>
>>> Beyond that compilation failure I noticed that there are two incarnations
>>> of
>>> org.apache.wicket.WicketTestCase on in wicket and one in
>>> wicket-extensions.
>>> They seem so similar, that I fail to see a reason for their double
>>> existence.
>>>
>>> One more I got. The tests are broken for quite a while now:
>>>
>>> http://wicketstuff.org/teamcity/viewType.html?buildTypeId=bt2&tab=buildTypeStatusDiv
>>>
>>> Actually I don't really want to be such a pain, but a successful
>>> svn update
>>> mvn clean install
>>> just gives me such a great start in my day that I don't want to miss
>>> that.
>>>
>>> mf
>>>
>>> Am 22.06.2009 um 17:39 schrieb Igor Vaynberg:
>>>
>>>> compilation failure is in a test class, looks like someone didnt move
>>>> the test case. something that would work in eclipse but not with
>>>> maven.
>>>>
>>>>
>>>>
>>>> http://wicketstuff.org/teamcity/viewLog.html?buildId=4051&tab=buildResultsDiv&buildTypeId=bt2
>>>>
>>>> -igor
>>>>
>>>> On Mon, Jun 22, 2009 at 8:32 AM, Juergen
>>>> Donnerstag<juergen.donnerstag@...> wrote:
>>>>>
>>>>> I just did "maven -Dmaven.test.skip=true clean install" and it
>>>>> completed successfully (on 1.4 trunk from 18 hrs ago).
>>>>>
>>>>> -Juergen
>>>>>
>>>>> On Mon, Jun 22, 2009 at 1:16 PM, Martin Funk<ich@...> wrote:
>>>>>>
>>>>>> anyone else bothered by that?
>>>>>>
>>>>>> mf
>>>>>>
>>>>>
>>>
>>>
>
>

[James Carman-3]

It's bad practice to check in code that "breaks the build" regardless
of where which branch (or trunk) it's checked into.  The code can be
incomplete and not work correctly, but it definitely shouldn't break
the build.  I'm not trying to be all "holier-than-thou" or anything.
I've broken our build at work many times (I've always had a good
excuse ;)!  The point is that it shouldn't be an expectation that the
trunk's build fails on a regular basis ("don't svn up off a trunk").
It should hopefully be (and is with the Wicket project) a pretty rare
occurrence.  I think it's great that the Wicket community has users
who are able and willing to live on the "bleeding edge."  I'm sure
Igor was kidding (since he put a little smiley face), but I just
wanted to make sure. :)

On Mon, Jun 22, 2009 at 1:43 PM, Igor Vaynberg <igor.vaynberg@...> wrote:

>
> if you dont like failures dont svn up off a trunk :)
>
> -igor
>
> On Mon, Jun 22, 2009 at 9:22 AM, Martin Funk<mafulafunk@...> wrote:
> > Beyond that compilation failure I noticed that there are two incarnations of
> > org.apache.wicket.WicketTestCase on in wicket and one in wicket-extensions.
> > They seem so similar, that I fail to see a reason for their double
> > existence.
> >
> > One more I got. The tests are broken for quite a while now:
> > http://wicketstuff.org/teamcity/viewType.html?buildTypeId=bt2&tab=buildTypeStatusDiv
> >
> > Actually I don't really want to be such a pain, but a successful
> > svn update
> > mvn clean install
> > just gives me such a great start in my day that I don't want to miss that.
> >
> > mf
> >
> > Am 22.06.2009 um 17:39 schrieb Igor Vaynberg:
> >
> >> compilation failure is in a test class, looks like someone didnt move
> >> the test case. something that would work in eclipse but not with
> >> maven.
> >>
> >>
> >> http://wicketstuff.org/teamcity/viewLog.html?buildId=4051&tab=buildResultsDiv&buildTypeId=bt2
> >>
> >> -igor
> >>
> >> On Mon, Jun 22, 2009 at 8:32 AM, Juergen
> >> Donnerstag<juergen.donnerstag@...> wrote:
> >>>
> >>> I just did "maven -Dmaven.test.skip=true clean install" and it
> >>> completed successfully (on 1.4 trunk from 18 hrs ago).
> >>>
> >>> -Juergen
> >>>
> >>> On Mon, Jun 22, 2009 at 1:16 PM, Martin Funk<ich@...> wrote:
> >>>>
> >>>> anyone else bothered by that?
> >>>>
> >>>> mf
> >>>>
> >>>
> >
> >