Nabble - xine-devel

[PATCH] vdpau_mpeg12 pts fix

2009-11-23T17:51:40Z

Fixes audio/video sync in mpeg12 streams.
Applies to xine-lib-1.2-vdpau

--
Christophe Thommeret

[vdpau_mpeg12_pts_fix.diff]

diff -r d6d147bfa789 src/video_dec/libvdpau/vdpau_mpeg12.c --- a/src/video_dec/libvdpau/vdpau_mpeg12.c Sun Nov 22 23:51:02 2009 +0000 +++ b/src/video_dec/libvdpau/vdpau_mpeg12.c Tue Nov 24 02:49:59 2009 +0100 @@ -794,7 +794,8 @@ if ( !buf->size ) return; - seq->cur_pts = buf->pts; + if ( buf->pts ) + seq->cur_pts = buf->pts; int size = seq->bufpos+buf->size; if ( seq->bufsize < size ) {

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

xine library (Alsa plug-in) doen't support to write to a NULL PCM device

2009-11-23T02:12:22Z

Hi all,

I am porting opie mediaplayer2 using libxine1.1.16.3-r1. I configure my mediaplayer2 to used alsa plug-in from libxine.
My opie mediaplayer2 now can play mp3 file using libxine and direct pcm stream to a real hardware pcm device.
Now i want to direct the pcm stream to another pc over ethernet port. So i modify the /etc/asound.conf to direct the pcm stream to a PCM null device

My /etc/asound.conf is below
# default dmix configuration

pcm.!default {
    type file
    slave { pcm mynull }
    file "| /dragon/bin/audio_client 192.168.8.2"
    format "raw"
}

pcm.mynull{
    type null
}

My program can direct the sound over network when play another program such as aplay (which doesn't use libxine)

"# aplay example.mp3"
but it fail with
"# opieplayer2 example.mp3"

My question is how can the libxine support to write to a Null pcm device ?

==================================
Below is some thing that i capture from console

opieplayer2 example.mp3

: waiting for initialization thread to finish
: Lib::run() finished
: initialization thread finished!
audio_alsa_out: Audio Device name = default
audio_alsa_out: Number of channels = 2
opieplayer2: pcm_null.c:142: snd_pcm_null_drop: Assertion `null->state != SND_PC
M_STATE_OPEN' failed.
===================================

Thanks in advanced
Tung

Re: Forbidden to access parts of Bugzilla

2009-11-21T04:32:03Z

Il giorno Wed, 18/11/2009 alle 22.49 +0000, Darren Salt ha scritto:

>
>
> >> Forbidden
> >> You don't have permission to access /buglist.cgi on this server.
> >> ----------------------------------------------------------------
> >> Server at bugs.xine-project.org Port 80
>
> Looks like '&' no longer works for parameter separation. ';' works
> fine,
> though...
>

Sorry, a stupid mod_security rule I forgot to disable :( fixed now!

--
Diego Elio Pettenò — “Flameeyes”
http://blog.flameeyes.eu/

If you found a .asc file in this mail and know not what it is,
it's a GnuPG digital signature: http://www.gnupg.org/

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: Forbidden to access parts of Bugzilla

2009-11-18T14:49:36Z

I demand that Matt Kraai may or may not have written...

> When I try to access some parts of Bugzilla at
> http://bugs.xine-project.org/
> (e.g., when I click on the My Bugs link on that page), I receive a 403
> Forbidden error:

>> Forbidden
>> You don't have permission to access /buglist.cgi on this server.
>> ----------------------------------------------------------------
>> Server at bugs.xine-project.org Port 80

Looks like '&' no longer works for parameter separation. ';' works fine,
though...

--
| Darren Salt | linux at youmustbejoking | nr. Ashington, | Doon
| using Debian GNU/Linux | or ds ,demon,co,uk | Northumberland | Army
| + http://www.youmustbejoking.demon.co.uk/ & http://tartarus.org/ds/

You will need something shortly after throwing it away.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

SIGSEGV while playing MOV file

2009-11-16T14:29:46Z

Hi,

xine has started to SIGSEGV whenever I try to play certain MOV files. This is the backtrace:

(gdb) where
#0 0xb6505087 in ?? () from /usr/lib/i686/libavcodec.so.52
#1 0xb652d76a in ?? () from /usr/lib/i686/libavcodec.so.52
#2 0xb6379176 in avcodec_decode_video () from /usr/lib/i686/libavcodec.so.52
#3 0xb6b0cfc5 in ff_handle_buffer (buf=<value optimized out>,
this=<value optimized out>) at ff_video_decoder.c:1252
#4 ff_decode_data (buf=<value optimized out>, this=<value optimized out>)
at ff_video_decoder.c:1503
#5 0xb7fa5587 in video_decoder_loop (stream_gen=0x89ce110)
at video_decoder.c:382
#6 0x4407b935 in start_thread () from /lib/libpthread.so.0
#7 0x43fb094e in clone () from /lib/libc.so.6

This is using xine-lib 1.1.16.3hg from the repository, linked against the ffmpeg packages from Fedora 11:

ffmpeg-devel-0.5-3.fc11.i586
ffmpeg-libs-0.5-3.fc11.i586

I have a fragment of a MOV file that reproduces the problem (100K) that I can send to anyone who is interested. The end of the verbose log looks like this:

load_plugins: probing demux 'quicktime'
xine: found demuxer plugin: Apple Quicktime (MOV) and MPEG-4 demux plugin
video discontinuity #1, type is 0, disc_off 0
waiting for audio discontinuity #1
audio discontinuity #1, type is 0, disc_off 0
waiting for in_discontinuity update #1
current time : 14386
vpts adjusted with prebuffer to 26386
load_plugins: plugin ffmpegvideo will be used for video streamtype 25.
load_plugins: plugin mad will be used for audio streamtype 01.
av_offset=0 pts
spu_offset=0 pts
xine_play
video discontinuity #2, type is 3, disc_off 0
waiting for audio discontinuity #2
audio discontinuity #2, type is 3, disc_off 0
waiting for in_discontinuity update #2
current time : 16675
vpts adjusted with prebuffer to 28675
ffmpeg_video_dec: direct rendering enabled
audio_alsa_out:open pause_resume=1
output sample rate 44100
audio jump, diff=-7
xiTK received SIGSEGV signal, RIP.

Cheers,
Chris

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: Where should the code for my new post-plugin code go (and another plugin question)?

2009-11-16T14:11:50Z

Hello Morten,

I've been on xine-devel mailing list for ages; and today I've been wondering
about this approach myself. I was planning on starting, but thought to look
through the mailinglist.

I wonder how far you've been and if you have anything i can start/work further
on. I'd like to see and use this code (I assure you, it is only for personal
usage. plus, my LCDproc setup is quite different than standard so...

Anything you have, it doesn't have to build, would be extremely usefull to me.

Kind regards,

Maarten

Op woensdag 18 juli 2007 21:34:20 schreef Morten Egelund Rasmussen:

> Hi all!
>
> I am coding on a post-plugin for xine that sends the current stream
> status to LCDproc, so it is visible on any LCD display that people
> might have attached.
>
> I am aware that this plugin might only be interesting to a relative
> small percentage of all xine users out there, which might be a thing
> to take into consideration with the following.
>
> My question: Where should I submit my code to when it's finally done?
> -- Will it go into the official xine CVS somewhere, or is it something
> that I should make available elsewhere as a 3rd party plugin?
>
> Another question: when I test my plugin now, I have to enable the
> plugin with the "--post" command-line option. Is there a way to make
> the engine load it automatically without this option?
>
> Cheers,
> ~Morten :-)
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> xine-devel mailing list
> xine-devel@...
> https://lists.sourceforge.net/lists/listinfo/xine-devel
>

--
AL13N is my name and head-biting is my game.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: New demuxer/decoder for SBC encoded stream, sound is breadking

2009-11-15T09:32:41Z

Hossain Reja wrote:

>
> James Courtier-Dutton wrote:
>
>> Hossain Reja wrote:
>>
>>> I'm developing a demumxer/decoder in xine framework for SBC encoded audio
>>> stream. To make it simple for now, in the demuxer reading the data from
>>> input plugin I'm developing a demuxer/decoder in xine ramework for SBC
>>> encoded audio stream. To make it simple for now, in the demuxer reading
>>> the
>>> data from input plugin (fifo in this case) and sending it to decoder as
>>> 8K
>>> chunks. The decoder decode the data and send it to audio in audio buffer
>>> 8K
>>> at a time. It palys the audio, but I hear there is gap between audio
>>> frames.
>>> I did the following experiments:
>>> 1. I captured the decoded data at decoder after decoding and stored it in
>>> a
>>> file with WAVE header, and played that with aplay. It plays perfect,
>>> meaning
>>> the decoding was right. I did the same this before it is sent to
>>> audio_ouput
>>> and it plays perfect.
>>> 2. I measured the time interval at which demuxer (send_chunk)is being
>>> called
>>> and I observed that it's being called at around 400ms-500ms (while
>>> sending
>>> 8K chunks).Observe the same amount of time interval for decoder
>>> (decode_data
>>> function).
>>>
>>> I'm new to xine and any help will be highly appreciated.
>>> Please let me know if any other information is required.
>>>
>>>
>> Please post a patch so we can see what is going wrong.
>> My guess is that if you instead send 2k at a time from the demuxer and
>> then 2k from the decoder, it might work better.
>> I.e. Use smaller chunks.
>>
>> Kind Regards
>>
>> James
>>
>> 14.Nov.2009
>> ==========
>>
>> Hello James,
>> Thanks for your response.
>> I tried with small chunk sizes (<=2K), but I hear that sound is breaking
>> in shorter interval than that of 8K chunk size.
>>
>> I collected data at following conditions and observed that there is a
>> delay in calling execution time in processing of data: Please note the
>> following:
>>
>> 1) demux_xxx_send_chunk just reads the data from input of size 8K plug-in
>> (fifo) in local buffer, does not send it to decoder. Time measured to
>> execute demux_xxx_send_chunk is just 40-50us (micro seconds). I tried
>> lower chunks too and time is around same.
>> 2) demux_xxx_send_chunk reads the data from input of size 8K plug-in
>> (fifo) in local buffer, sends it to decoder; decoder does not decode it
>> and does not send to ao_loop for processing. Time measured to execute
>> demux_xxx_send_chunk is just 40-50us. I tried lower chunks too and time is
>> around same.
>> 3) demux_xxx_send_chunk reads the data from input of size 8K plug-in
>> (fifo) in local buffer, sends it to decoder; decoder decodes it but does
>> not send to ao_loop for processing. Time measured to execute
>> demux_xxx_send_chunk is just 3000us. I tried lower chunks too and time is
>> around same.
>> 4) Now when decoder sends the decoded PCM data to ao_loop, the time
>> measured to execute demux_xxx_send_chunk is whopping 420000us. For smaller
>> size lets say 1K it is around 200000us.
>>
>> Please also note that the vpts at decoder is set to 0 before sending it to
>> ao_loop. I tried other calculations, but the effect is same as of vpts=0;
>>
>> Unfortunately, I cannot upload the patch.
>>
>> Let me know if you need any other info.
>>
>> Thanks in advance for your comments.
>>
>> Best Regards,
>> Hossain
>>
>>

Unfortunately, without a patch to look at, I cannot help you further.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: New demuxer/decoder for SBC encoded stream, sound is breadking

2009-11-14T06:13:46Z

James Courtier-Dutton wrote:

Hossain Reja wrote:
> I'm developing a demumxer/decoder in xine framework for SBC encoded audio
> stream. To make it simple for now, in the demuxer reading the data from
> input plugin I'm developing a demuxer/decoder in xine ramework for SBC
> encoded audio stream. To make it simple for now, in the demuxer reading the
> data from input plugin (fifo in this case) and sending it to decoder as 8K
> chunks. The decoder decode the data and send it to audio in audio buffer 8K
> at a time. It palys the audio, but I hear there is gap between audio frames.
> I did the following experiments:
> 1. I captured the decoded data at decoder after decoding and stored it in a
> file with WAVE header, and played that with aplay. It plays perfect, meaning
> the decoding was right. I did the same this before it is sent to audio_ouput
> and it plays perfect.
> 2. I measured the time interval at which demuxer (send_chunk)is being called
> and I observed that it's being called at around 400ms-500ms (while sending
> 8K chunks).Observe the same amount of time interval for decoder (decode_data
> function).
>
> I'm new to xine and any help will be highly appreciated.
> Please let me know if any other information is required.
>
Please post a patch so we can see what is going wrong.
My guess is that if you instead send 2k at a time from the demuxer and
then 2k from the decoder, it might work better.
I.e. Use smaller chunks.

Kind Regards

James

14.Nov.2009
==========

Hello James,
Thanks for your response.
I tried with small chunk sizes (<=2K), but I hear that sound is breaking in shorter interval than that of 8K chunk size.

I collected data at following conditions and observed that there is a delay in calling execution time in processing of data: Please note the following:

1) demux_xxx_send_chunk just reads the data from input of size 8K plug-in (fifo) in local buffer, does not send it to decoder. Time measured to execute demux_xxx_send_chunk is just 40-50us (micro seconds). I tried lower chunks too and time is around same.
2) demux_xxx_send_chunk reads the data from input of size 8K plug-in (fifo) in local buffer, sends it to decoder; decoder does not decode it and does not send to ao_loop for processing. Time measured to execute demux_xxx_send_chunk is just 40-50us. I tried lower chunks too and time is around same.
3) demux_xxx_send_chunk reads the data from input of size 8K plug-in (fifo) in local buffer, sends it to decoder; decoder decodes it but does not send to ao_loop for processing. Time measured to execute demux_xxx_send_chunk is just 3000us. I tried lower chunks too and time is around same.
4) Now when decoder sends the decoded PCM data to ao_loop, the time measured to execute demux_xxx_send_chunk is whopping 420000us. For smaller size lets say 1K it is around 200000us.

Please also note that the vpts at decoder is set to 0 before sending it to ao_loop. I tried other calculations, but the effect is same as of vpts=0;

Unfortunately, I cannot upload the patch.

Let me know if you need any other info.

Thanks in advance for your comments.

Best Regards,
Hossain

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: New demuxer/decoder for SBC encoded stream, sound is breadking

2009-11-11T13:23:15Z

Hossain Reja wrote:

> I'm developing a demumxer/decoder in xine framework for SBC encoded audio
> stream. To make it simple for now, in the demuxer reading the data from
> input plugin I'm developing a demuxer/decoder in xine ramework for SBC
> encoded audio stream. To make it simple for now, in the demuxer reading the
> data from input plugin (fifo in this case) and sending it to decoder as 8K
> chunks. The decoder decode the data and send it to audio in audio buffer 8K
> at a time. It palys the audio, but I hear there is gap between audio frames.
> I did the following experiments:
> 1. I captured the decoded data at decoder after decoding and stored it in a
> file with WAVE header, and played that with aplay. It plays perfect, meaning
> the decoding was right. I did the same this before it is sent to audio_ouput
> and it plays perfect.
> 2. I measured the time interval at which demuxer (send_chunk)is being called
> and I observed that it's being called at around 400ms-500ms (while sending
> 8K chunks).Observe the same amount of time interval for decoder (decode_data
> function).
>
> I'm new to xine and any help will be highly appreciated.
> Please let me know if any other information is required.
>

Please post a patch so we can see what is going wrong.
My guess is that if you instead send 2k at a time from the demuxer and
then 2k from the decoder, it might work better.
I.e. Use smaller chunks.

Kind Regards

James

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

New demuxer/decoder for SBC encoded stream, sound is breadking

2009-11-11T08:33:31Z

I'm developing a demumxer/decoder in xine framework for SBC encoded audio stream. To make it simple for now, in the demuxer reading the data from input plugin I'm developing a demuxer/decoder in xine ramework for SBC encoded audio stream. To make it simple for now, in the demuxer reading the data from input plugin (fifo in this case) and sending it to decoder as 8K chunks. The decoder decode the data and send it to audio in audio buffer 8K at a time. It palys the audio, but I hear there is gap between audio frames.
I did the following experiments:
1. I captured the decoded data at decoder after decoding and stored it in a file with WAVE header, and played that with aplay. It plays perfect, meaning the decoding was right. I did the same this before it is sent to audio_ouput and it plays perfect.
2. I measured the time interval at which demuxer (send_chunk)is being called and I observed that it's being called at around 400ms-500ms (while sending 8K chunks).Observe the same amount of time interval for decoder (decode_data function).

I'm new to xine and any help will be highly appreciated.
Please let me know if any other information is required.

Forbidden to access parts of Bugzilla

2009-11-08T06:20:53Z

Hi,

When I try to access some parts of Bugzilla at

http://bugs.xine-project.org/

(e.g., when I click on the My Bugs link on that page), I receive a 403
Forbidden error:

> Forbidden
>
> You don't have permission to access /buglist.cgi on this server.
>
> ----------------------------------------------------------------
>
> Server at bugs.xine-project.org Port 80

--
Matt http://ftbfs.org/kraai

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: Unable to play .PNG file using xine

2009-11-04T05:04:15Z

Hi,

In FFMpeg Configuration, there is no such option like gdkpixbuf.

Roger Scott-2 wrote:

> Hi,
>
> I am using Xine Library version 1.1.16.2 in Fedora. I also installed FFMpeg.
> Now whenever I want to play a .PNG file Xine gives me the error "No Demuxer
> Plaugin found".
>
> How can I play .png or .gif file in Xine?

I needed the gdk-pixbuf stuff installed and then it worked. Not sure how a different ffmpeg would change that (perhaps it disable/overrides gdk-pixbuf). I suspect it's a configure thing which isn't automatically detecting. Try tweaking the --enable... options (eg --enable-gdkpixbuf). Also make sure you're getting the image demuxer installed as part of the configure.

Roger.

_________________________________________________________________
Looking for a date? View photos of singles in your area!
http://clk.atdmt.com/NMN/go/150855801/direct/01/
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel

Regards,
Debsu

Re: Unable to play .PNG file using xine

2009-11-04T01:35:23Z

Hi Paul,

Doesn't matter, xine lib is able to play image as well as movie. I tested in in FC6.

Paul Menzel-3 wrote:

Dear Debsu,

Am Dienstag, den 03.11.2009, 07:32 -0800 schrieb Debsu:
> I am using Xine Library version 1.1.16.2 in Fedora. I also installed FFMpeg.
> Now whenever I want to play a .PNG file Xine gives me the error "No Demuxer
> Plaugin found".
>
> How can I play .png or .gif file in Xine?

As far as I know PNG and GIF are image formats and not movie formats. So
you should use an image viewer or convert them to a movie format.

> -----

If you want to mark your signature this way, you need to use just two
hyphens, so that the mail program removes it automatically.

> Regards,
> Debsu

Thanks,

Paul

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel

Regards,
Debsu

Re: Unable to play .PNG file using xine

2009-11-03T13:22:11Z

> Hi,
>
> I am using Xine Library version 1.1.16.2 in Fedora. I also installed FFMpeg.
> Now whenever I want to play a .PNG file Xine gives me the error "No Demuxer
> Plaugin found".
>
> How can I play .png or .gif file in Xine?

I needed the gdk-pixbuf stuff installed and then it worked. Not sure how a different ffmpeg would change that (perhaps it disable/overrides gdk-pixbuf). I suspect it's a configure thing which isn't automatically detecting. Try tweaking the --enable... options (eg --enable-gdkpixbuf). Also make sure you're getting the image demuxer installed as part of the configure.

Roger.

View photos of singles in your area! Looking for a date?
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: Unable to play .PNG file using xine

2009-11-03T09:36:22Z

Dear Debsu,

Am Dienstag, den 03.11.2009, 07:32 -0800 schrieb Debsu:
> I am using Xine Library version 1.1.16.2 in Fedora. I also installed FFMpeg.
> Now whenever I want to play a .PNG file Xine gives me the error "No Demuxer
> Plaugin found".
>
> How can I play .png or .gif file in Xine?

As far as I know PNG and GIF are image formats and not movie formats. So
you should use an image viewer or convert them to a movie format.

> -----

If you want to mark your signature this way, you need to use just two
hyphens, so that the mail program removes it automatically.

> Regards,
> Debsu

Thanks,

Paul

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

signature.asc (205 bytes) Download Attachment

Unable to play .PNG file using xine

2009-11-03T07:35:27Z

Hi,

I am using Xine Library version 1.1.16.2 in Fedora. I also installed FFMpeg. Now whenever I want to play a .PNG file Xine gives me the error "No Demuxer Plaugin found".

How can I play .png or .gif file in Xine?

Regards,
Debsu

Unable to play .PNG file using xine

2009-11-03T07:32:29Z

Regards,
Debsu

Re: [PATCH] Fix buffer overflow in demux_mpeg_block.c

2009-11-03T07:22:19Z

> I'd also remove this->scratch unless there is some weird reason to keep
> it.

Attached (untested) patch.

- Petri

[9835-demux_mpeg_block.c-buffer_overflow_v2.diff]

# HG changeset patch # User Petri Hintukainen <phintuka@...> # Date 1257261327 -7200 # Node ID 761f7a5a77d0e129f815b7fe3f81f8072404c7a0 # Parent 898baed1012ada88a6b8522f1f3d95f04815f556 Fixed buffer overflow. Removed scratch buffer from demux_mpeg_block_s. diff -r 898baed1012a -r 761f7a5a77d0 src/demuxers/demux_mpeg_block.c --- a/src/demuxers/demux_mpeg_block.c Sun Oct 25 14:08:00 2009 +0000 +++ b/src/demuxers/demux_mpeg_block.c Tue Nov 03 17:15:27 2009 +0200 @@ -69,9 +69,6 @@ char cur_mrl[256]; - uint8_t *scratch; - void *scratch_base; - int64_t nav_last_end_pts; int64_t nav_last_start_pts; int64_t last_pts[2]; @@ -1176,7 +1173,6 @@ demux_mpeg_block_t *this = (demux_mpeg_block_t *) this_gen; - free (this->scratch_base); free (this); } @@ -1189,18 +1185,19 @@ static int demux_mpeg_detect_blocksize(demux_mpeg_block_t *this, input_plugin_t *input) { + uint8_t scratch[4]; input->seek(input, 2048, SEEK_SET); - if (input->read(input, this->scratch, 4) != 4) + if (input->read(input, scratch, 4) != 4) return 0; - if (this->scratch[0] || this->scratch[1] - || (this->scratch[2] != 0x01) || (this->scratch[3] != 0xba)) { + if (scratch[0] || scratch[1] + || (scratch[2] != 0x01) || (scratch[3] != 0xba)) { input->seek(input, 2324, SEEK_SET); - if (input->read(input, this->scratch, 4) != 4) + if (input->read(input, scratch, 4) != 4) return 0; - if (this->scratch[0] || this->scratch[1] - || (this->scratch[2] != 0x01) || (this->scratch[3] != 0xba)) + if (scratch[0] || scratch[1] + || (scratch[2] != 0x01) || (scratch[3] != 0xba)) return 0; return 2324; @@ -1385,7 +1382,6 @@ this->demux_plugin.get_optional_data = demux_mpeg_block_get_optional_data; this->demux_plugin.demux_class = class_gen; - this->scratch = xine_xmalloc_aligned (512, 4096, &this->scratch_base); this->status = DEMUX_FINISHED; lprintf ("open_plugin:detection_method=%d\n", @@ -1397,13 +1393,14 @@ /* use demux_mpeg for non-block devices */ if (!(input->get_capabilities(input) & INPUT_CAP_BLOCK)) { - free (this->scratch_base); free (this); return NULL; } if (((input->get_capabilities(input) & INPUT_CAP_SEEKABLE) != 0) ) { + uint8_t scratch[5] = {0xff, 0xff, 0xff, 0xff, 0xff}; /* result of input->read() won't matter */ + this->blocksize = input->get_blocksize(input); lprintf("open_plugin:blocksize=%d\n",this->blocksize); @@ -1411,29 +1408,25 @@ this->blocksize = demux_mpeg_detect_blocksize( this, input ); if (!this->blocksize) { - free (this->scratch_base); free (this); return NULL; } input->seek(input, 0, SEEK_SET); - memset (this->scratch, 255, 5); /* result of input->read() won't matter */ - if (input->read(input, this->scratch, this->blocksize)) { + if (input->read(input, scratch, 5)) { lprintf("open_plugin:read worked\n"); - if (this->scratch[0] || this->scratch[1] - || (this->scratch[2] != 0x01) || (this->scratch[3] != 0xba)) { + if (scratch[0] || scratch[1] + || (scratch[2] != 0x01) || (scratch[3] != 0xba)) { lprintf("open_plugin:scratch failed\n"); - free (this->scratch_base); free (this); return NULL; } /* if it's a file then make sure it's mpeg-2 */ if ( !input->get_blocksize(input) - && ((this->scratch[4]>>4) != 4) ) { - free (this->scratch_base); + && ((scratch[4]>>4) != 4) ) { free (this); return NULL; } @@ -1447,7 +1440,6 @@ break; } } - free (this->scratch_base); free (this); return NULL; } @@ -1468,7 +1460,6 @@ ending = strrchr(mrl, '.'); if (!ending) { - free (this->scratch_base); free (this); return NULL; } @@ -1478,7 +1469,6 @@ this->blocksize = 2048; demux_mpeg_block_accept_input(this, input); } else { - free (this->scratch_base); free (this); return NULL; } @@ -1496,7 +1486,6 @@ this->blocksize = demux_mpeg_detect_blocksize( this, input ); if (!this->blocksize) { - free (this->scratch_base); free (this); return NULL; } @@ -1506,7 +1495,6 @@ break; default: - free (this->scratch_base); free (this); return NULL; }

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

[PATCH] Fix buffer overflow in demux_mpeg_block.c

2009-11-03T07:06:00Z

Patch attached.

I'd also remove this->scratch unless there is some weird reason to keep
it. Local buffers in demux_mpeg_detect_blocksize() [4 bytes] and
open_plugin [4096 bytes] should do the same ... ?

- Petri

[9835-demux_mpeg_block.c-buffer_overflow.diff]

# HG changeset patch # User Petri Hintukainen <phintuka@...> # Date 1257260200 -7200 # Node ID 61fcc6e682a4db817461e3c825589a2c41ec71dd # Parent 898baed1012ada88a6b8522f1f3d95f04815f556 Fixed buffer overflow: input->read(input, this->scratch, this->blocksize) overflows if input plugin block size is larger than 4096. diff -r 898baed1012a -r 61fcc6e682a4 src/demuxers/demux_mpeg_block.c --- a/src/demuxers/demux_mpeg_block.c Sun Oct 25 14:08:00 2009 +0000 +++ b/src/demuxers/demux_mpeg_block.c Tue Nov 03 16:56:40 2009 +0200 @@ -43,6 +43,7 @@ #define NUM_PREVIEW_BUFFERS 250 #define DISC_TRESHOLD 90000 +#define MAX_BLOCK_SIZE 4096 #define WRAP_THRESHOLD 120000 #define PTS_AUDIO 0 @@ -1385,7 +1386,7 @@ this->demux_plugin.get_optional_data = demux_mpeg_block_get_optional_data; this->demux_plugin.demux_class = class_gen; - this->scratch = xine_xmalloc_aligned (512, 4096, &this->scratch_base); + this->scratch = xine_xmalloc_aligned (512, MAX_BLOCK_SIZE, &this->scratch_base); this->status = DEMUX_FINISHED; lprintf ("open_plugin:detection_method=%d\n", @@ -1410,7 +1411,7 @@ if (!this->blocksize) this->blocksize = demux_mpeg_detect_blocksize( this, input ); - if (!this->blocksize) { + if (!this->blocksize || this->blocksize > MAX_BLOCK_SIZE) { free (this->scratch_base); free (this); return NULL;

Re: Application crashes during playing MPEG file using xine

2009-10-28T04:21:49Z

Debsu wrote:
> Hi Darren,
>
> Thanks a lot for pointing out the problem. If you can tell me the way to
> resolve this, that will be very much appreciable.
>

Take the problem to the xorg@... and ask there.
Something like this is already being discussed at the moment.

Barry

> Regards,
> Deb
>
> Darren Salt wrote:
>
>> I demand that Debsu may or may not have written...
>>
>>
>>> My application crashes while playing video file using Xine library. It
>>> gives the following error after crash:
>>>
>>> MY_APP: xcbio.c:176 : process responses: Assertion (...) failed.
>>>
>> That's an X problem.
>>
>> --
>> | Darren Salt | linux at youmustbejoking | nr. Ashington, |
>> Doon
>> | using Debian GNU/Linux | or ds ,demon,co,uk | Northumberland |
>> Army
>> | + Use more efficient products. Use less. BE MORE ENERGY
>> EFFICIENT.
>>
>> Help! I'm trapped inside an Amdahl 580!
>>
>> ------------------------------------------------------------------------------
>> Come build with us! The BlackBerry(R) Developer Conference in SF, CA
>> is the only developer event you need to attend this year. Jumpstart your
>> developing skills, take BlackBerry mobile applications to market and stay
>> ahead of the curve. Join us from November 9 - 12, 2009. Register now!
>> http://p.sf.net/sfu/devconference
>> _______________________________________________
>> xine-devel mailing list
>> xine-devel@...
>> https://lists.sourceforge.net/lists/listinfo/xine-devel
>>
>>
>>
>
>
> -----
> Regards,
> Debsu
>

Re: Application crashes during playing MPEG file using xine

2009-10-26T21:37:15Z

Hi Darren,

Thanks a lot for pointing out the problem. If you can tell me the way to resolve this, that will be very much appreciable.

Regards,
Deb

Darren Salt wrote:

I demand that Debsu may or may not have written...

> My application crashes while playing video file using Xine library. It
> gives the following error after crash:

> MY_APP: xcbio.c:176 : process responses: Assertion (...) failed.

That's an X problem.

--
| Darren Salt | linux at youmustbejoking | nr. Ashington, | Doon
| using Debian GNU/Linux | or ds ,demon,co,uk | Northumberland | Army
| + Use more efficient products. Use less. BE MORE ENERGY EFFICIENT.

Help! I'm trapped inside an Amdahl 580!

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
xine-devel mailing list
xine-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/xine-devel

Regards,
Debsu

Re: Application crashes during playing MPEG file using xine

2009-10-26T10:32:40Z

I demand that Debsu may or may not have written...

> My application crashes while playing video file using Xine library. It
> gives the following error after crash:

> MY_APP: xcbio.c:176 : process responses: Assertion (...) failed.

That's an X problem.

--
| Darren Salt | linux at youmustbejoking | nr. Ashington, | Doon
| using Debian GNU/Linux | or ds ,demon,co,uk | Northumberland | Army
| + Use more efficient products. Use less. BE MORE ENERGY EFFICIENT.

Help! I'm trapped inside an Amdahl 580!

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Application crashes during playing MPEG file using xine

2009-10-26T10:00:11Z

Hi All,

My application crashes while playing video file using Xine library. It gives the following error after crash:
MY_APP: xcbio.c:176 : process responses: Assertion (...) failed.

Can anyone tell me what should I do?

Thanks in advance.

Regards,
Debsu

XML Lexer bug fix

2009-10-13T09:36:17Z

Heya,

Could somebody please review the patch at:
http://bugs.xine-project.org/show_bug.cgi?id=281

I'd like to keep totem-pl-parser' code as close as possible to the
upstream xine-lib code, and a Rhythmbox contributor pushed the above
patch.

Cheers

------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

xine_play / xine_get_pos_length woes

2009-09-26T05:05:45Z

hi,

i'm currently developing an application for a project where i use lib-xine
(which is really great btw). however, i encountered one strange behaviour.

background: i need to know the length of a stream actually before i play
it to do some calculations. so if the streams provides a length i'd like to
know it. everything works fine when i open the mrl for the first time and
then ask using get_pos_length for the stream length. but when i open the
stream for the second time (after closing it of course) i alwass get 0 as
length and the correct length is not reported until i started playing the
stream.

some pseudo code:

loop:
xine_open("file.mp3");
xine_get_pos_len(); <-- in the first loop returns correct information,
afterwards it's 0
... do some calculations with length
xine_play();
... wait till finished playing
xine_close();
goto loop

i'm a little bit stuck here since i don't know how to get the length
before starting to play. i'm going to cache the length for now, but i feel
this is not the perfect way to go. so maybe someone know anything that
helps; maybe it's even a bug - i don't know, but i'd like to ;)

thanks and regards,

frank

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: [xine-user] Blu-Ray patch not working

2009-09-24T07:13:45Z

Petri Hintukainen wrote:
> Darren Salt wrote:
> > I've extracted the patches and added them (with minor tweaks) to the 1.1
> > patch queue.
>
> I'm also adding VC-1 video support, but there are some problems in
> ff_video_decoder.c. Opening ffmpeg VC-1 decoder fails and xine-lib
> ffmpeg wrapper plugin segfaults quite soon after that.

There are two tricks to make VC1 decoding work:
1) VC1 sequence and entry point headers must be present in
context->extradata.
2) video width and height must be known when opening decoder.

Some container formats store required extra data, but mpeg-ts does not.

1) is fixed by scanning the stream for headers and discarding all data
until proper headers are found.

2) is fixed by re-opening decoder with width and height information from
first open.

Proposed patches are attached. Any comments ?

- Petri

[xine-lib-1.1.16.3-ffmpeg-vc1-extradata.diff]

--- src/combined/ffmpeg/ff_video_decoder.c 2009-04-16 14:24:20.000000000 +0300 +++ src/combined/ffmpeg/ff_video_decoder.c 2009-09-24 15:21:25.000000000 +0300 @@ -1165,6 +1181,49 @@ } } +static int ff_vc1_find_header(ff_video_decoder_t *this, buf_element_t *buf) +{ + uint8_t *p = buf->content; + + if (!p[0] && !p[1] && p[2] == 1 && p[3] == 0x0f) { + int i; + + this->context->extradata = calloc(1, buf->size); + this->context->extradata_size = 0; + + for (i = 0; i < buf->size && i < 128; i++) { + if (!p[i] && !p[i+1] && p[i+2]) { + lprintf("00 00 01 %02x at %d\n", p[i+3], i); + if (p[i+3] != 0x0e && p[i+3] != 0x0f) + break; + } + this->context->extradata[i] = p[i]; + this->context->extradata_size++; + } + + lprintf("ff_video_decoder: found VC1 sequence header\n"); + return 1; + } + + xprintf(this->stream->xine, XINE_VERBOSITY_DEBUG, + "ffmpeg_video_dec: VC1 extradata missing !\n"); + return 0; +} + +static int ff_check_extradata(ff_video_decoder_t *this, unsigned int codec_type, buf_element_t *buf) +{ + if (this->context && this->context->extradata) + return 1; + + switch (codec_type) { + case BUF_VIDEO_VC1: + return ff_vc1_find_header(this, buf); + default:; + } + + return 1; +} + #endif /* AVCODEC_HAS_REORDERED_OPAQUE */ static void ff_handle_buffer (ff_video_decoder_t *this, buf_element_t *buf) { uint8_t *chunk_buf = this->buf; @@ -1176,6 +1235,9 @@ if (this->decoder_init_mode) { int codec_type = buf->type & 0xFFFF0000; + if (!ff_check_extradata(this, codec_type, buf)) + return; + /* init ffmpeg decoder */ init_video_codec(this, codec_type); init_postprocess(this);

[xine-lib-1.1.16.3-ffmpeg-vc1-reopen.diff]

--- src/combined/ffmpeg/ff_video_decoder.c 2009-04-16 14:24:20.000000000 +0300 +++ src/combined/ffmpeg/ff_video_decoder.c 2009-09-24 15:21:25.000000000 +0300 @@ -340,6 +340,22 @@ return; } + if (this->codec->id == CODEC_ID_VC1 && + (!this->bih.biWidth || !this->bih.biHeight)) { + /* VC1 codec must be re-opened with correct width and height. */ + avcodec_close(this->context); + + if (avcodec_open (this->context, this->codec) < 0) { + pthread_mutex_unlock(&ffmpeg_lock); + xprintf (this->stream->xine, XINE_VERBOSITY_LOG, + _("ffmpeg_video_dec: couldn't open decoder (pass 2)\n")); + free(this->context); + this->context = NULL; + _x_stream_info_set(this->stream, XINE_STREAM_INFO_VIDEO_HANDLED, 0); + return; + } + } + if (this->class->thread_count > 1) { avcodec_thread_init(this->context, this->class->thread_count); this->context->thread_count = this->class->thread_count;

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: Should I clean up and submit patches?

2009-09-15T16:10:50Z

Hi Darren,

> The first step is to post them here with suitable subject lines and
> descriptions. If you have a local xine-lib repository (cloned from [0]), then
> you could commit them then use "hg email" to send them.

I haven't received any responses other than your own so I'll leave it on the back burner until I have time to clean things up. Fixing deadlocks and changing my code so it can execute MHP-like java xlets will get a higher priority.

> BTW, you should check if any significant changes are needed for porting to
> the 1.2 branch.

The input and demux patches will probably be fine but the teletext spu decoder will at a minimum need tweaking for the different API. I've never managed to get the 1.2 branch to properly compile and link so I can't say what else might be needed.

Regards,
Roger.

Click Here View photos of singles in your area
------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: help with a suspected race condition in video_out.c

2009-09-14T16:49:22Z

> Roger,

Hi Ian (and xine-devel list),

> This sounds a lot like a deadlock I have encountered during stress

> testing of an abandoned project. In my case the deadlock was caused by
> the unprotected use of stream->demux_action_pending internal variable
> from play_internal() and from within the demuxer loop.
>
> I've attached a patch that fixed it for me. Basically direct access to
> demux_action_pending is replaced with _x_action_raise() and
> _x_action_lower() which use a mutex for thread safety.
>
> If this resolves your bug then I'll submit the patch for inclusion in
> Xine.

Unfortunately your patch didn't fix this particular problem but I'd like to test it further as I think it may address some deadlock issues I had to work around by using mutexes and delays around xine calls in my user code.

I think I have now resolved my original problem and it was indeed a race condition. When doing a seek immediately after the first play the code was trying to complete a flush of the buffers by decrementing a discard counter (possibly assuming it had been incremented somewhere else first). This was causing the counter to go negative and hence all checks against "this->discard_buffer" were evaluating to true and it was never recovering. I have attached a patch (had to fire up IE in VirtualBox to get hotmail attaches to work properly) which disallows negative values.

I also note that there appears to be a similar issue in the audio_out.c file as well as a lack of mutex locking around the increment/decrement. A patch is also attached for this. I think this may address similar symptoms I have had with the audio where it would go quiet after a stop/close/open/play sequence.

The patches are against an older snapshot but they should go into the newer versions without difficulty. Could someone please check these patches (they're quite small) and push them into the queue if they are okay?

Regards,
Roger.

Click Here View photos of singles in your area
--- b/src/xine-engine/video_out.c 2008-12-07 10:32:45.000000000 +1100
+++ /home/roger/xine-lib-e9b57f7f5399/src/xine-engine/video_out.c 2009-09-15 09:07:53.000000000 +1000
@@ -1469,10 +1469,11 @@
pthread_mutex_lock(&this->display_img_buf_queue->mutex);
if(value)
this->discard_frames++;
else
this->discard_frames--;
+ if (this->discard_frames < 0) this->discard_frames = 0;
pthread_mutex_unlock(&this->display_img_buf_queue->mutex);
ret = this->discard_frames;

/* discard buffers here because we have no output thread */
if (this->grab_only && this->discard_frames) {

--- b/src/xine-engine/audio_out.c 2008-12-07 10:32:45.000000000 +1100
+++ /home/roger/xine-lib-e9b57f7f5399/src/xine-engine/audio_out.c 2009-09-15 09:09:00.000000000 +1000
@@ -1868,14 +1868,17 @@
}
break;

case AO_PROP_DISCARD_BUFFERS:
/* recursive discard buffers setting */
+ pthread_mutex_lock(&this->flush_audio_driver_lock);
if(value)
this->discard_buffers++;
else
this->discard_buffers--;
+ if (this->discard_buffers < 0) this->discard_buffers = 0;
+ pthread_mutex_unlock(&this->flush_audio_driver_lock);

ret = this->discard_buffers;

/* discard buffers here because we have no output thread */
if (this->grab_only && this->discard_buffers) {

------------------------------------------------------------------------------
Come build with us! The BlackBerry® Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9-12, 2009. Register now!
http://p.sf.net/sfu/devconf
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: help with a suspected race condition in video_out.c

2009-09-14T10:01:43Z

Roger,

This sounds a lot like a deadlock I have encountered during stress
testing of an abandoned project. In my case the deadlock was caused by
the unprotected use of stream->demux_action_pending internal variable
from play_internal() and from within the demuxer loop.

I've attached a patch that fixed it for me. Basically direct access to
demux_action_pending is replaced with _x_action_raise() and
_x_action_lower() which use a mutex for thread safety.

If this resolves your bug then I'll submit the patch for inclusion in
Xine.

Thanks,
Ian.

On Sun, 2009-09-13 at 12:45 +1030, Roger Scott wrote:

> Hi xine developers,
>
> I've been banging my head against a brick wall for a while now and
> don't seem any closer in finding a solution to a problem so I'm hoping
> someone here can help or at least point me in the right direction.
>
> What I'm getting is frozen video when playing from a new position
> after opening the stream. (eg xine_open(s,m); xine_play(s,0,0);
> some_stuff(); xine_play(s,0,pos )). I suspect it's some kind of race
> condition because sometimes it works and sometimes it doesn't. I can
> pause the stream and restart it and it's still frozen. The audio
> still works, as does SPU/OSD output although the timing for the latter
> seems somewhat off (sped up).
>
> From what I can figure it's a bug somewhere in video_out.c but I don't
> know enough of the internals to be able to track it down. Frames are
> being appended to the display buffer but there never seems to be
> anything available (ie get_next_frame always returns 0). There's no
> deadlock as all the loops keep going and I can stop and restart the
> stream and sometimes the video then works. It's independent of the
> video output plugin as it's occurring with xv, vdpau, xshm and DFB
> drivers. My suspicion is that part of the engine is waiting for the
> first frame whilst another part thinks it's already been done but I'm
> not sure. It might be a frame expiry problem but I'm not getting
> continuous discarded or skipped messages.
>
> Unfortunately the attach for hotmail doesn't seem to work so I've
> appended a few lines from turning on the logging in video_out.c below.
> Although the numbers vary it's essentially the same continuing output.
>
> Help please.
>
> Roger.
>
> --------------------------------------------------------------
>
> video_out: (video_out_loop:1159) loop iteration at 455657
> video_out: (get_next_frame:919) no frame
> video_out: (get_next_frame:942) no frame, but no backup frame
> video_out: (video_out_loop:1219) next_frame_vpts is 0
> video_out: (video_out_loop:1239) 1000 usec to sleep at master vpts
> 455659
> video_out: (vo_frame_draw:463) got image oat master vpts 455849. vpts
> for pictur
> e is 3623016 (pts was 1477219824)
> video_out: (vo_frame_draw:517) delivery diff : 3167167, current vpts
> is 455849,
> 0 frames to skip
> video_out: (vo_frame_draw:568) frame is ok => appending to display
> buffer
> video_out: (vo_get_frame:384) get_frame (720 x 576)
> video_out: (vo_remove_from_img_buf_queue_int:236) frame format hit
> (4/10)
> video_out: (vo_get_frame:391) got a frame -> pthread_mutex_lock
> (&img->mutex)
> video_out: (vo_get_frame:426) get_frame (720 x 576) done
> video_out: (vo_frame_draw:463) got image oat master vpts 456381. vpts
> for picture is 3626619 (pts was 1477223424)
> video_out: (vo_frame_draw:517) delivery diff : 3170238, current vpts
> is 456381,
> 0 frames to skip
> video_out: (vo_frame_draw:568) frame is ok => appending to display
> buffer
> video_out: (vo_get_frame:384) get_frame (720 x 576)
> video_out: (vo_remove_from_img_buf_queue_int:236) frame format hit
> (4/10)
> video_out: (vo_get_frame:391) got a frame -> pthread_mutex_lock
> (&img->mutex)
> video_out: (vo_get_frame:426) get_frame (720 x 576) done
>
>
>
> ______________________________________________________________________
> Click Here View photos of singles in your area
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________ xine-devel mailing list xine-devel@... https://lists.sourceforge.net/lists/listinfo/xine-devel

[video_out_deadlock.patch]

diff --git a/src/xine-lib/src/xine-engine/demux.c b/src/xine-lib/src/xine-engine/demux.c index 4957841..e52ce96 100644 --- a/src/xine-lib/src/xine-engine/demux.c +++ b/src/xine-lib/src/xine-engine/demux.c @@ -149,7 +149,7 @@ void _x_demux_control_headers_done (xine_stream_t *stream) { buf_element_t *buf_video, *buf_audio; /* we use demux_action_pending to wake up sleeping spu decoders */ - stream->demux_action_pending = 1; + _x_action_raise(stream); /* allocate the buffers before grabbing the lock to prevent cyclic wait situations */ buf_video = stream->video_fifo->buffer_pool_alloc (stream->video_fifo); @@ -195,7 +195,7 @@ void _x_demux_control_headers_done (xine_stream_t *stream) { pthread_cond_timedwait (&stream->counter_changed, &stream->counter_lock, &ts); } - stream->demux_action_pending = 0; + _x_action_lower(stream); pthread_cond_signal(&stream->demux_resume); lprintf ("headers processed.\n"); @@ -282,7 +282,7 @@ static void *demux_loop (void *stream_gen) { status = stream->demux_plugin->send_chunk(stream->demux_plugin); /* someone may want to interrupt us */ - if( stream->demux_action_pending ) { + if (_x_action_pending(stream)) { struct timeval tv; struct timespec ts; @@ -363,9 +363,9 @@ int _x_demux_start_thread (xine_stream_t *stream) { lprintf ("start thread called\n"); - stream->demux_action_pending = 1; + _x_action_raise(stream); pthread_mutex_lock( &stream->demux_lock ); - stream->demux_action_pending = 0; + _x_action_lower(stream); pthread_cond_signal(&stream->demux_resume); if( !stream->demux_thread_running ) { @@ -394,10 +394,10 @@ int _x_demux_stop_thread (xine_stream_t *stream) { lprintf ("stop thread called\n"); - stream->demux_action_pending = 1; + _x_action_raise(stream); pthread_mutex_lock( &stream->demux_lock ); stream->demux_thread_running = 0; - stream->demux_action_pending = 0; + _x_action_lower(stream); pthread_cond_signal(&stream->demux_resume); /* At that point, the demuxer has sent the last audio/video buffer, @@ -501,7 +501,7 @@ off_t _x_read_abort (xine_stream_t *stream, int fd, char *buf, off_t todo) { /* aborts current read if action pending. otherwise xine * cannot be stopped when no more data is available. */ - if( stream->demux_action_pending ) + if (_x_action_pending(stream)) return total; } else { break; @@ -542,6 +542,22 @@ int _x_action_pending (xine_stream_t *stream) { return stream->demux_action_pending; } +/* set demux_action_pending in a thread safe way */ +void _x_action_raise (xine_stream_t *stream) +{ + pthread_mutex_lock(&stream->demux_action_lock); + stream->demux_action_pending++; + pthread_mutex_unlock(&stream->demux_action_lock); +} + +/* reset demux_action_pending in a thread safe way */ +void _x_action_lower (xine_stream_t *stream) +{ + pthread_mutex_lock(&stream->demux_action_lock); + stream->demux_action_pending--; + pthread_mutex_unlock(&stream->demux_action_lock); +} + /* * demuxer helper function to send data to fifo, breaking into smaller * pieces (bufs) as needed. diff --git a/src/xine-lib/src/xine-engine/io_helper.c b/src/xine-lib/src/xine-engine/io_helper.c index c3654c7..a05dab5 100644 --- a/src/xine-lib/src/xine-engine/io_helper.c +++ b/src/xine-lib/src/xine-engine/io_helper.c @@ -244,7 +244,7 @@ int _x_io_select (xine_stream_t *stream, int fd, int state, int timeout_msec) { * aborts current read if action pending. otherwise xine * cannot be stopped when no more data is available. */ - if (stream && stream->demux_action_pending) + if (stream && _x_action_pending(stream)) return XIO_ABORTED; break; case WAIT_ABANDONED: @@ -288,7 +288,7 @@ int _x_io_select (xine_stream_t *stream, int fd, int state, int timeout_msec) { * aborts current read if action pending. otherwise xine * cannot be stopped when no more data is available. */ - if (stream && stream->demux_action_pending) + if (stream && _x_action_pending(stream)) return XIO_ABORTED; total_time_usec += XIO_POLLING_INTERVAL; diff --git a/src/xine-lib/src/xine-engine/video_decoder.c b/src/xine-lib/src/xine-engine/video_decoder.c index c88e017..b99f8ab 100644 --- a/src/xine-lib/src/xine-engine/video_decoder.c +++ b/src/xine-lib/src/xine-engine/video_decoder.c @@ -91,7 +91,7 @@ int _x_spu_decoder_sleep(xine_stream_t *stream, int64_t next_spu_vpts) thread_vacant = (stream->video_fifo->first->type != BUF_CONTROL_FLUSH_DECODER); /* we have to return if the demuxer needs us to release a buffer */ if (thread_vacant) - thread_vacant = !stream->demux_action_pending; + thread_vacant = !_x_action_pending(stream); } while (wait == SPU_SLEEP_INTERVAL && thread_vacant); diff --git a/src/xine-lib/src/xine-engine/xine.c b/src/xine-lib/src/xine-engine/xine.c index 39f2f2d..bc6ed6a 100644 --- a/src/xine-lib/src/xine-engine/xine.c +++ b/src/xine-lib/src/xine-engine/xine.c @@ -629,6 +629,7 @@ xine_stream_t *xine_stream_new (xine_t *this, pthread_mutex_init (&stream->info_mutex, NULL); pthread_mutex_init (&stream->meta_mutex, NULL); pthread_mutex_init (&stream->demux_lock, NULL); + pthread_mutex_init (&stream->demux_action_lock, NULL); pthread_mutex_init (&stream->demux_mutex, NULL); pthread_cond_init (&stream->demux_resume, NULL); pthread_mutex_init (&stream->event_queues_lock, NULL); @@ -1325,7 +1326,7 @@ static int play_internal (xine_stream_t *stream, int start_pos, int start_time) } /* hint demuxer thread we want to interrupt it */ - stream->demux_action_pending = 1; + _x_action_raise(stream); /* set normal speed */ if (_x_get_speed(stream) != XINE_SPEED_NORMAL) @@ -1344,7 +1345,7 @@ static int play_internal (xine_stream_t *stream, int start_pos, int start_time) pthread_mutex_lock( &stream->demux_lock ); /* demux_lock taken. now demuxer is suspended */ - stream->demux_action_pending = 0; + _x_action_lower(stream); pthread_cond_signal(&stream->demux_resume); /* set normal speed again (now that demuxer/input pair is suspended) @@ -1473,6 +1474,7 @@ static void xine_dispose_internal (xine_stream_t *stream) { pthread_cond_destroy (&stream->counter_changed); pthread_mutex_destroy (&stream->demux_mutex); pthread_cond_destroy (&stream->demux_resume); + pthread_mutex_destroy (&stream->demux_action_lock); pthread_mutex_destroy (&stream->demux_lock); pthread_mutex_destroy (&stream->first_frame_lock); pthread_cond_destroy (&stream->first_frame_reached); diff --git a/src/xine-lib/src/xine-engine/xine_internal.h b/src/xine-lib/src/xine-engine/xine_internal.h index f97ca0b..580821d 100644 --- a/src/xine-lib/src/xine-engine/xine_internal.h +++ b/src/xine-lib/src/xine-engine/xine_internal.h @@ -336,6 +336,7 @@ struct xine_stream_s { int demux_thread_running; pthread_mutex_t demux_lock; int demux_action_pending; + pthread_mutex_t demux_action_lock; pthread_cond_t demux_resume; pthread_mutex_t demux_mutex; /* used in _x_demux_... functions to synchronize order of pairwise A/V buffer operations */ @@ -440,6 +441,9 @@ off_t _x_read_abort (xine_stream_t *stream, int fd, char *buf, off_t todo) XINE_ int _x_action_pending (xine_stream_t *stream) XINE_PROTECTED; +void _x_action_raise (xine_stream_t *stream) XINE_PROTECTED; +void _x_action_lower (xine_stream_t *stream) XINE_PROTECTED; + void _x_demux_send_data(fifo_buffer_t *fifo, uint8_t *data, int size, int64_t pts, uint32_t type, uint32_t decoder_flags, int input_normpos, int input_time, int total_time,

help with a suspected race condition in video_out.c

2009-09-12T19:15:24Z

Hi xine developers,

I've been banging my head against a brick wall for a while now and don't seem any closer in finding a solution to a problem so I'm hoping someone here can help or at least point me in the right direction.

What I'm getting is frozen video when playing from a new position after opening the stream. (eg xine_open(s,m); xine_play(s,0,0); some_stuff(); xine_play(s,0,pos )). I suspect it's some kind of race condition because sometimes it works and sometimes it doesn't. I can pause the stream and restart it and it's still frozen. The audio still works, as does SPU/OSD output although the timing for the latter seems somewhat off (sped up).

From what I can figure it's a bug somewhere in video_out.c but I don't know enough of the internals to be able to track it down. Frames are being appended to the display buffer but there never seems to be anything available (ie get_next_frame always returns 0). There's no deadlock as all the loops keep going and I can stop and restart the stream and sometimes the video then works. It's independent of the video output plugin as it's occurring with xv, vdpau, xshm and DFB drivers. My suspicion is that part of the engine is waiting for the first frame whilst another part thinks it's already been done but I'm not sure. It might be a frame expiry problem but I'm not getting continuous discarded or skipped messages.

Unfortunately the attach for hotmail doesn't seem to work so I've appended a few lines from turning on the logging in video_out.c below. Although the numbers vary it's essentially the same continuing output.

Help please.

Roger.

--------------------------------------------------------------

video_out: (video_out_loop:1159) loop iteration at 455657
video_out: (get_next_frame:919) no frame
video_out: (get_next_frame:942) no frame, but no backup frame
video_out: (video_out_loop:1219) next_frame_vpts is 0
video_out: (video_out_loop:1239) 1000 usec to sleep at master vpts 455659
video_out: (vo_frame_draw:463) got image oat master vpts 455849. vpts for pictur
e is 3623016 (pts was 1477219824)
video_out: (vo_frame_draw:517) delivery diff : 3167167, current vpts is 455849,
0 frames to skip
video_out: (vo_frame_draw:568) frame is ok => appending to display buffer
video_out: (vo_get_frame:384) get_frame (720 x 576)
video_out: (vo_remove_from_img_buf_queue_int:236) frame format hit (4/10)
video_out: (vo_get_frame:391) got a frame -> pthread_mutex_lock (&img->mutex)
video_out: (vo_get_frame:426) get_frame (720 x 576) done
video_out: (vo_frame_draw:463) got image oat master vpts 456381. vpts for picture is 3626619 (pts was 1477223424)
video_out: (vo_frame_draw:517) delivery diff : 3170238, current vpts is 456381,
0 frames to skip
video_out: (vo_frame_draw:568) frame is ok => appending to display buffer
video_out: (vo_get_frame:384) get_frame (720 x 576)
video_out: (vo_remove_from_img_buf_queue_int:236) frame format hit (4/10)
video_out: (vo_get_frame:391) got a frame -> pthread_mutex_lock (&img->mutex)
video_out: (vo_get_frame:426) get_frame (720 x 576) done

Click Here View photos of singles in your area
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Re: Should I clean up and submit patches?

2009-09-06T16:07:28Z

I demand that Roger Scott may or may not have written...

> For the past couple of years I have been applying my own set of rather
> rough patches to the xine library. Although this list seems curiously
> devoid of traffic I thought I'd ask if there was enough interest that it
> would be worth me spending some time to clean them up and submit them?

The first step is to post them here with suitable subject lines and
descriptions. If you have a local xine-lib repository (cloned from [0]), then
you could commit them then use "hg email" to send them.

They'll probably either end up in the patch queue [1] or be committed to the
master repository (and if you want to test stuff that's in the patch queue,
that'd be useful).

BTW, you should check if any significant changes are needed for porting to
the 1.2 branch.

[snip]

[0] http://hg.debian.org/hg/xine-lib/xine-lib/
[1] http://hg.debian.org/hg/xine-lib/xine-lib-patch-queue/
--
| Darren Salt | linux at youmustbejoking | nr. Ashington, | Doon
| using Debian GNU/Linux | or ds ,demon,co,uk | Northumberland | Army
| + Use more efficient products. Use less. BE MORE ENERGY EFFICIENT.

You will live a long, healthy, happy life and make bags for money.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

Should I clean up and submit patches?

2009-09-06T15:51:52Z

Hello list,

For the past couple of years I have been applying my own set of rather rough patches to the xine library. Although this list seems curiously devoid of traffic I thought I'd ask if there was enough interest that it would be worth me spending some time to clean them up and submit them? There are three that might be of interest:

1. An amendment to the stdin plugin (fd:// url) to allow a supplied file descriptor number. This is used by my pvr software which handles the creation of a pipe by itself and then passes the descriptor number to xine for display.

2. A Topfield rec file input plugin derived from the MPEG-TS plugin.

3. A closed caption teletext spu plugin which decodes and displays the DVB teletext captions broadcast in Australia. This is probably the most useful but it also the most rough and I cannot guarantee it will work elsewhere in the world.

Any interest?

Roger.

Find out how here Use Messenger in your Hotmail inbox
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

XineLib with XCB support

2009-09-01T20:13:40Z

Hi,
Can you please let me know how to configure and build xine-vdpau / xine library with xcb support. When I do a normal configure and then make and make install ,

I do not see any xineplug_vo_out_xcb* files. I tried configure with --with-xcb option but still did not make any difference.

When I try playing any media with dragonplayer ( which uses phonon), I get the following error ,

"No xine video output plugin using libxcb for threadsafe access to the X server found. No video for you."

Can anyone please help me out with this ?

thanks,
kumar.
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

[PATCH] png files for skins should not be included twice

2009-08-09T13:58:40Z

Hi,

I've noticed that the xine-ui RPM is refusing to build, because some .png files are being included twice. This patch fixes it.

Cheers,
Chris

Index: Makefile.am
===================================================================
RCS file: /cvsroot/xine/xine-ui/src/xitk/skins/xinetic/Makefile.am,v
retrieving revision 1.16
diff -u -u -r1.16 Makefile.am
--- Makefile.am 1 Jul 2006 12:24:09 -0000 1.16
+++ Makefile.am 9 Aug 2009 20:54:09 -0000
@@ -15,7 +15,6 @@
CtlSave.png MainNext.png MrlDismiss.png PlPlay.png Letters.png \
MainPause.png MrlSelect.png Letters2.png MrlFlit.png \
MainAutoButton.png MainPlay.png Onglet.png MainNav.png \
- MainAutoButton.png MainPlay.png Onglet.png \
BigArrowLeft.png BigArrowRight.png \
PlSlidHBg.png SliderHPad.png SkSlidHBg.png SlidHPad.png \
SkSlidHPad.png skinconfig

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel

[PATCH] Fixes/improvements for CDDA

2009-08-02T15:08:33Z

Hello,

Please consider the attached patches. They make several small changes to
the CDDA plugin, explained below:

1) Accept CDDB return code 211 ("found inexact matches", i.e. there is
more than one CDDB entry for the disc in question, as happens on
occassion). Before, when receiving a 211 response from a CDDB server,
Xine would simply not display any CDDB information. Now one of the
responses is displayed, on the theory that something is better than
nothing.

2) Fix the reading of CDDB information by not setting INPUT_CAP_BLOCK
for the CDDA plugin (and therefore also setting CD_RAW_FRAME_SIZE to
0), and allow reading in non-block sized chunks as per
http://hg.debian.org/hg/xine-lib/xine-lib?cmd=changeset;node=a470c338149c;style=gitweb

Explanation: At some point a number of releases ago, a codepath in Xine
related to the reading of block devices which had been bypassed was
fixed, which meant that when certain frontends asked Xine to provide
CDDB information for a disc, querying the name, length, etc. of each
track, Xine would actually cause a seek to the starting block of each
track, which meant that before starting to play, the player would pause
for 5-10 seconds, seeking through each track. This is unnecessary,
since Xine should have simply used the CD TOC information from the CD
audio header at the start of the disc. Other frontends handle CDDB
differently and don't query Xine for information track by track, and so
never triggered this problem. But for those with the problem, it made
loading a disc rather slow.

It turns out that the root of the problem is that the CDDA plugin
shouldn't be setting INPUT_CAP_BLOCK, since Audio CDs are not block
devices _in the sense that Xine intends_. Simply turning this off fixes
the problem, with no other side effects (tested locally, for some time
now, on xine-ui, kscd, kaffeine, amarok, etc.).

This change pairs nicely with a patch originally committed years ago
(http://hg.debian.org/hg/xine-lib/xine-lib?cmd=changeset;node=a470c338149c;style=gitweb)
but which was reverted as it inadvertently triggered the same problem
as is now (properly) fixed by the simple above-mentioned change. Now
that a better fix is in, it can be re-committed.

Thanks,
Christopher Martin

[attachment removed]
[attachment removed]
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
xine-devel mailing list
xine-devel@...
https://lists.sourceforge.net/lists/listinfo/xine-devel