zogi and daylight savings

[Tobias Kaefer]

Hello!

I'm having an issue with creating recurrent appointments over the
daylight savings switch day. Let's say I want to create an recurrent
appointment that has a daily recurrence. It starts today (10/22/2008)
from 11:00 and ends today at 12:00. The recurrence ends next Wednesday
(10/28/2008). On Sunday 10/26/2008 the time is set one hour back
(daylight savings) for the MET/CET timezone. So every recurrent
appointment that is after Sunday 10/26/2008 will start at 10:00 and end
at 11:00.

The OpenGroupware WebUI seems to handle this pretty well. Is there any
chance, that this will also be handled within zogi?

Greets
Tobias
--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams-2]

>I'm having an issue with creating recurrent appointments over the
>daylight savings switch day. Let's say I want to create an recurrent
>appointment that has a daily recurrence. It starts today (10/22/2008)
>from 11:00 and ends today at 12:00. The recurrence ends next Wednesday
>(10/28/2008). On Sunday 10/26/2008 the time is set one hour back
>(daylight savings) for the MET/CET timezone. So every recurrent
>appointment that is after Sunday 10/26/2008 will start at 10:00 and end
>at 11:00.
>The OpenGroupware WebUI seems to handle this pretty well. Is there any
>chance, that this will also be handled within zogi?

Hmmm,  I believe zOGI uses the same Logic as the WebUI.  

 Can you file an issue at the zOGI Google Code project?  I'm currently
travelling.  If possible a Python script to perform the exact request would
be good.
--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Tobias Kaefer]

Are there any updates on this?
I have created an issue at Google Code:
http://code.google.com/p/zogi/issues/detail?id=33


Adam Tauno Williams schrieb:

>> I'm having an issue with creating recurrent appointments over the
>> daylight savings switch day. Let's say I want to create an recurrent
>> appointment that has a daily recurrence. It starts today (10/22/2008)
>>from 11:00 and ends today at 12:00. The recurrence ends next Wednesday
>> (10/28/2008). On Sunday 10/26/2008 the time is set one hour back
>> (daylight savings) for the MET/CET timezone. So every recurrent
>> appointment that is after Sunday 10/26/2008 will start at 10:00 and end
>> at 11:00.
>> The OpenGroupware WebUI seems to handle this pretty well. Is there any
>> chance, that this will also be handled within zogi?
>
> Hmmm,  I believe zOGI uses the same Logic as the WebUI.  
>
>  Can you file an issue at the zOGI Google Code project?  I'm currently
> travelling.  If possible a Python script to perform the exact request would
> be good.

--
Mit freundlichen Gruessen / with kind regards

Tobias S. Käfer

Tobias S. Kaefer * Portal-Development
ABAS Software AG, Suedendstrasse 42, 76135 Karlsruhe, GERMANY
Fon: [phone], Fax: [phone]
Managing board / Vorstand: Werner Strub (CEO, Vorsitzender), Peter Walser
Chairman supervisory board / Aufsichtsratsvorsitzender: Thomas Frank
Company Register / Handelsregister: HRB 107644 Amtsgericht Mannheim
please visit our homepage / Bitte besuchen Sie unsere Homepage:
http://www.abas.de
--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams]

On Thu, 2009-01-08 at 12:25 +0100, Tobias Kaefer wrote:
> Are there any updates on this?

I've confirmed it.

> I have created an issue at Google Code:
> http://code.google.com/p/zogi/issues/detail?id=33

I'll try and fix this one tomorrow;  zOGI just must be doing something
different than the WebUI (which works correctly).

> Adam Tauno Williams schrieb:
> >> I'm having an issue with creating recurrent appointments over the
> >> daylight savings switch day. Let's say I want to create an recurrent
> >> appointment that has a daily recurrence. It starts today (10/22/2008)
> >>from 11:00 and ends today at 12:00. The recurrence ends next Wednesday
> >> (10/28/2008). On Sunday 10/26/2008 the time is set one hour back
> >> (daylight savings) for the MET/CET timezone. So every recurrent
> >> appointment that is after Sunday 10/26/2008 will start at 10:00 and end
> >> at 11:00.
> >> The OpenGroupware WebUI seems to handle this pretty well. Is there any
> >> chance, that this will also be handled within zogi?
> > Hmmm,  I believe zOGI uses the same Logic as the WebUI.  
> >  Can you file an issue at the zOGI Google Code project?  I'm currently
> > travelling.  If possible a Python script to perform the exact request would
> > be good.

--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Tobias Kaefer]

Adam Tauno Williams wrote:

> On Thu, 2009-01-08 at 12:25 +0100, Tobias Kaefer wrote:
>> Are there any updates on this?
>
> I've confirmed it.
>
>> I have created an issue at Google Code:
>> http://code.google.com/p/zogi/issues/detail?id=33
>
> I'll try and fix this one tomorrow;  zOGI just must be doing something
> different than the WebUI (which works correctly).

That very good to hear! Thanks!
--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams]

On Fri, 2009-01-09 at 08:44 +0100, Tobias Kaefer wrote:
> Adam Tauno Williams wrote:
> > On Thu, 2009-01-08 at 12:25 +0100, Tobias Kaefer wrote:
> >> Are there any updates on this?
> > I've confirmed it.
> >> I have created an issue at Google Code:
> >> http://code.google.com/p/zogi/issues/detail?id=33
> > I'll try and fix this one tomorrow;  zOGI just must be doing something
> > different than the WebUI (which works correctly).
> That very good to hear! Thanks!

I think the issue is that zOGI is creating all appointments as GMT
(adjusting from the supplied start/end to GMT) while the WebUI is more
sensitive to the user's timeZone (set in the user's context?).

LSNewAppointmentCommand.m
...
  sD = [self valueForKey:@"startDate"];
  eD = [self valueForKey:@"endDate"];
  ....
  tzsD = [[[sD timeZoneDetail] retain] autorelease];
  tzeD = [[[eD timeZoneDetail] retain] autorelease];
...

While zOGI attempts to set the timeZone on dates received it doesn't
appear to be effective.

--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Tobias Kaefer-3]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

BTW:
The legacy XML-RPC-API has the same issue as zOGI has!

I just gave it a try (as a fallback solution until this is fixed in zOGI).

That is really annoying.

Tobias

Adam Tauno Williams schrieb:

> On Fri, 2009-01-09 at 08:44 +0100, Tobias Kaefer wrote:
>> Adam Tauno Williams wrote:
>>> On Thu, 2009-01-08 at 12:25 +0100, Tobias Kaefer wrote:
>>>> Are there any updates on this?
>>> I've confirmed it.
>>>> I have created an issue at Google Code:
>>>> http://code.google.com/p/zogi/issues/detail?id=33
>>> I'll try and fix this one tomorrow;  zOGI just must be doing something
>>> different than the WebUI (which works correctly).
>> That very good to hear! Thanks!
>
> I think the issue is that zOGI is creating all appointments as GMT
> (adjusting from the supplied start/end to GMT) while the WebUI is more
> sensitive to the user's timeZone (set in the user's context?).
>
> LSNewAppointmentCommand.m
> ...
>   sD = [self valueForKey:@"startDate"];
>   eD = [self valueForKey:@"endDate"];
>   ....
>   tzsD = [[[sD timeZoneDetail] retain] autorelease];
>   tzeD = [[[eD timeZoneDetail] retain] autorelease];
> ...
>
> While zOGI attempts to set the timeZone on dates received it doesn't
> appear to be effective.
>

- --
Mit freundlichen Gruessen / with kind regards

Tobias S. Käfer

Tobias S. Kaefer * Portal-Development
ABAS Software AG, Suedendstrasse 42, 76135 Karlsruhe, GERMANY
Fon: [phone], Fax: [phone]
Managing board / Vorstand: Werner Strub (CEO, Vorsitzender), Peter Walser
Chairman supervisory board / Aufsichtsratsvorsitzender: Thomas Frank
Company Register / Handelsregister: HRB 107644 Amtsgericht Mannheim
please visit our homepage / Bitte besuchen Sie unsere Homepage:
http://www.abas.de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoszgsACgkQdJJ1JNEzpd0G1gCgu416ZtJL4zqv9LnudnTQWDMe
ZY0AoLzbb7g1/j43rC41iekraKWJoDHn
=ey7y
-----END PGP SIGNATURE-----
--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams]

On Mon, 2009-06-08 at 10:38 +0200, Tobias Kaefer wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> BTW:
> The legacy XML-RPC-API has the same issue as zOGI has!
> I just gave it a try (as a fallback solution until this is fixed in zOGI).
> That is really annoying.

It is an effect of the implementation,  if I create an appointment via
zOGI the new appointment command gets -

[appointment::new] New Appointment; start: time2008-10-24 14:00:00 -0000
[appointment::new] New Appointment; start zone: GMT +00:00:00
[appointment::new] New Appointment; end time: 2008-10-24 15:00:00 -0000
[appointment::new] New Appointment; end zone: GMT +00:00:00
[appointment::new-cyclic] New Cyclic Appointment; start time: 2008-10-25
14:00:00 -0000
[appointment::new-cyclic] New Cyclic Appointment; start zone: GMT
+00:00:00
[appointment::new-cyclic] New Cyclic Appointment; end time: 2008-10-25
15:00:00 -0000
[appointment::new-cyclic] New Cyclic Appointment; end zone: GMT
+00:00:00

zOGI (and the old XML-RPC daemon) times are all in GMT (this happens in
zOGIAction's _makeCalendarDate function;  which converts the value to
GMT and strips the time zone.

<quote>
  /* if we successfuly aquired a date then make an adjustment to
     GMT if a timezone was provided;  GMT values are not changed. */
  if ([dateValue isNotNull]) {
    zoneDiff = [timeZone secondsFromGMTForDate:dateValue];
    if (zoneDiff != 0) {
      dateValue = [dateValue dateByAddingYears:0
                                        months:0
                                          days:0
                                         hours:0
                                       minutes:0
                                       seconds:(zoneDiff * -1)];
  [dateValue setTimeZone:[NSTimeZone timeZoneWithAbbreviation:@"GMT"]];
  return dateValue;
</quote>

On the other hand if I do it via the webui the appointment::new command
receives -
[appointment::new] New Appointment; start: time2008-10-24 11:00:00 +0200
[appointment::new] New Appointment; strart zone: MET DST +02:00:00
[appointment::new] New Appointment; end time: 2008-10-24 12:00:00 +0200
[appointment::new] New Appointment; end zone: MET DST +02:00:00

The command's parameters have a time zone;  which then [of course] is
provided to the subsequent appointment::cyclic-appointment command.

I'll make a fix to not convert to GMT for schedular operations if a
timeZone was provided; it looks like it should still work.

> >>>> http://code.google.com/p/zogi/issues/detail?id=33


--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Tobias Kaefer-3]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon Jun 08 2009 19:14:53 GMT+0200 (CEST), Adam Tauno WIlliams wrote:
> On Mon, 2009-06-08 at 10:38 +0200, Tobias Kaefer wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
> I'll make a fix to not convert to GMT for schedular operations if a
> timeZone was provided; it looks like it should still work.

That's very good to hear (or read)!
By "if a timeZone was provided" do you mean, provided with the
start/end-Date or as an extra parameter in the putObject request?

Thanks in advance!
Tobias

>
>>>>>> http://code.google.com/p/zogi/issues/detail?id=33
>
>


- --
Mit freundlichen Gruessen / with kind regards

Tobias S. Käfer

Tobias S. Kaefer * Portal-Development
ABAS Software AG, Suedendstrasse 42, 76135 Karlsruhe, GERMANY
Fon: [phone], Fax: [phone]
Managing board / Vorstand: Werner Strub (CEO, Vorsitzender), Peter Walser
Chairman supervisory board / Aufsichtsratsvorsitzender: Thomas Frank
Company Register / Handelsregister: HRB 107644 Amtsgericht Mannheim
please visit our homepage / Bitte besuchen Sie unsere Homepage:
http://www.abas.de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkot52cACgkQdJJ1JNEzpd19JACguqeoNeNn1yOcgYWqOOG9i8db
M1IAoIz08cFrPPrV93UFFZeXpnoW0VOL
=ZChX
-----END PGP SIGNATURE-----
--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams]

On Tue, 2009-06-09 at 06:39 +0200, Tobias Kaefer wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> On Mon Jun 08 2009 19:14:53 GMT+0200 (CEST), Adam Tauno WIlliams wrote:
> > On Mon, 2009-06-08 at 10:38 +0200, Tobias Kaefer wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> > I'll make a fix to not convert to GMT for schedular operations if a
> > timeZone was provided; it looks like it should still work.
> That's very good to hear (or read)!
> By "if a timeZone was provided" do you mean, provided with the
> start/end-Date or as an extra parameter in the putObject request?

A timezone can be provided when the appointment is created/updated by
including a "timezone" attribute in the appointment dictionary.  If no
"timezone" attribute exists then the operation occurs as GMT.  AFAIK the
timezone portion (if any) of the actual "start" and "end" attributes is
completely ignored.  It was originally intended that ALL client/server
communication would be in GMT - but this proved to much of a burden for
some clients so the "timezone" support was added.  The example you
submitted for Issue#33 included the timezone attribute
<http://code.google.com/p/zogi/issues/detail?id=33>

--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Tobias Kaefer-3]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue Jun 09 2009 21:24:56 GMT+0200 (CEST), Adam Tauno Williams wrote:

> On Tue, 2009-06-09 at 06:39 +0200, Tobias Kaefer wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> On Mon Jun 08 2009 19:14:53 GMT+0200 (CEST), Adam Tauno WIlliams wrote:
>>> On Mon, 2009-06-08 at 10:38 +0200, Tobias Kaefer wrote:
>>>> -----BEGIN PGP SIGNED MESSAGE-----
>>> I'll make a fix to not convert to GMT for schedular operations if a
>>> timeZone was provided; it looks like it should still work.
>> That's very good to hear (or read)!
>> By "if a timeZone was provided" do you mean, provided with the
>> start/end-Date or as an extra parameter in the putObject request?
>
> A timezone can be provided when the appointment is created/updated by
> including a "timezone" attribute in the appointment dictionary.  If no
> "timezone" attribute exists then the operation occurs as GMT.  AFAIK the
> timezone portion (if any) of the actual "start" and "end" attributes is
> completely ignored.  It was originally intended that ALL client/server
> communication would be in GMT - but this proved to much of a burden for
> some clients so the "timezone" support was added.  The example you
> submitted for Issue#33 included the timezone attribute
> <http://code.google.com/p/zogi/issues/detail?id=33>
>

Ah yes. I hadn't had the correct syntax in mind for the putObject
method. You are right.

I agree with you, that the best way would be to have the client/server
communication in GMT/UTC, but since there are those nasty daylight
savings for some timezones, there is a need for providing those
timezones (especially for recurrent appointments).

Tobias



- --
Mit freundlichen Gruessen / with kind regards

Tobias S. Käfer

Tobias S. Kaefer * Portal-Development
ABAS Software AG, Suedendstrasse 42, 76135 Karlsruhe, GERMANY
Fon: [phone], Fax: [phone]
Managing board / Vorstand: Werner Strub (CEO, Vorsitzender), Peter Walser
Chairman supervisory board / Aufsichtsratsvorsitzender: Thomas Frank
Company Register / Handelsregister: HRB 107644 Amtsgericht Mannheim
please visit our homepage / Bitte besuchen Sie unsere Homepage:
http://www.abas.de
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkovMJkACgkQdJJ1JNEzpd1WsQCfdD5OjGK2HpDeXVu0wehqL01f
WvMAn0O7UjB+m4tJKH/uFyB62OAB86Hg
=G47V
-----END PGP SIGNATURE-----
--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Tobias Kaefer-3]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Mon Jun 08 2009 19:14:53 GMT+0200 (CEST), Adam Tauno WIlliams wrote:

> <quote>
>   /* if we successfuly aquired a date then make an adjustment to
>      GMT if a timezone was provided;  GMT values are not changed. */
>   if ([dateValue isNotNull]) {
>     zoneDiff = [timeZone secondsFromGMTForDate:dateValue];
>     if (zoneDiff != 0) {
>       dateValue = [dateValue dateByAddingYears:0
>                                         months:0
>                                           days:0
>                                          hours:0
>                                        minutes:0
>                                        seconds:(zoneDiff * -1)];
>   [dateValue setTimeZone:[NSTimeZone timeZoneWithAbbreviation:@"GMT"]];
>   return dateValue;
> </quote>

After knowing where to do some patching, the issue is very easy to
solve. I provided a patch for that (see
http://code.google.com/p/zogi/issues/detail?id=33#c5).

It's basically just this:
<quote>
dateValue = [NSCalendarDate dateWithYear:[dateValue yearOfCommonEra]
                               month:[dateValue monthOfYear]
                               day:[dateValue dayOfMonth]
                               hour:[dateValue hourOfDay]
                               minute:[dateValue minuteOfHour]
                               second:[dateValue secondOfMinute]
                               timeZone:timeZone];
</quote>

Maybe to much overhead, with createing a new NSCalendarDate-Object.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAko2FBEACgkQdJJ1JNEzpd2nYACcDb9Ea4su54Xh1UXUC4scvo1x
5BYAn2PULcphiRK3Wwyi0g4V2HvZl39L
=Ih3U
-----END PGP SIGNATURE-----
--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams]

On Mon, 2009-06-15 at 11:27 +0200, Tobias Kaefer wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> On Mon Jun 08 2009 19:14:53 GMT+0200 (CEST), Adam Tauno WIlliams wrote:
> > <quote>
> >   /* if we successfuly aquired a date then make an adjustment to
> >      GMT if a timezone was provided;  GMT values are not changed. */
> >   if ([dateValue isNotNull]) {
> >     zoneDiff = [timeZone secondsFromGMTForDate:dateValue];
> >     if (zoneDiff != 0) {
> >       dateValue = [dateValue dateByAddingYears:0
> >                                         months:0
> >                                           days:0
> >                                          hours:0
> >                                        minutes:0
> >                                        seconds:(zoneDiff * -1)];
> >   [dateValue setTimeZone:[NSTimeZone timeZoneWithAbbreviation:@"GMT"]];
> >   return dateValue;
> > </quote>
> After knowing where to do some patching, the issue is very easy to
> solve. I provided a patch for that (see
> http://code.google.com/p/zogi/issues/detail?id=33#c5).
> It's basically just this:
> <quote>
> dateValue = [NSCalendarDate dateWithYear:[dateValue yearOfCommonEra]
>                                month:[dateValue monthOfYear]
>                                day:[dateValue dayOfMonth]
>                                hour:[dateValue hourOfDay]
>                                minute:[dateValue minuteOfHour]
>                                second:[dateValue secondOfMinute]
>                                timeZone:timeZone];
> </quote>

How has this patch been working out for you? Any unforseen side effects?

> Maybe to much overhead, with createing a new NSCalendarDate-Object.

It is OK with me;  groupware is massively read-oriented and this only
effects the write path.

--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Tobias Kaefer-3]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue Aug 25 2009 17:29:49 GMT+0200 (CEST) , Adam Tauno Williams wrote:

> On Mon, 2009-06-15 at 11:27 +0200, Tobias Kaefer wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>> On Mon Jun 08 2009 19:14:53 GMT+0200 (CEST), Adam Tauno WIlliams wrote:
>>> <quote>
>>>   /* if we successfuly aquired a date then make an adjustment to
>>>      GMT if a timezone was provided;  GMT values are not changed. */
>>>   if ([dateValue isNotNull]) {
>>>     zoneDiff = [timeZone secondsFromGMTForDate:dateValue];
>>>     if (zoneDiff != 0) {
>>>       dateValue = [dateValue dateByAddingYears:0
>>>                                         months:0
>>>                                           days:0
>>>                                          hours:0
>>>                                        minutes:0
>>>                                        seconds:(zoneDiff * -1)];
>>>   [dateValue setTimeZone:[NSTimeZone timeZoneWithAbbreviation:@"GMT"]];
>>>   return dateValue;
>>> </quote>
>> After knowing where to do some patching, the issue is very easy to
>> solve. I provided a patch for that (see
>> http://code.google.com/p/zogi/issues/detail?id=33#c5).
>> It's basically just this:
>> <quote>
>> dateValue = [NSCalendarDate dateWithYear:[dateValue yearOfCommonEra]
>>                                month:[dateValue monthOfYear]
>>                                day:[dateValue dayOfMonth]
>>                                hour:[dateValue hourOfDay]
>>                                minute:[dateValue minuteOfHour]
>>                                second:[dateValue secondOfMinute]
>>                                timeZone:timeZone];
>> </quote>
>
> How has this patch been working out for you? Any unforseen side effects?

No side effects so far. Everything is fine.

>> Maybe to much overhead, with createing a new NSCalendarDate-Object.
>
> It is OK with me;  groupware is massively read-oriented and this only
> effects the write path.
>




- --
Mit freundlichen Gruessen / with kind regards

Tobias S. Käfer

**********************************************************************
* Tobias S. Kaefer * Software-Developer * Diplom-Informatiker (BA)
* Tobias S. Käfer * Software-Entwickler * Diplom-Informatiker (BA)
* Portal-Development / Portal-Entwicklung
* ABAS Software AG  *  Südendstraße 42  *  76135 Karlsruhe  *  Germany
* Phone:   [phone]                 Fax:  [phone]
* Webpage: http://www.abas.de
* Board of Directors / Vorstand: Werner Strub, Peter Walser
* Chairman Board of Directors / Vorstandsvorsitzender: Werner Strub
* Chairman Supervisory Board / Aufsichtsratsvorsitzender: Thomas Frank
* HRB 107644 Amtsgericht Mannheim
**********************************************************************
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqUrtcACgkQdJJ1JNEzpd1gBACfWxH56eDYzo8WNQ5Uyv+KxE1F
MUQAn0iNZCu98l3OVd/bY9r3AUKMrYl8
=C46t
-----END PGP SIGNATURE-----
--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams]

     A. On Wed, 2009-08-26 at 05:41 +0200, Tobias Kaefer wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> On Tue Aug 25 2009 17:29:49 GMT+0200 (CEST) , Adam Tauno Williams wrote:
> > On Mon, 2009-06-15 at 11:27 +0200, Tobias Kaefer wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >> On Mon Jun 08 2009 19:14:53 GMT+0200 (CEST), Adam Tauno WIlliams wrote:
> >>> <quote>
> >>>   /* if we successfuly aquired a date then make an adjustment to
> >>>      GMT if a timezone was provided;  GMT values are not changed. */
> >>>   if ([dateValue isNotNull]) {
> >>>     zoneDiff = [timeZone secondsFromGMTForDate:dateValue];
> >>>     if (zoneDiff != 0) {
> >>>       dateValue = [dateValue dateByAddingYears:0
> >>>                                         months:0
> >>>                                           days:0
> >>>                                          hours:0
> >>>                                        minutes:0
> >>>                                        seconds:(zoneDiff * -1)];
> >>>   [dateValue setTimeZone:[NSTimeZone timeZoneWithAbbreviation:@"GMT"]];
> >>>   return dateValue;
> >>> </quote>
> >> After knowing where to do some patching, the issue is very easy to
> >> solve. I provided a patch for that (see
> >> http://code.google.com/p/zogi/issues/detail?id=33#c5).
> >> It's basically just this:
> >> <quote>
> >> dateValue = [NSCalendarDate dateWithYear:[dateValue yearOfCommonEra]
> >>                                month:[dateValue monthOfYear]
> >>                                day:[dateValue dayOfMonth]
> >>                                hour:[dateValue hourOfDay]
> >>                                minute:[dateValue minuteOfHour]
> >>                                second:[dateValue secondOfMinute]
> >>                                timeZone:timeZone];
> >> </quote>
> > How has this patch been working out for you? Any unforseen side effects?
> No side effects so far. Everything is fine.

This is applied to zOGI r1014.  I'll push this into the servers this
weekend and run some tests,  if it looks OK I'll flip it into ZideStore
next week.

--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc

[Adam Tauno Williams]

> > >> After knowing where to do some patching, the issue is very easy to
> > >> solve. I provided a patch for that (see
> > >> http://code.google.com/p/zogi/issues/detail?id=33#c5).
> > >> It's basically just this:
> > >> <quote>
> > >> dateValue = [NSCalendarDate dateWithYear:[dateValue yearOfCommonEra]
> > >>                                month:[dateValue monthOfYear]
> > >>                                day:[dateValue dayOfMonth]
> > >>                                hour:[dateValue hourOfDay]
> > >>                                minute:[dateValue minuteOfHour]
> > >>                                second:[dateValue secondOfMinute]
> > >>                                timeZone:timeZone];
> > >> </quote>
> > > How has this patch been working out for you? Any unforseen side effects?
> > No side effects so far. Everything is fine.
> This is applied to zOGI r1014.  I'll push this into the servers this
> weekend and run some tests,  if it looks OK I'll flip it into ZideStore
> next week.

This has been applied to r2278 of trunk (v5.5)

<http://code.google.com/p/zogi/issues/detail?id=33>

--
OpenGroupware.org XML-RPC
xmlrpc@...
http://mail.opengroupware.org/mailman/listinfo/xmlrpc